From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:42904) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ioyKR-0005lh-GJ for guix-patches@gnu.org; Tue, 07 Jan 2020 18:32:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ioyKQ-0004mB-Ey for guix-patches@gnu.org; Tue, 07 Jan 2020 18:32:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43612) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ioyKQ-0004lN-1c for guix-patches@gnu.org; Tue, 07 Jan 2020 18:32:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ioyKP-0001fM-T4 for guix-patches@gnu.org; Tue, 07 Jan 2020 18:32:01 -0500 Subject: [bug#38905] gnu: Add gnome-initial-setup. Resent-Message-ID: Date: Wed, 8 Jan 2020 00:31:14 +0100 From: Julien Lepiller Message-ID: <20200108003114.25d65184@tachikoma.lepiller.eu> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Raghav Gururajan Cc: 38905@debbugs.gnu.org Le Fri, 03 Jan 2020 15:51:58 -0500, Raghav Gururajan a =C3=A9crit : > Hello Guix! >=20 > Please find the attached patch to add gnome-initial-setup. >=20 > Regards, > RG. Thanks for the patch! I have a few questions about it, even though I didn't try to build it yet. What is optional in configure-flags? You should probably remove the comment in the inputs (the package doesn't exist, right?). I'm a bit puzzled by how this package works. Should some of these inputs be propagated or hard-coded in the code of the package? Shouldn't they be available at runtime? What does ibus, upower and the like do for the build itself? I think pkg-config should be a native-input. The description is a bit vague. What does it do exactly? Maybe there's some things that guix cannot setup and that's what it's used for? I'm not sure what the policy for "aims to" is, but I think I would remove it.