From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: bug#38926: pcmanfm-qt unable to open files by double click Date: Sun, 5 Jan 2020 10:56:55 +0100 Message-ID: <20200105105655.5dde2d6c@scratchpost.org> References: Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Mc.pD3E.9ZVSnVZJO9vAhE_"; protocol="application/pgp-signature"; micalg=pgp-sha256 Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:39748) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1io2fb-00019a-VA for bug-guix@gnu.org; Sun, 05 Jan 2020 04:58:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1io2fa-0008BC-N5 for bug-guix@gnu.org; Sun, 05 Jan 2020 04:58:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37686) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1io2fa-0008Ak-J3 for bug-guix@gnu.org; Sun, 05 Jan 2020 04:58:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1io2fa-00064P-Hh for bug-guix@gnu.org; Sun, 05 Jan 2020 04:58:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Reza Alizadeh Majd Cc: 38926@debbugs.gnu.org --Sig_/Mc.pD3E.9ZVSnVZJO9vAhE_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, thanks for the patch. Unfortunately, that way is not acceptable. Long story short, please make it a regular input. The reasoning is below: Guix has better modularity than most of the other distributions that exist. One of the main uses of modularity is isolation. If one module uses someth= ing internally, another module must not be disturbed by that fact. If (executable) package Q requires (library) package B@0.0.1 internally and (executable) package R requires (library) package B@0.0.2 internally then it works just fine to install both Q and R into the same profile. Why? Because B is not propagated into the profile (usually when B is an implementation detail of Q and R and not part of their public interface). If, on the other hand, B were propagated then the profile would not be able= to build because the two Bs would conflict. Debian, Gentoo, Redhat etcetc are different in that they basically ONLY have propagated-inputs and don't have regular inputs. They don't have the concept of an "internal" dependency. All their dependencies are external, changing the interface. Looking at https://fossies.org/linux/glib/gio/gio-launch-desktop.c , gio-launch-desktop is very small and not connected to anything else. Propagating it, with all the versioning problems that introduces, would be unwise. I propose instead to make glib bin a regular input of pcmanfm-qt and then substitute* the entire path to gio-launch-desktop in it inside a phase of pcmanfm-qt. As a rule of thumb, if something that a regular user would have never heard of ("glib" "bin" ... ???) makes it directly into his profile (by propagatio= n), it's probably the wrong thing to do. --Sig_/Mc.pD3E.9ZVSnVZJO9vAhE_ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl4RsucACgkQ5xo1VCww uqVgEwf/d6fhE97E7/N8Y6rLdYD0JtwN5YkADaB/4ENsOS2HDlj6LvISrC1c980A 81ml2aaqJ2Q9HeBO2/AfvQnEgRt3C+Rb4ED532bijnlscjzARCBi4g1Mx9bpHObz zS/LD9eemIGrdGH/acPj9jPZXIjY8Owo+Oos0KfzhJ2XQLw1aSNI72p+BRNMWIXQ SRJH7vcv/sElQSdRKokGXCG6UFEJP0FB4ncvWLVjPwXyUvB3Dhk8AEP8z3i8lt+I VgYGAKvqu4/hbAeMCaJJL50FuqDwzPAyY+rrLQaBRWvXTfF0v54NmkbYIXCvKRcc s0M18pAqxjgWI9g0Y6zNfS3Jvrd8Cg== =WgQV -----END PGP SIGNATURE----- --Sig_/Mc.pD3E.9ZVSnVZJO9vAhE_--