From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:37059) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imczn-00021O-90 for guix-patches@gnu.org; Wed, 01 Jan 2020 07:21:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imczm-0002eL-3T for guix-patches@gnu.org; Wed, 01 Jan 2020 07:21:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58006) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1imczl-0002do-V0 for guix-patches@gnu.org; Wed, 01 Jan 2020 07:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1imczl-00023V-RQ for guix-patches@gnu.org; Wed, 01 Jan 2020 07:21:01 -0500 Subject: [bug#38827] [PATCH] gnu: Add gitlab-runner. Resent-Message-ID: Date: Wed, 1 Jan 2020 14:20:17 +0200 From: Efraim Flashner Message-ID: <20200101122017.GQ23018@E5400> References: <20191231091757.69869-1-r.majd@pantherx.org> <87imlwsqir.fsf@gmail.com> <87d0c4sjam.fsf@gmail.com> <87tv5ga341.fsf@gmail.com> <878smsxd8i.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5LBS9LiS8wIv0ZHM" Content-Disposition: inline In-Reply-To: <878smsxd8i.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 38827@debbugs.gnu.org, Mathieu Othacehe , Reza Alizadeh Majd --5LBS9LiS8wIv0ZHM Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 01, 2020 at 12:54:37AM +0100, Ludovic Court=C3=A8s wrote: > Hello! >=20 > Mathieu Othacehe skribis: >=20 > >> I update the package definition following the above guidelines. > >> could you please check if this updated patch is acceptable? > > > > I fixed the indentation, added one space between the two description > > sentences and pushed. >=20 > The =E2=80=98vendor=E2=80=99 directory contains a large number of bundled= dependencies, > including various bits of Docker and Kubernetes. I=E2=80=99m not comfort= able > keeping this package as is. >=20 > Reza, could you look into unbundling these, or at least a significant > part of these? >=20 > There=E2=80=99s a Go importer at > , > but it=E2=80=99s for =E2=80=98Gopkg.toml=E2=80=99 files, which seem to be= out of fashion, so I=E2=80=99m > not sure it=E2=80=99d be useful. >=20 > In the meantime, I=E2=80=99d be in favor of reverting the patch. WDYT? >=20 Unfortunately I'm in agreement. I personally would keep in in a channel until it's been de-vendored. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --5LBS9LiS8wIv0ZHM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl4Mjn4ACgkQQarn3Mo9 g1HWeg//d0VQ7asB76iZmsz/m8s6hotP2YrHwZ1MGTZQGXZWwHhUs8wVhpjx8+/6 T/X48wYAkzWZ6MWyutfjMjrYG6qLBwGDajRnviAT45dTwX0iZLCAAtw5GwZf1Ss2 gSNmcP5TL2+UPnstnfiN6L+u3YfnuFbRi9cOhxTVSE7mfCeAfGLOlM8h0mg+VIO6 rKluX6lYqlBZdh1KSSuJF7Z2GsyGveSZCs4oDDEc+rRnMMVjOqe4BsGVivinmgMC VBj2OIYgw4SdJm2QQo8YnRgT+LrhYArh0JQjigrJtDXLyy4L3US+yoQLucY7pmTT GnJwXN2bQ497G2yQC6EBp+sIsQpxQv1WhzDYchp++eHhho8pNyom8MF8yXimeWn1 jOo7MIg0KAQMlnL9uo9vNSW70RM+xIzstVzke6Fjyf1YwqSV4fEbBKl/hiFmZRzM DkH/1u3GcHkstgiQfdgHm0ouJEm4ru4J0wEGekycCGyQYeDN6FH6TIsvOTNfwRPT N/iW/C+KduoY9VdOViQ49pVR4qJRhMCaibZYNUl9Nx+bKl9PyvTJd/iLgw9aaWBO asQAtciLFuKoS3Lm1vw46XcFo2ABZ9S+c+LCsrGwjKKQgSNOd56G4/VDt7gH/n+M 41iG3i/WuCsnt7Sm+o9mdm2XLtNt3aM6ejdCGNZi42yx4dTDvlo= =zKCO -----END PGP SIGNATURE----- --5LBS9LiS8wIv0ZHM--