From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: bug#38054: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Date: Sun, 22 Dec 2019 12:56:04 +0200 Message-ID: <20191222105604.GD1115@E5400> References: <20191127014038.GD17004@sax.terramar.selidor.net> <20191204201718.GA17141@sax.terramar.selidor.net> <20191205090236.GQ15280@E5400> <20191216014411.GC1392584@sax.terramar.selidor.net> <20191219130311.GH917@E5400> <20191219165155.GF1392584@sax.terramar.selidor.net> <20191220160758.GA2604844@sax.terramar.selidor.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="76DTJ5CE0DCVQemd" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:48022) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiyv1-0003TK-1l for bug-guix@gnu.org; Sun, 22 Dec 2019 05:57:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiyuz-0006Si-Uv for bug-guix@gnu.org; Sun, 22 Dec 2019 05:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43123) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iiyuz-0006Re-OK for bug-guix@gnu.org; Sun, 22 Dec 2019 05:57:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iiyuz-0006oX-NS for bug-guix@gnu.org; Sun, 22 Dec 2019 05:57:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Content-Disposition: inline In-Reply-To: <20191220160758.GA2604844@sax.terramar.selidor.net> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ivan Vilata i Balaguer Cc: 38054-done@debbugs.gnu.org, 38395-done@debbugs.gnu.org --76DTJ5CE0DCVQemd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 20, 2019 at 11:07:58AM -0500, Ivan Vilata i Balaguer wrote: > Ivan Vilata i Balaguer (2019-12-19 11:51:55 -0500) wrote: >=20 > > Efraim Flashner (2019-12-19 15:03:11 +0200) wrote: > >=20 > > > I merged the two patches together, made sure all the phases returned = #t > > > and flushed out the commit message some more. > >=20 > > Thanks a lot! Comparing your final patch against mine was also very > > instructive.=C2=A0`:)` >=20 > Before you close this issue, I upgraded my `mumble` package and many icon= s are > missing. I didn't yet have time to further investigate it, but maybe it's > because of a difference I noticed between your patch: >=20 > (modify-phases %standard-phases >=20 > and mine: >=20 > (modify-phases (@ (guix build qt-build-system) %standard-phases) >=20 > So maybe the problem is that the final, wrapping phase of `qt-build-syste= m` is > not being run. Actually I see that `mumble` is a plain binary while in t= he > output from my patch, it was a wrapper script. >=20 I'm not sure what happened with the wrapping phase, but I changed it back and now everything should be working as expected. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --76DTJ5CE0DCVQemd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl3/S8QACgkQQarn3Mo9 g1ES3w//dkVOxofsOOeFn05eRCVyre0KA9u5L49/zkR86p7z/XxwChN5YblHramu +kzlwhpGgUfqgIwf933+mBlaAK/7zMoFqZ/6OTxuD4uUTpT9l+crAhcHLOG/uWSD YwkmTmJTcUdVNZ5xJlP9WY+fJgjxeYqu2pkq6vJqTK6fN5waZvU5SB3BrRIknm/c HK87576/E4qhayEr6Dwuf0kcgrijpnH2kbTzcqUwad//UfZ67yM9fhJRTn0p82Gu EU8+co6+69TAFYBmw8VRWfwCmxGjiDTgkQHNCbQ/uk+AR9xPs+t90wEOS1S2IsWJ ghSibyfJdHQ0sV7UUOSaRnxDh7E0g2Ij3YeGc5ENdD1s02BQ4CmXtJ0esKQNdR1N xwhsdCFGGjsZcZLj3E18MgpngpL+ucdWK20LYuyuQciDmb0qZAuQyjuGHGd8cckw 8GT5ZAAJlRDKce+AzQ6ulGVOpwUB33AR004y9eCrsEobsOxmC8jEJ4YKsBHpMzfe 108P03+Fid6/9r2IQkPf/php1gPzr1er7zzKS5aR9hIICcxMRqzuoPnTEG7zyeBO Y4jiYKsRFYuLNMpGp8wrGAjTtVfmQMCCCjuTyIYMjsCHpz9i8Ot2Hvel0BvjFaIN Exc1etBatzwvfesyDlJb6Yn84ON/AlodlP8opyUlDRkskLqbf+I= =ra/V -----END PGP SIGNATURE----- --76DTJ5CE0DCVQemd--