From mboxrd@z Thu Jan 1 00:00:00 1970 From: "pelzflorian (Florian Pelz)" Subject: Re: Mailman packaging (was: Re: Python package naming: Dots vs hyphens) Date: Mon, 18 Nov 2019 14:14:12 +0100 Message-ID: <20191118131412.e6zjtw5tx6pnznl7@pelzflorian.localdomain> References: <20191106064955.rks6qsypuym6v6pt@pelzflorian.localdomain> <20191106071917.GJ14453@E5400> <20191106131833.5a2p7glowry2dhpk@pelzflorian.localdomain> <20191118101351.GH15074@E5400> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:37131) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWgrB-0000AK-6m for guix-devel@gnu.org; Mon, 18 Nov 2019 08:14:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWgr9-0003bC-Fs for guix-devel@gnu.org; Mon, 18 Nov 2019 08:14:17 -0500 Received: from pelzflorian.de ([5.45.111.108]:44842 helo=mail.pelzflorian.de) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iWgr8-0003aj-Sv for guix-devel@gnu.org; Mon, 18 Nov 2019 08:14:15 -0500 Content-Disposition: inline In-Reply-To: <20191118101351.GH15074@E5400> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel@gnu.org, pjotr2019@thebird.nl Thank you for your work and for looking at projects=E2=80=99 mailing list= s etc. :) I still have not set up mailman on my server, but am still going to work on it. I agree everywhere except the non-free emails and a typo in a description, see below. On Mon, Nov 18, 2019 at 12:13:51PM +0200, Efraim Flashner wrote: > On Wed, Nov 06, 2019 at 02:18:33PM +0100, pelzflorian (Florian Pelz) wr= ote: > > You have: > >=20 > > (define-public mailman > > (package > > ... > > (description > > "GNU Mailman is software for managing email discussion and maili= ng > > lists. Both users and administrators generally perform their actions= in a > > web interface, although email and command-line interfaces are also pr= ovided. > > The system features built-in archiving, automatic bounce processing, = content > > filtering, digest delivery, and more.") > >=20 > > I have: > >=20 > > (description "This is the core engine for the GNU Mailing List ma= nager. It > > is part of the full GNU Mailman 3 suite. Mailman is the GNU Mailing = List > > Manager, a program that manages electronic mail discussion groups.") > >=20 > > Maybe your mailman description is more appropriate later for a servic= e > > in doc/guix.texi instead of this package? Feel free to disagree. > >=20 >=20 > I kept mine for now >=20 OK. It is good for finding the main mailman package, I agree. > > You have: > >=20 > > (define-public python-flufl.bounce > > ... > > (description "The @code{flufl.bounce} library provides a set of heu= ristics > > and an API for detecting the original bouncing email addresses from a= bounce > > message. Many formats found in the wild are supported, as are VERP a= nd > > RFC 3464.") > > (license license:asl2.0))) > >=20 > >=20 > > I have the same package inputs etc., except: > >=20 > > (synopsis "Email bounce detectors") > > (description "The @dfn{flufl.bounce} library provides a set of he= uristics > > and an API for detecting the original bouncing email addresses from a= bounce > > message. Many formats found in the wild are supported, as are VERP a= nd RFC > > 3464 (DSN).") > > (license (list license:asl2.0 ;except for an emails used as test = data > > ;which may be non-free > > license:lgpl3)))) ;only for setup_helpers.py > >=20 > > I prefer your description without DSN at the end, but I prefer my > > license list. > >=20 >=20 > According to Debian the test emails are OK > https://sources.debian.org/src/flufl.bounce/3.0-1/debian/copyright/ >=20 AFAIU non-free e-mails as test data are not a problem for the FSDG anyway, but I am not convinced the authors listed in that Debian copyright file have asked the e-mails=E2=80=99 authors for permission. I cannot decide if a comment like > > (license (list license:asl2.0 ;except for an emails used as test = data > > ;which may be non-free is necessary though. Further below: > > I have: > >=20 > > (define-public python-dkimpy > > [=E2=80=A6] > > (license > > license:zlib)));except for an email used as test data which may = be non-free > >=20 > > Yours seems much better, except the license header. > >=20 > > This is the same as the above test data issue. I continue: > > You have: > >=20 > > (define-public python-flufl.lock > > ... > > (synopsis "NFS-safe file locking with timeouts for POSIX systems"= ) > > (description > > "This package provides NFS-safe file locking with timeouts for P= OSIX systems.") > > (license license:asl2.0))) > >=20 > > I have: > >=20 > > (synopsis > > "NFS-safe file locking with timeouts for POSIX systems.") > > (description > > "The @dfn{flufl.lock} package provides NFS-safe file locking wit= h > > timeouts for POSIX systems. It is similar to the @code{O_EXCL} optio= n of the > > @code{open} system call but uses a lockfile. Lock objects support > > lock-breaking so that you can=E2=80=99t wedge a process forever. Loc= ks have a > > lifetime, which is the maximum length of time the process expects to = retain > > the lock.") > > (license (list license:asl2.0 > > license:lgpl3)))) ;only for setup_helpers.py > >=20 > > I think my description is too long and yours is too short. I prefer > > my license list. >=20 > I took the first two sentences of yours and then combined the last two. >=20 Good. :) You are missing a plural s in the last sentence now though: (description "The @dfn{flufl.lock} package provides NFS-safe file locking with timeouts for POSIX systems. It is similar to the @code{O_EXCL} option of= the @code{open} system call but uses a lockfile. Lock object support lock-br= eaking and have a maximum lifetime built-in.") > >=20 > >=20 > > You have: > >=20 > > (define-public python-importlib-resources > > ... > >=20 > > I have no such package because it is no longer needed, I think. I > > have not packaged all dependencies yet so I cannot try building > > mailman. You made a comment in your mailman package that > > importlib-resources is no longer needed. > >=20 >=20 > I tried to build mailman without it but it complained that it was > missing. >=20 You are right. Changing this would require changes to many files. Your importlib_resources package looks fine. > > I have: > >=20 > > (define-public python-py3dns > > ... > > [=E2=80=A6] > > ;; license variant is the CNRI License Agreement for Python: > > (license license:psfl))) > >=20 > > Yours is better except the description and possibly license. >=20 > The license is already installed to %out/share/doc/name-version/LICENSE OK, I agree, such comments are superfluous. > I think I intended to come back for the description later :) >=20 Regards, Florian