From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ivan Vilata i Balaguer <ivan@selidor.net>
Subject: bug#38055: none
Date: Mon, 11 Nov 2019 10:10:10 -0500
Message-ID: <20191111151010.GO17621@sax.terramar.selidor.net>
References: <20191109182510.GA3954@E5400> <87k1873jjh.fsf@gnu.org>
 <20191111092730.GF3954@E5400>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:60085)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iUBMJ-0003UG-5z
 for bug-guix@gnu.org; Mon, 11 Nov 2019 10:12:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iUBMI-0004FJ-3Q
 for bug-guix@gnu.org; Mon, 11 Nov 2019 10:12:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:47083)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iUBMI-0004FB-0L
 for bug-guix@gnu.org; Mon, 11 Nov 2019 10:12:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iUBMH-0005MZ-QA
 for bug-guix@gnu.org; Mon, 11 Nov 2019 10:12:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.38055.D38055.157348506920549@debbugs.gnu.org>
Content-Disposition: inline
In-Reply-To: <20191111092730.GF3954@E5400>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 38055-done@debbugs.gnu.org, Ivan Vilata i Balaguer <ivan@selidor.net>

Efraim Flashner (2019-11-11 11:27:30 +0200) wrote:

> Some inline comments added. Patch pushed.

Wow, thank you so much for taking care of this!  I did prepare a patch on
Friday but I didn't have the time to send it, plus it pales in comparison to
Efraim's and it also had the `ipfs` binary segfault after patching.  I'm still
attaching it in case you're curious (of course I don't expect any of it to get
merged `;)`).

I'll try to find a moment to test your patch and see if the `ipfs` binary
doesn't segfault, then report back.

Thanks again!

-- 
Ivan Vilata i Balaguer -- https://elvil.net/