From: Miguel Arruga Vivas <rosen644835@gmail.com>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 37860@debbugs.gnu.org
Subject: bug#37860: qemu-4.1.0 build failure
Date: Sun, 3 Nov 2019 01:27:49 +0100 [thread overview]
Message-ID: <20191103012739.128b8114@gmail.com> (raw)
In-Reply-To: <20191021234827.177e45ea@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
Hi Danny,
Danny Milosavljevic <dannym@scratchpost.org> wrote:
> On Mon, 21 Oct 2019 23:39:32 +0200
> Danny Milosavljevic <dannym@scratchpost.org> wrote:
>
> > ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events:
> > assertion failed: (err == 0) ERROR - Bail out!
> > ERROR:tests/test-util-filemonitor.c:665:test_file_monitor_events:
> > assertion failed: (err == 0)
> >
> > Four times in a row now.
>
> guix commit 05b0b050bce644d96ed2222b7d88414f50bb23d9
I've hit the same error five times in a row too. The test seems to
depend on the order of notifications between two inotify queues (one
open on the folder and the other one open on the file name). I don't
know any easy way to fix it, so I propose to comment it out before
check phase as in the attached patch. What do you think?
Happy hacking!
Miguel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-qemu-Comment-out-failing-test.patch --]
[-- Type: text/x-patch, Size: 1355 bytes --]
From 53b06fdf0ff5fb343ae5548ff816d0f6fa455b96 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?=
<rosen644835@gmail.com>
Date: Sun, 3 Nov 2019 00:51:08 +0100
Subject: [PATCH] gnu: qemu: Comment out failing test.
* gnu/packages/virtualization.scm (qemu)[disable-unusable-tests]: Comment
out test-util-filemonitor from check phase.
---
gnu/packages/virtualization.scm | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index c2f46985f0..3183916174 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -196,6 +196,12 @@ exec smbd $@")))
;; fails within the build environment.
(("check-unit-.* tests/test-char" all)
(string-append "# " all)))
+ (substitute* "tests/Makefile.include"
+ ;; Comment out the test-util-filemonitor test, as it depends
+ ;; on a specific order of notification between two
+ ;; qemu_file_monitor queues.
+ (("check-unit-.* tests/test-util-filemonitor" all)
+ (string-append "# " all)))
#t)))))
(inputs ; TODO: Add optional inputs.
`(("alsa-lib" ,alsa-lib)
--
2.23.0
next prev parent reply other threads:[~2019-11-03 0:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 21:39 bug#37860: qemu-4.1.0 build failure Danny Milosavljevic
2019-10-21 21:48 ` Danny Milosavljevic
2019-11-03 0:27 ` Miguel Arruga Vivas [this message]
2019-11-03 16:24 ` Marius Bakke
2019-11-03 18:01 ` Danny Milosavljevic
2019-11-08 13:56 ` bug#37860: [PATCH v2] gnu: qemu: Add upstream patch for failing test Miguel Arruga Vivas
2019-11-10 21:20 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191103012739.128b8114@gmail.com \
--to=rosen644835@gmail.com \
--cc=37860@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.