From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: Help needed packaging rust-cbindgen, a dependency of IceCat 68 Date: Tue, 22 Oct 2019 23:06:24 +0300 Message-ID: <20191022200624.GB20347@E5400> References: <874l012t91.fsf@netris.org> <20191022185416.GA20347@E5400> <87zhhszhuv.fsf@netris.org> <87v9sgzh7u.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tqI+Z3u+9OQ7kwn0" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:42051) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iN0QK-0000Ye-5k for guix-devel@gnu.org; Tue, 22 Oct 2019 16:06:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iN0QG-0005d8-BY for guix-devel@gnu.org; Tue, 22 Oct 2019 16:06:32 -0400 Received: from flashner.co.il ([178.62.234.194]:54762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iN0QE-0005c5-Iu for guix-devel@gnu.org; Tue, 22 Oct 2019 16:06:28 -0400 Content-Disposition: inline In-Reply-To: <87v9sgzh7u.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver Cc: guix-devel@gnu.org --tqI+Z3u+9OQ7kwn0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 22, 2019 at 03:56:42PM -0400, Mark H Weaver wrote: > Hi Efraim, >=20 > Mark H Weaver writes: >=20 > > Efraim Flashner writes: > >> Here's what I have for rust-cbindgen based more-or-less on my > >> re-imagining of the cargo-build-system and the rust inputs. > > > > Thank you very much for this! Notably, I see that every package in your > > source has a proper 'license' field, and that there are *far* fewer > > dependencies here than 'guix import crate -r cbindgen' pulled in. I actually got the list from cbindgen's Cargo.lock file. I figured we were building far more than necessary, since we were throwing almost all the results. > > > > What's the feasibility of turning this file into a set of commits that > > could be applied to 'master' in the next day or two? If that could be > > done, it would be tremendously helpful. I think it's okay if these > > "re-imagined" Rust packages are all 'hidden' for now and put in a > > separate module, to avoid breaking anything else or interfering with the > > packages in crates.io. > > > > Would you like to do it? I wouldn't mind doing it. It'll have to wait until tomorrow though, it's getting late here. The motivation behind the 'hidden' part was so they could be public, so we could keep a list of rust sources in crates-io rather than spread around, but not visible, since I don't think any of them would build in their current form. >=20 > I looked again, and I see that you _already_ marked all of the packages > 'hidden' except for 'rust-cbindgen' itself. Perfect! Somehow I managed > to miss that on my first perusal of the code. >=20 > The only additional suggestion I'd make is to change 'define-public' to > 'define' for all of these packages except for 'rust-cbindgen', to avoid > possible conflicts in modules that import both 'cbindgen.scm' and > 'crates-io.scm'. Not a problem, we can always go back and change them around again later. >=20 > How about simply putting this file in (gnu packages rust-cbindgen) for > now, with the file header comment changed to match other files in Guix, > and with the trailing 'rust-cbindgen' at the bottom removed. >=20 > Would you like to do this? If not, I could do it. Sounds good. I can toss it in. >=20 > Thanks again! This is a great help and an enormous relief to me. >=20 > Mark I knew all the hours I spent banging my head against rust would come in handy :) --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --tqI+Z3u+9OQ7kwn0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl2vYT0ACgkQQarn3Mo9 g1EF2w//UXPA3QXEyyV2HVUS3VAd1dtXecqhZ12iFYfhCauwEoytr/bweVIJqHdc BqFi9rbtpd5iIGCmBoxl9vT2y1bKA8kicaBHm0q2POKOx+tFOxf412dq5WVDzBF3 Xl2O+h/ZNJHwK3g0j63KXpQcPnhuoK0FwXr8Z4k21zpGbDSoKa98F1fb5ZQIUdHV aM9xnz+sCnOURgYAYaHRcULXGcXl3Zc+wf7oW6KUhPjfjUNxdI983fE2MzKxL8gK AAM+fBMH5A8ie4zxlRb2daap7dFn/HBHuQxH5vG8ydnpv5kQhu9It09SLxFZb1q6 VRS0OxJ/JUQZbOr2Yi0J2+UzlkO735kadt4RRZVRopBSSzmq/t+CPfu3G+Liw3ou gbNiownCQlmNAYIeGB0ATOR2QKQQrhUqH7DxSXpYDaiBo1IRLwoq0N32ScxQ4uPx U3LyEHWYQjxLrYsOg+jSwskD/ROjEYfYJUfv8DmrsAt4wR+TCvy81aTHKOpGUg5K FDNeb4e+78+39lNqs8RbqkxB7eYZy7gP/Jfturq2ntnAIdEgEELMcnz96BL6pP2Z 0i8391Rby04OjdjWUF4icBswHVyqb/yXc5yu7DbH6tkmTHuKUsxZ/I9E9HJBj4dp 6+XKzVbLQF+KL/c9J9d7nRgQhCmik8jmKtmwCxYql3n9iWZhP9g= =2H/Q -----END PGP SIGNATURE----- --tqI+Z3u+9OQ7kwn0--