From: Danny Milosavljevic <dannym@scratchpost.org>
To: 37853@debbugs.gnu.org, Brice Waegeneire <brice@waegenei.re>
Cc: Mathieu Othacehe <m.othacehe@gmail.com>
Subject: [bug#37853] [PATCH] gnu: Add ddcci-driver-linux.
Date: Tue, 22 Oct 2019 15:06:39 +0200 [thread overview]
Message-ID: <20191022150639.74574b89@scratchpost.org> (raw)
In-Reply-To: <875zkh6rq5.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2371 bytes --]
Hi,
On Tue, 22 Oct 2019 11:42:58 +0200
Mathieu Othacehe <m.othacehe@gmail.com> wrote:
> It is a bit sad that we have to replicate 'build and 'install phases
> because of those two subfolders. However, I can't see an easy way to
> overcome this. Anyone?
You could get the existing phase via (assoc-ref %standard-phases 'build) and call
it twice (and I would).
Also, you could create two packages and chdir in an extra phase before "build"
(I wouldn't do that).
The former:
(define-public ddcci-driver-linux
(package
(name "ddcci-driver-linux")
(version "0.3.3")
(source
(origin
(method git-fetch)
(uri (git-reference
(url "https://gitlab.com/ddcci-driver-linux/ddcci-driver-linux.git")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
(base32
"0vkkja3ykjil783zjpwp0vz7jy2fp9ccazzi3afd4fjk8gldin7f"))))
(build-system linux-module-build-system)
(arguments
`(#:tests? #f ; no tests
#:phases
(modify-phases %standard-phases
(replace 'build
(lambda args
(for-each (lambda (module)
(with-directory-excursion module
(apply (assoc-ref %standard-phases 'build) args)))
'("ddcci" "ddcci-backlight"))
#t))
(replace 'install
(lambda args
(for-each (lambda (module)
(with-directory-excursion module
(apply (assoc-ref %standard-phases 'install) args)))
'("ddcci" "ddcci-backlight"))
#t)))))
(home-page "https://gitlab.com/ddcci-driver-linux/ddcci-driver-linux")
(synopsis "Linux kernel drivers for DDC/CI monitors")
(description "Two Linux kernel drivers, ddcci and ddcci-backlight, that
allow the control of DDC/CI monitors through the sysfs interface. ddcci create
a character device for each DDC/CI monitors in @file{/dev/bus/ddcci/[I²C bus number]}.
ddcci-backlight allow the control of the backlight level or luminance property when supported
under @file{/sys/class/backlight/}.")
(license license:gpl2+)))
@Brice:
Could you send an updated patch along those lines?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-10-22 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 15:16 [bug#37853] [PATCH] gnu: Add ddcci-driver-linux Brice Waegeneire
2019-10-22 9:42 ` Mathieu Othacehe
2019-10-22 13:06 ` Danny Milosavljevic [this message]
2019-10-25 9:32 ` [bug#37853] Brice Waegeneire
2019-10-25 9:32 ` [bug#37853] [PATCH v2] gnu: Add ddcci-driver-linux Brice Waegeneire
2019-10-25 9:50 ` Mathieu Othacehe
2019-10-25 10:24 ` [bug#37853] Brice Waegeneire
2019-10-25 10:24 ` [bug#37853] [PATCH v3] gnu: Add ddcci-driver-linux Brice Waegeneire
2019-10-25 11:34 ` [bug#37853] Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022150639.74574b89@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=37853@debbugs.gnu.org \
--cc=brice@waegenei.re \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.