From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:51616)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iLP79-0008VW-Na
 for guix-patches@gnu.org; Fri, 18 Oct 2019 06:04:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iLP78-0003ue-KG
 for guix-patches@gnu.org; Fri, 18 Oct 2019 06:04:07 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:40610)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iLP78-0003uI-Fm
 for guix-patches@gnu.org; Fri, 18 Oct 2019 06:04:06 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iLP74-0004l0-IC
 for guix-patches@gnu.org; Fri, 18 Oct 2019 06:04:05 -0400
Subject: [bug#37788] [PATCH] gnu: Add minisign.
References: <20191017080233.dcsjsyh5ui6x67kj@rafflesia>
In-Reply-To: <20191017080233.dcsjsyh5ui6x67kj@rafflesia>
Resent-Message-ID: <handler.37788.B37788.157139299718214@debbugs.gnu.org>
Date: Fri, 18 Oct 2019 12:03:10 +0200
From: Tanguy Le Carrour <tanguy@bioneland.org>
Message-ID: <20191018100310.odkacqejqpes7f7i@rafflesia>
MIME-Version: 1.0
Content-Type: text/plain; charset=unknown-8bit
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 37788@debbugs.gnu.org

Hello Mathieu!

Thanks for reviewing!

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
> Please pass --subject-prefix="PATCH v2" to git format-patch so that it
> is easier to identify patch revisions.

I'll try to keep that it mind for next time!


>> +     ; No test suite
>You can put it on the same line as the one below.
>> +     `(#:tests? #f))

I did… then ran etc/indent-code.el which pushed the comment far away on
the right. It looked weird, so I moved it above. Next time I'll leave it
where the indent-code script puts it.


>You also did forget to add the Copyright on top.

*Oups*… thanks for noticing!


>Otherwise seems fine :). I fixed the points above and pushed it.

Thanks!


-- 
Tanguy