all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tanguy Le Carrour <tanguy@bioneland.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 37598@debbugs.gnu.org, Mathieu Othacehe <m.othacehe@gmail.com>
Subject: [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time.
Date: Mon, 14 Oct 2019 09:09:30 +0200	[thread overview]
Message-ID: <20191014070930.b2dbefwyiegup2q5@rafflesia> (raw)
In-Reply-To: <871rvg8fss.fsf@gnu.org>

Hi Ludovic, Hi Mathieu!


Le 10/14, Ludovic Courtès a écrit :
> Did you have a chance to look into Mathieu’s suggestions (below)?

No!… because I don't get notifications when someone sends a comment on a
bug I opened! :-(
I have to go and check the 2 others I opened, I guess! I hope I didn't
seem to give up on them!


> Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> > Hello Tanguy,

Sorry for not answering! And thanks for the time you spent into
reviewing my patches!


> > Thanks for your patches. A few remarks (more details at
> > https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html):
> >
> >> Subject: [PATCH 1/4] gnu: Add python-jinja2-time.
> >
> > You need to add a commit message, compliant with ChangeLog format. You
> > can find examples in commit history.

I have to confess that I am… a minimalist! :-)
I thought that `gnu: Add python-jinja2-time.` would be enough and I didn't have
to go into more details about the "why"!
Please believe me when I say that it was not out of laziness.
I'll go dig into commit messages and see what I have to add.


> >> +    (description
> >> +     "Jinja2 Extension for Dates and Times")
> >
> > Description should follow the rules dictated at
> > https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html#Synopses-and-Descriptions,
> > most specifically "Descriptions should take between five and ten
> > lines. Use full sentences, and avoid using acronyms without first
> > introducing them".

OK, this one was pure laziness! So far, I've never modified description/synopsis
provided by `guix import`.
I guess, now that I'm more comfortable with the process, I can focus more on
"what" I am submitting and less on "how" I am submitting it!

Thanks again guys for your time. I'll fix the patches and resubmit them as
soon as I can!


-- 
Tanguy

  reply	other threads:[~2019-10-14  7:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03 12:13 [bug#37598] [PATCH 0/4] gnu: Add Cookiecutter and its inputs Tanguy Le Carrour
2019-10-03 12:16 ` [bug#37598] [PATCH 1/4] " Tanguy Le Carrour
2019-10-03 12:17 ` [bug#37598] [PATCH 2/4] " Tanguy Le Carrour
2019-10-03 12:18 ` [bug#37598] [PATCH 3/4] " Tanguy Le Carrour
2019-10-03 12:19 ` [bug#37598] [PATCH 4/4] " Tanguy Le Carrour
2019-10-04  7:00 ` [bug#37598] [PATCH 0/4] gnu: Add python-cookiecutter " Tanguy Le Carrour
2019-10-04  7:20 ` [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time Tanguy Le Carrour
2019-10-04  7:50   ` Mathieu Othacehe
2019-10-13 22:02     ` Ludovic Courtès
2019-10-14  7:09       ` Tanguy Le Carrour [this message]
2019-10-14 20:25         ` Ludovic Courtès
2019-10-15 12:28         ` bug#37598: " Mathieu Othacehe
2019-10-15 13:14           ` [bug#37598] " Tanguy Le Carrour
2019-10-04  7:21 ` [bug#37598] [PATCH 2/4] gnu: Add python-poyo Tanguy Le Carrour
2019-10-04  7:23 ` [bug#37598] [PATCH 3/4] gnu: Add python-whichcraft Tanguy Le Carrour
2019-10-04  7:24 ` [bug#37598] [PATCH 4/4] gnu: Add python-cookiecutter Tanguy Le Carrour
2019-10-14 14:29 ` [bug#37598] Updating patches Tanguy Le Carrour
2019-10-14 15:20   ` Mathieu Othacehe
2019-10-14 14:30 ` [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time Tanguy Le Carrour
2019-10-14 14:31 ` [bug#37598] [PATCH 2/4] gnu: Add python-poyo Tanguy Le Carrour
2019-10-14 14:31 ` [bug#37598] [PATCH 3/4] gnu: Add python-whichcraft Tanguy Le Carrour
2019-10-14 14:32 ` [bug#37598] [PATCH 4/4] gnu: Add python-cookiecutter Tanguy Le Carrour
2019-10-15  7:37 ` [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time Tanguy Le Carrour
2019-10-15  7:38 ` [bug#37598] [PATCH 2/4] gnu: Add python-poyo Tanguy Le Carrour
2019-10-15  7:40 ` [bug#37598] [PATCH 3/4] gnu: Add python-whichcraft Tanguy Le Carrour
2019-10-15  7:41 ` [bug#37598] [PATCH 4/4] gnu: Add python-cookiecutter Tanguy Le Carrour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191014070930.b2dbefwyiegup2q5@rafflesia \
    --to=tanguy@bioneland.org \
    --cc=37598@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=m.othacehe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.