[PATCH 0/4] gnu: Add Cookiecutter and its inputs

[PATCH 0/4] gnu: Add Cookiecutter and its inputs

[Tanguy Le Carrour]

Dear Guix

As I'm still a newbie, I'm sending those patches for review before
submitting them to guix-patches@gnu.org.

Thanks for reviewing!

-- 
Tanguy

[PATCH 1/4] gnu: Add Cookiecutter and its inputs

[Tanguy Le Carrour]

[-- Attachment #1: Type: text/plain, Size: 12 bytes --]


-- 
Tanguy

[-- Attachment #2: 0001-gnu-Add-Cookiecutter-and-its-inputs.patch --]
[-- Type: text/plain, Size: 1695 bytes --]

From dc07c609430e9e63dd4d87b71d84545db87d9f8c Mon Sep 17 00:00:00 2001
From: "tanguy@bioneland.org" <tanguy@bioneland.org>
Date: Thu, 3 Oct 2019 09:05:26 +0200
Subject: [PATCH 1/4] gnu: Add Cookiecutter and its inputs

---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 413d68c258..e041adfdc4 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -66,6 +66,7 @@
 ;;; Copyright © 2019 Jacob MacDonald <jaccarmac@gmail.com>
 ;;; Copyright © 2019 Giacomo Leidi <goodoldpaul@autistici.org>
 ;;; Copyright © 2019 Wiktor Żelazny <wzelazny@vurv.cz>
+;;; Copyright © 2019 Tanguy Le Carrour <tanguy@bioneland.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2475,6 +2476,28 @@ written in pure Python.")
 (define-public python2-jinja2
   (package-with-python2 python-jinja2))
 
+(define-public python-jinja2-time
+  (package
+    (name "python-jinja2-time")
+    (version "0.2.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "jinja2-time" version))
+        (sha256
+          (base32
+            "0h0dr7cfpjnjj8bgl2vk9063a53649pn37wnlkd8hxjy656slkni"))))
+    (build-system python-build-system)
+    (propagated-inputs
+      `(("python-arrow" ,python-arrow)
+        ("python-jinja2" ,python-jinja2)))
+    (home-page
+      "https://github.com/hackebrot/jinja2-time")
+    (synopsis "Jinja2 Extension for Dates and Times")
+    (description
+      "Jinja2 Extension for Dates and Times")
+    (license license:expat)))
+
 (define-public python-pystache
   (package
     (name "python-pystache")
-- 
2.23.0

[PATCH 2/4] gnu: Add Cookiecutter and its inputs

[Tanguy Le Carrour]

[-- Attachment #1: Type: text/plain, Size: 12 bytes --]


-- 
Tanguy

[-- Attachment #2: 0002-gnu-Add-Cookiecutter-and-its-inputs.patch --]
[-- Type: text/plain, Size: 1232 bytes --]

From b1a708198ea93c5a6d591d6b4ac864819de432e3 Mon Sep 17 00:00:00 2001
From: "tanguy@bioneland.org" <tanguy@bioneland.org>
Date: Thu, 3 Oct 2019 09:13:59 +0200
Subject: [PATCH 2/4] gnu: Add Cookiecutter and its inputs

---
 gnu/packages/python-xyz.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index e041adfdc4..eb326aae6f 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -1552,6 +1552,25 @@ existing ones.")
                    ;; Tests don't work with python2.
                    #:tests? #f)))))
 
+(define-public python-poyo
+  (package
+    (name "python-poyo")
+    (version "0.5.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "poyo" version))
+        (sha256
+          (base32
+            "1pflivs6j22frz0v3dqxnvc8yb8fb52g11lqr88z0i8cg2m5csg2"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/hackebrot/poyo")
+    (synopsis
+      "Lightweight YAML Parser for Python")
+    (description
+      "A lightweight YAML Parser for Python.")
+    (license license:expat)))
+
 (define-public scons
   (package
     (name "scons")
-- 
2.23.0

[PATCH 3/4] gnu: Add Cookiecutter and its inputs

[Tanguy Le Carrour]

[-- Attachment #1: Type: text/plain, Size: 12 bytes --]


-- 
Tanguy

[-- Attachment #2: 0003-gnu-Add-Cookiecutter-and-its-inputs.patch --]
[-- Type: text/plain, Size: 1439 bytes --]

From 3d244fab04f6de3dcdd888ce1e1877f8f6b2b0f0 Mon Sep 17 00:00:00 2001
From: "tanguy@bioneland.org" <tanguy@bioneland.org>
Date: Thu, 3 Oct 2019 09:17:05 +0200
Subject: [PATCH 3/4] gnu: Add Cookiecutter and its inputs

---
 gnu/packages/python-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index eb326aae6f..df64e780d8 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -9108,6 +9108,28 @@ server with very acceptable performance.")
 (define-public python2-waitress
   (package-with-python2 python-waitress))
 
+(define-public python-whichcraft
+  (package
+    (name "python-whichcraft")
+    (version "0.6.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "whichcraft" version))
+        (sha256
+          (base32
+            "11yfkzyplizdgndy34vyd5qlmr1n5mxis3a3svxmx8fnccdvknxc"))))
+    (build-system python-build-system)
+    (native-inputs
+      `(("python-pytest" ,python-pytest)))
+    (home-page
+      "https://github.com/pydanny/whichcraft")
+    (synopsis
+      "This package provides cross-platform cross-python shutil.which functionality")
+    (description
+      "This package provides cross-platform cross-python shutil.which functionality.")
+    (license license:bsd-3)))
+
 (define-public python-pyquery
   (package
     (name "python-pyquery")
-- 
2.23.0

[PATCH 4/4] gnu: Add Cookiecutter and its inputs

[Tanguy Le Carrour]

[-- Attachment #1: Type: text/plain, Size: 12 bytes --]


-- 
Tanguy

[-- Attachment #2: 0004-gnu-Add-Cookiecutter-and-its-inputs.patch --]
[-- Type: text/plain, Size: 2154 bytes --]

From 2d0e7649de9e34fd3dd73f78d00f6b9dde9acc4a Mon Sep 17 00:00:00 2001
From: "tanguy@bioneland.org" <tanguy@bioneland.org>
Date: Thu, 3 Oct 2019 09:23:24 +0200
Subject: [PATCH 4/4] gnu: Add Cookiecutter and its inputs

---
 gnu/packages/python-xyz.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index df64e780d8..d2bd1a661d 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -9130,6 +9130,41 @@ server with very acceptable performance.")
       "This package provides cross-platform cross-python shutil.which functionality.")
     (license license:bsd-3)))
 
+(define-public python-cookiecutter
+  (package
+    (name "python-cookiecutter")
+    (version "1.6.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "cookiecutter" version))
+        (sha256
+          (base32
+            "0glsvaz8igi2wy1hsnhm9fkn6560vdvdixzvkq6dn20z3hpaa5hk"))))
+    (build-system python-build-system)
+    (native-inputs
+      `(("python-freezegun" ,python-freezegun)
+        ("python-pytest" ,python-pytest)
+        ("python-pytest-catchlog" ,python-pytest-catchlog)
+        ("python-pytest-cov" ,python-pytest-cov)
+        ("python-pytest-mock" ,python-pytest-mock)))
+    (propagated-inputs
+      `(("python-binaryornot" ,python-binaryornot)
+        ("python-click" ,python-click)
+        ("python-future" ,python-future)
+        ("python-jinja2" ,python-jinja2)
+        ("python-jinja2-time" ,python-jinja2-time)
+        ("python-poyo" ,python-poyo)
+        ("python-requests" ,python-requests)
+        ("python-whichcraft" ,python-whichcraft)))
+    (home-page
+      "https://github.com/audreyr/cookiecutter")
+    (synopsis
+      "Command-line utility that creates projects from project templates")
+    (description "A command-line utility that creates projects from project templates,
+e.g. creating a Python package project from a Python package project template.")
+    (license license:bsd-3)))
+
 (define-public python-pyquery
   (package
     (name "python-pyquery")
-- 
2.23.0

Re: [PATCH 0/4] gnu: Add Cookiecutter and its inputs

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

Hello,

Tanguy Le Carrour <tanguy@bioneland.org> ezt írta (időpont: 2019. okt. 3.,
Csü 9:45):

> Dear Guix
>
> As I'm still a newbie, I'm sending those patches for review before
> submitting them to guix-patches@gnu.org.
>
> Thanks for reviewing!
>
Guix patches is a patch review queue. Feel free to post them there. Please
post the cover letter first to open a new issue, and post the rest to the
assigned issue number.

>
> --
> Tanguy
>
Best regards,
g_bor

>

[-- Attachment #2: Type: text/html, Size: 1246 bytes --]

Re: [PATCH 0/4] gnu: Add Cookiecutter and its inputs

[Tanguy Le Carrour]

Hi Gábor!

Thanks for your answer.

Le 10/03, Gábor Boskovits a écrit :
> Guix patches is a patch review queue. Feel free to post them there. Please
> post the cover letter first to open a new issue, and post the rest to the
> assigned issue number.

I've just figured out that one could submit the package AND its
dependencies in one patch [1]. Is it easier to review than sending
4 different patchs/emails?!

[1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35752

Also, I tried (but failed) to put the packages in alphabetical order,
so they are scattered all over the file. Would it be better to have them
side by side?

Regards,

-- 
Tanguy

Re: [PATCH 0/4] gnu: Add Cookiecutter and its inputs

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]

Hello,

Tanguy Le Carrour <tanguy@bioneland.org> ezt írta (időpont: 2019. okt. 3.,
Cs, 13:39):

> Hi Gábor!
>
> Thanks for your answer.
>
> Le 10/03, Gábor Boskovits a écrit :
> > Guix patches is a patch review queue. Feel free to post them there.
> Please
> > post the cover letter first to open a new issue, and post the rest to the
> > assigned issue number.
>
> I've just figured out that one could submit the package AND its
> dependencies in one patch [1]. Is it easier to review than sending
> 4 different patchs/emails?!
>
> [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35752
>
>
You can see in the second letter of the thread that keeping the patches
separate is preferred.


> Also, I tried (but failed) to put the packages in alphabetical order,
> so they are scattered all over the file. Would it be better to have them
> side by side?
>

I don't believe this to be a big problem. It should be ok.


> Regards,
>
> --
> Tanguy
>

Best regards,
g_bor
-- 
OpenPGP Key Fingerprint: 7988:3B9F:7D6A:4DBF:3719:0367:2506:A96C:CF63:0B21

[-- Attachment #2: Type: text/html, Size: 2023 bytes --]

Re: [PATCH 0/4] gnu: Add Cookiecutter and its inputs

[Tanguy Le Carrour]

Le 10/03, Gábor Boskovits a écrit :
> Tanguy Le Carrour <tanguy@bioneland.org> ezt írta (időpont: 2019. okt. 3.,
> > I've just figured out that one could submit the package AND its
> > dependencies in one patch [1]. Is it easier to review than sending
> > 4 different patchs/emails?!
> >
> > [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=35752
> >
> >
> You can see in the second letter of the thread that keeping the patches
> separate is preferred.

*outch*… I should have seen it!

Thanks!

-- 
Tanguy