From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:59823) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i5qXX-0007ra-9F for guix-patches@gnu.org; Thu, 05 Sep 2019 08:07:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i5qXW-000275-8e for guix-patches@gnu.org; Thu, 05 Sep 2019 08:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54310) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i5qXW-00026w-40 for guix-patches@gnu.org; Thu, 05 Sep 2019 08:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i5qXV-0001kr-SZ for guix-patches@gnu.org; Thu, 05 Sep 2019 08:07:01 -0400 Subject: [bug#36410] [PATCH] gnu: Add screenfetch. Resent-Message-ID: Date: Thu, 5 Sep 2019 15:06:20 +0300 From: Efraim Flashner Message-ID: <20190905120620.GV13917@E5400> References: <8736ju8rrt.fsf@sdf.lonestar.org> <20190702071850.GA22794@macbook41> <87r278to70.fsf@sdf.lonestar.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nbjgUHX6eyHhY7pW" Content-Disposition: inline In-Reply-To: <87r278to70.fsf@sdf.lonestar.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: "Jakob L. Kreuze" Cc: 36410@debbugs.gnu.org --nbjgUHX6eyHhY7pW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I'm sorry, this one fell through the cracks and I forgot about it. On Tue, Jul 02, 2019 at 12:07:31PM -0400, Jakob L. Kreuze wrote: > Hi Efraim, >=20 > Efraim Flashner writes: >=20 > > If 'install-file' works here then the above 6 lines can be 2, something > > like: > > (install-file (string-append source "/screenfetch.1") > > (string-append %output "/man/man1/")) >=20 > That's certainly much clearer. Would it make sense to do the same for > 'screenfetch-dev', renaming the file after copying it with > 'install-file'? Or, should a '#:rename' keyword be added to > 'install-file', perhaps? I don't know if it would be a useful pattern or > not, but it's an easy addition and I'd be happy to submit a separate > patch if there's any interest. >=20 I think since we want to rename it anyway I wouldn't bother with 'install-file' for screenfetch-dev. > > you can use the patch-shebang function here, should help a bit. >=20 > Thanks, that seems to be just one of many hidden gems in '(guix build > utils)'. I should really skim through that whole file at some point, > these procedures would definitely make packaging much easier. >=20 > > Ideally these should wrap the binary rather than being propagated. >=20 > I'm a bit unsure as to what you mean. Should I patch the screenfetch > script to use absolute paths for the binaries of these inputs? I.e. > patch 'bc' to '/gnu/store/...-bc-1.07.1/bin/bc'? I found an example of what I was thinking of in (gnu packages dictionaries), with translate-shell. The function itself is called 'wrap-program'. Can you send an updated patch? thanks --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --nbjgUHX6eyHhY7pW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl1w+jkACgkQQarn3Mo9 g1F2wxAAqAl0GcEhOlBRfmfmovJQ9BnDVfi1uzTfd0GPpkUYc+kyN/OL52d196fE PHW0+pNALeyzq0on6nAyCEydkC5bdXLZodO+zo8ImFu6EcmSKtdyCq6dgiNDfmn5 QkdiK11hE1BNOrRssTT/q4iX6sSu6O1l/qacgfrXpYm/Le2SzQTmtU4SuAaZgFOt K96ki1cTZAhmZ63EJv2obsh4Dhd9m316VNp5D1gJoWoyGedqE/aC55N65VyFzX/v 2mMs2blTGtbBMpxx069jDqutT5WhMIfLnQnwdOXbEZ1CV3xtMK3Echm3dCCzLVOc 2oREz3PcisppHviaZI181idBvMeD9MaT4hawCe3d8KBGyjZc1PnQ7JmuIa/Ih/bj jA1H2pp/81wglS/jLq/Jw0ZRYuERdMQZRbRXCVIJpbsdI7GtY/PtKDrbE13x8t8Z TZYwNOhF6RLkPoTuiYfQc7Y7AmDC/JK9vh69m10TkNwv/9lJga6+YZwZFh3Pc3PP JMzcvn1QewMhh4utYOTsSNeVRH9SvFZxGBTbEJ0fGIFlQgpMOxfYfRV4rtMi3kSc FfulSkSkEONg9iZ1AgzCpGvMrye0qGRd1Kspvu2MjmGXjbCNQkfl+1KBPAyCVi9A QvBEoJE4/o+YKB6zzDaS06/AdUyWdFTWtX6C+pK+HijYSkD46Sc= =nFUs -----END PGP SIGNATURE----- --nbjgUHX6eyHhY7pW--