From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:52790) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvcYl-0005pC-Mz for guix-patches@gnu.org; Thu, 08 Aug 2019 03:10:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvcYk-0000b0-P8 for guix-patches@gnu.org; Thu, 08 Aug 2019 03:10:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59261) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvcYk-0000ao-Lg for guix-patches@gnu.org; Thu, 08 Aug 2019 03:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hvcYk-0005oa-D1 for guix-patches@gnu.org; Thu, 08 Aug 2019 03:10:02 -0400 Subject: bug#36962: [PATCH] gnu: Add network-manager-openconnect. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Thu, 8 Aug 2019 10:09:02 +0300 From: Efraim Flashner Message-ID: <20190808070902.GA5507@E2140> References: <20190807170450.2996-1-efraim@flashner.co.il> <877e7oyg80.fsf@elephly.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: <877e7oyg80.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 36962-done@debbugs.gnu.org --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 07, 2019 at 08:37:19PM +0200, Ricardo Wurmus wrote: >=20 > Hi Efraim, >=20 > > * gnu/packages/gnome.scm (network-manager-openconnect): New variable. >=20 > This looks good to me. >=20 > Why is this in gnome.scm and not in, say, networking? The other network-manager VPN addons are also in gnome so I stuck it with the others. >=20 > > + (substitute* "src/nm-openconnect-service.c" > > + (("\"/usr/local/sbin/openconnect\"") pretty-ovpn) > > + (("\"/usr/sbin/openconnect\"") pretty-ovpn) > > + (("/sbin/modprobe") modprobe))) >=20 > The indentation looks wrong. I actually just copied it from one of the other ones, I'll go ahead and fix it. Thanks --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl1Lyo4ACgkQQarn3Mo9 g1GicA//fGITpDrPoPfpmKvWtFAQcLURO+2aNlru91twXR9EVHKNGvCNTRF8gyCN pyK3EqfWGaJuAv7rmkkK77CsiVobZ8V5aPZufwzdHYuWrUMhxMjUYrRFD06HeuIq f+BYHJBc8ECTH44MLmTTkRL5sv24PEFaKDmLKsMq+M+LekNEsk7JsS/ID17DhGVJ sfSCYKhw3OrMhV+a7AZXvIAtYrqe+RStNIOmZVo25T9WtGgBWCor1UkgJydvSMRo JpLWw2SNYh8Zy6267ARmb/jajdy4CDxX4iFDrYeaB2jZTXCwFs+HODyFlE2UnfHs OGzl4fZwHcJzUc+rnlelt89/vrdwcVsFoMbOraguuwInC+F7gS3hxWNZqpU6SbTW QT7JLTh82tkXv1FqXqENFPwbeNpDPXMGZzeojQhysqFMO3rtfwJzOwwyHbJWwhqx vsVi1kWRyMaISD4hvch6ULTZRtlpQN5s6s3nj8XMkyLlkgAy2pzUDiHoQGJse2gZ MBc7QgfxSpTJ/soaUtX3Kk0UqtTtGp1BRXIe8l9zsyKoGY9vxwLjS8i9l7CWDJiZ ChLxlQ2Q7ky00BbjKEv1UGjIKMhO2zUoMOnhSjHLN+rdtm4BRzff+w4mUkHXQvht D9+wpg2QnjjspEDLtbz4TbVAilbiXgp44TXL3Yc+ihTE//WlZRA= =L9fz -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--