[bug#36962] [PATCH] gnu: Add network-manager-openconnect.

[bug#36962] [PATCH] gnu: Add network-manager-openconnect.

[Efraim Flashner]

* gnu/packages/gnome.scm (network-manager-openconnect): New variable.
---
 gnu/packages/gnome.scm | 51 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 601248b7f5..5c4085751f 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5535,6 +5535,57 @@ Compatible with Cisco VPN concentrators configured to use IPsec.")
     (license license:gpl2+)
     (properties `((upstream-name . "NetworkManager-vpnc")))))
 
+(define-public network-manager-openconnect
+  (package
+    (name "network-manager-openconnect")
+    (version "1.2.6")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://gnome/sources/NetworkManager-openconnect/"
+                    (version-major+minor version)
+                    "/NetworkManager-openconnect-" version ".tar.xz"))
+              (sha256
+               (base32
+                "0nlp290nkawc4wqm978n4vhzg3xdqi8kpjjx19l855vab41rh44m"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags '("--enable-absolute-paths" "--localstatedir=/var")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'configure 'patch-path
+           (lambda* (#:key inputs outputs #:allow-other-keys #:rest args)
+             (let* ((openconnect (string-append (assoc-ref inputs "openconnect")
+                                         "/sbin/openconnect"))
+                    (modprobe (string-append (assoc-ref inputs "kmod")
+                                             "/bin/modprobe"))
+                    (pretty-ovpn (string-append "\"" openconnect "\"")))
+               (substitute* "src/nm-openconnect-service.c"
+                    (("\"/usr/local/sbin/openconnect\"") pretty-ovpn)
+                    (("\"/usr/sbin/openconnect\"") pretty-ovpn)
+                    (("/sbin/modprobe") modprobe)))
+             #t)))))
+    (native-inputs
+     `(("intltool" ,intltool)
+       ("network-manager-applet" ,network-manager-applet) ;for libnma
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("gcr" ,gcr)
+       ("gtk+" ,gtk+)
+       ("kmod" ,kmod)
+       ("libsecret" ,libsecret)
+       ("libxml2" ,libxml2)
+       ("network-manager" ,network-manager)
+       ("openconnect" ,openconnect)))
+    (home-page "https://wiki.gnome.org/Projects/NetworkManager/VPN")
+    (synopsis "OpenConnect plug-in for NetworkManager")
+    (description
+     "This extension of NetworkManager allows it to take care of connections
+to @acronym{VPNs, virtual private networks} via OpenConnect, an open client for
+Cisco's AnyConnect SSL VPN.")
+    (license license:gpl2+)
+    (properties `((upstream-name . "NetworkManager-openconnect")))))
+
 (define-public mobile-broadband-provider-info
   (package
     (name "mobile-broadband-provider-info")
-- 
2.22.0

[bug#36962] [PATCH] gnu: Add network-manager-openconnect.

[Ricardo Wurmus]

Hi Efraim,

> * gnu/packages/gnome.scm (network-manager-openconnect): New variable.

This looks good to me.

Why is this in gnome.scm and not in, say, networking?

> +               (substitute* "src/nm-openconnect-service.c"
> +                    (("\"/usr/local/sbin/openconnect\"") pretty-ovpn)
> +                    (("\"/usr/sbin/openconnect\"") pretty-ovpn)
> +                    (("/sbin/modprobe") modprobe)))

The indentation looks wrong.

-- 
Ricardo

bug#36962: [PATCH] gnu: Add network-manager-openconnect.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

On Wed, Aug 07, 2019 at 08:37:19PM +0200, Ricardo Wurmus wrote:
> 
> Hi Efraim,
> 
> > * gnu/packages/gnome.scm (network-manager-openconnect): New variable.
> 
> This looks good to me.
> 
> Why is this in gnome.scm and not in, say, networking?

The other network-manager VPN addons are also in gnome so I stuck it
with the others.

> 
> > +               (substitute* "src/nm-openconnect-service.c"
> > +                    (("\"/usr/local/sbin/openconnect\"") pretty-ovpn)
> > +                    (("\"/usr/sbin/openconnect\"") pretty-ovpn)
> > +                    (("/sbin/modprobe") modprobe)))
> 
> The indentation looks wrong.

I actually just copied it from one of the other ones, I'll go ahead and
fix it.

Thanks


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]