From: Efraim Flashner <efraim@flashner.co.il>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 36962-done@debbugs.gnu.org
Subject: bug#36962: [PATCH] gnu: Add network-manager-openconnect.
Date: Thu, 8 Aug 2019 10:09:02 +0300 [thread overview]
Message-ID: <20190808070902.GA5507@E2140> (raw)
In-Reply-To: <877e7oyg80.fsf@elephly.net>
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
On Wed, Aug 07, 2019 at 08:37:19PM +0200, Ricardo Wurmus wrote:
>
> Hi Efraim,
>
> > * gnu/packages/gnome.scm (network-manager-openconnect): New variable.
>
> This looks good to me.
>
> Why is this in gnome.scm and not in, say, networking?
The other network-manager VPN addons are also in gnome so I stuck it
with the others.
>
> > + (substitute* "src/nm-openconnect-service.c"
> > + (("\"/usr/local/sbin/openconnect\"") pretty-ovpn)
> > + (("\"/usr/sbin/openconnect\"") pretty-ovpn)
> > + (("/sbin/modprobe") modprobe)))
>
> The indentation looks wrong.
I actually just copied it from one of the other ones, I'll go ahead and
fix it.
Thanks
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-08-08 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 17:04 [bug#36962] [PATCH] gnu: Add network-manager-openconnect Efraim Flashner
2019-08-07 18:37 ` Ricardo Wurmus
2019-08-08 7:09 ` Efraim Flashner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808070902.GA5507@E2140 \
--to=efraim@flashner.co.il \
--cc=36962-done@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.