From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: bug#36783: Guix graphical installation failure on all drives with
 size > 1 TiB
Date: Wed, 24 Jul 2019 14:56:52 +0200
Message-ID: <20190724145558.1d854ed9@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:58288)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hqGqJ-0005YH-Qa
 for bug-guix@gnu.org; Wed, 24 Jul 2019 08:58:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hqGqI-0007rS-LU
 for bug-guix@gnu.org; Wed, 24 Jul 2019 08:58:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:55508)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hqGqI-0007rF-HW
 for bug-guix@gnu.org; Wed, 24 Jul 2019 08:58:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hqGqI-0004Xp-Cx
 for bug-guix@gnu.org; Wed, 24 Jul 2019 08:58:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.36783.B.156397302717391@debbugs.gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:57923)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <dannym@scratchpost.org>) id 1hqGpL-0004nD-FB
 for bug-guix@gnu.org; Wed, 24 Jul 2019 08:57:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <dannym@scratchpost.org>) id 1hqGpJ-0007Bi-Fh
 for bug-guix@gnu.org; Wed, 24 Jul 2019 08:57:03 -0400
Received: from dd26836.kasserver.com ([85.13.145.193]:40564)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <dannym@scratchpost.org>)
 id 1hqGpJ-0007Ar-96
 for bug-guix@gnu.org; Wed, 24 Jul 2019 08:57:01 -0400
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: 36783@debbugs.gnu.org, m.othacehe@gmail.com

Hi,

using the Guix graphical installation method, one cannot install Guix on a drive
with more than 1 TiB.  (symptom: "null pointer dereference" in mkpart)

The reason is a bug in guile-parted.

An example is to use the "separate /home" option with a 2 TiB disk.

The fix that lets me install is:

(for https://gitlab.com/mothacehe/guile-parted.git master)

diff --git a/parted/unit.scm b/parted/unit.scm
index 6818b7e..68862a8 100644
--- a/parted/unit.scm
+++ b/parted/unit.scm
@@ -147,7 +147,7 @@
                          out-range)))
       (if (return-int->bool result)
           (values (car
-                   (parse-c-struct c-sector (list int)))
+                   (parse-c-struct c-sector (list sector-type)))
                   (pointer->geometry
                    (dereference-pointer out-range)))
           (values #f #f)))))

However, even after that, disk-print, if used, prints nonsensical (negative)
values for "free" (but installation succeeds).

That bug prevents graphical installation on any drive bigger than 1 TiB.
Let's make a bugfix Guix release shortly.