From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:36419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYXRP-0003HB-QL for guix-patches@gnu.org; Wed, 05 Jun 2019 11:03:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYXRO-00037c-Oz for guix-patches@gnu.org; Wed, 05 Jun 2019 11:03:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34308) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYXRO-000373-Ly for guix-patches@gnu.org; Wed, 05 Jun 2019 11:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hYXRO-00036x-H6 for guix-patches@gnu.org; Wed, 05 Jun 2019 11:03:02 -0400 Subject: [bug#36093] [PATCH 1/2] services: Add Singularity. Resent-Message-ID: Date: Wed, 5 Jun 2019 17:02:17 +0200 From: Danny Milosavljevic Message-ID: <20190605170217.4e4c7fed@scratchpost.org> In-Reply-To: <20190604210115.24477-1-ludo@gnu.org> References: <20190604205151.24258-1-ludo@gnu.org> <20190604210115.24477-1-ludo@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/vs=boL_X2E7Il8OfbPbQ6PO"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 36093@debbugs.gnu.org --Sig_/vs=boL_X2E7Il8OfbPbQ6PO Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Tue, 4 Jun 2019 23:01:14 +0200 Ludovic Court=C3=A8s wrote: > +@defvr {Scheme Variable} singularity-service-type > +This is the type of the service that runs > +@url{https://www.sylabs.io/singularity/, Singularity},=20 Does it? Doesn't it just "allow you to invoke"? > + (substitute* (find-files "libexec/cli" "\\.exec$") > + (("\\$SINGULARITY_libexecdir/singularity/bin/([a-z]+= )-suid" > + _ program) > + (string-append "/run/setuid-programs/singularity-" > + program "-helper"))) Is absolute path OK? There have been some efforts to get guix to relocate = in the past. Does this apply here? > + ;; Create the directories that Singularity 2.6 expects to find. > + (for-each (lambda (directory) > + (mkdir-p (string-append "/var/singularity/mnt/" > + directory))) > + '("container" "final" "overlay" "session"))))) Are permissions OK? LGTM! --Sig_/vs=boL_X2E7Il8OfbPbQ6PO Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlz32XoACgkQ5xo1VCww uqU02Qf/blTfTCpN5qNeAXmPudiVAtFjlLRStYw8GwPs7PhDuJM9i4o8C4jSRbPg qKQ9jGMQtb1Od6zhFwJ/48AykSpQ8F+hul+iz1nC4TUYyCj3n3IfmR/7f9XefzSL JiwPo7HKmoWJy4+WYMWqMpOoOa5wPjPPLgmOiQ/nTEzzgKYUj53ImScb/mg64Ntw xF46mLK+yeXOEQIRHkpxTvB44kc0RcA5eWt9EMAD07c5m3zML121daR2X5pORr0I W589gtSsN1k+2ZgNsY2pEPJPbTw4GovyvocNrC4UT1yaDsxk2dr9JchqwqNYGrmY dIQiODxBmugPnsGs48Ou9ImQuaumGA== =IoQc -----END PGP SIGNATURE----- --Sig_/vs=boL_X2E7Il8OfbPbQ6PO--