From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXqVC-00087o-E6 for guix-patches@gnu.org; Mon, 03 Jun 2019 13:12:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXqVB-0005uC-Ew for guix-patches@gnu.org; Mon, 03 Jun 2019 13:12:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57660) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hXqVB-0005to-B0 for guix-patches@gnu.org; Mon, 03 Jun 2019 13:12:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hXqVB-0006Im-4u for guix-patches@gnu.org; Mon, 03 Jun 2019 13:12:05 -0400 Subject: [bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host. Resent-Message-ID: Date: Mon, 3 Jun 2019 19:11:36 +0200 From: Danny Milosavljevic Message-ID: <20190603191031.7e751c2a@scratchpost.org> In-Reply-To: <8736l2iuao.fsf@cbaines.net> References: <20190525070113.5576-1-arunisaac@systemreboot.net> <20190525072030.7739-1-arunisaac@systemreboot.net> <8736l2iuao.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/hW_WWszX9bvfFT2nSuWJenc"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 35895@debbugs.gnu.org --Sig_/hW_WWszX9bvfFT2nSuWJenc Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 25 May 2019 13:37:51 +0100 Christopher Baines wrote: > Arun Isaac writes: >=20 > > * gnu/system/linux-container.scm (dummy-networking-shepherd-service): N= ew > > procedure. > > (dummy-networking-service-type): New variable. > > (containerized-operating-system): If network is shared with host, repla= ce > > static-networking-service-type with dummy-networking-service-type. =20 >=20 > Sounds good. It would be good to have the motivation/reasoning behind > this change in the commit message though. IMO in a comment, not in a commit message :) Let's not make commit messages the documentation--except when it's impossib= le to document otherwise. In this case it's pretty clear what the form in containerized-operating-sys= tem does, but yeah, maybe a comment like the following: ;; Many Guix services (which?) depend on a 'networking' shepherd service, so ;; make sure to provide a dummy 'networking' service when we are sure that ;; networking is already set up in the host and can be used. ;; That prevents double-setup. --Sig_/hW_WWszX9bvfFT2nSuWJenc Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlz1VMkACgkQ5xo1VCww uqWBUQgAlAwQfYNflvynDqLhIMvmUj+X126PFfNNYSLakWjqt8bAhRk3PhjSrGPK 7AB4qOb0IMrHTpBlNpJqkgAzkvJBHNV1ys/Sn9GUMoUiV/IUu982UytTOH5DJFMS JGmtJ/5GAIE/eSwQoQL3utWVC0KxKc3TC1k2upyLYxnXDOayvmcWegmbIm7ewM4O RaCIpqNyhIIFiQ3+aMdRFucRd2+Tb4FzN+zZF+08MVpE9jCZ3/kHQNBAga9B9qTv hYSu/1w1xTd8JNOAEsQGDmLCcLE86bEigb48EiSsMY4zTKWdfm8I9r4227iL42cM DlRvDMARbf5PPGTXXZM9/2tti7PdOQ== =xGV/ -----END PGP SIGNATURE----- --Sig_/hW_WWszX9bvfFT2nSuWJenc--