From: Danny Milosavljevic <dannym@scratchpost.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 35895@debbugs.gnu.org
Subject: [bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host.
Date: Mon, 3 Jun 2019 19:11:36 +0200 [thread overview]
Message-ID: <20190603191031.7e751c2a@scratchpost.org> (raw)
In-Reply-To: <8736l2iuao.fsf@cbaines.net>
[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]
On Sat, 25 May 2019 13:37:51 +0100
Christopher Baines <mail@cbaines.net> wrote:
> Arun Isaac <arunisaac@systemreboot.net> writes:
>
> > * gnu/system/linux-container.scm (dummy-networking-shepherd-service): New
> > procedure.
> > (dummy-networking-service-type): New variable.
> > (containerized-operating-system): If network is shared with host, replace
> > static-networking-service-type with dummy-networking-service-type.
>
> Sounds good. It would be good to have the motivation/reasoning behind
> this change in the commit message though.
IMO in a comment, not in a commit message :)
Let's not make commit messages the documentation--except when it's impossible
to document otherwise.
In this case it's pretty clear what the form in containerized-operating-system
does, but yeah, maybe a comment like the following:
;; Many Guix services (which?) depend on a 'networking' shepherd service, so
;; make sure to provide a dummy 'networking' service when we are sure that
;; networking is already set up in the host and can be used.
;; That prevents double-setup.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-03 17:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 7:01 [bug#35895] [PATCH 0/1] linux-container: Remove networking service when network is shared with host Arun Isaac
2019-05-25 7:20 ` [bug#35895] [PATCH] " Arun Isaac
2019-05-25 12:37 ` Christopher Baines
2019-06-03 17:11 ` Danny Milosavljevic [this message]
2019-06-09 20:35 ` Arun Isaac
2019-06-13 21:02 ` Ludovic Courtès
2019-06-18 11:37 ` Arun Isaac
2019-06-18 14:19 ` Ludovic Courtès
2019-06-18 18:57 ` bug#35895: " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603191031.7e751c2a@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=35895@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.