From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXqDj-0000Rd-HB for guix-patches@gnu.org; Mon, 03 Jun 2019 12:54:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXqDi-0007vA-Iu for guix-patches@gnu.org; Mon, 03 Jun 2019 12:54:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57601) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hXqDi-0007ux-Fg for guix-patches@gnu.org; Mon, 03 Jun 2019 12:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hXqDi-0005lm-D5 for guix-patches@gnu.org; Mon, 03 Jun 2019 12:54:02 -0400 Subject: [bug#36023] [PATCH] linux-boot: Fix e2fsck warning. Resent-Message-ID: Date: Mon, 3 Jun 2019 18:53:41 +0200 From: Danny Milosavljevic Message-ID: <20190603185201.0ed67e8c@scratchpost.org> In-Reply-To: <0f5cda0e-cc9d-ee9a-bb15-86faaab0707c@web.de> References: <20190531112735.15985-1-dannym@scratchpost.org> <0f5cda0e-cc9d-ee9a-bb15-86faaab0707c@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/3Yh7JNp9k6sM3jD76VzIC4l"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jonathan Brielmaier Cc: 36023@debbugs.gnu.org --Sig_/3Yh7JNp9k6sM3jD76VzIC4l Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Jonathan, On Mon, 3 Jun 2019 18:17:14 +0200 Jonathan Brielmaier wrote: > On 5/31/19 1:27 PM, Danny Milosavljevic wrote: > > + (setenv "EXT2FS_NO_MTAB_OK" "1") > > + =20 > [...] > > + (setenv "EXT2FS_NO_MTAB_OK" #f) > > + =20 >=20 > Maybe it would be nice to have them constintly using either "0" and "1" > or #t and #f :) Well, the UNIX environment interface and/or Guile's interface to it doesn't work that way. The UNIX environment is a string array. e2fsck uses if(getenv("EXT2FS_NO_MTAB_OK")) to read the value of the entry with the key "EXT2FS_NO_MTAB_OK". So we can set the environment entry to any value we want and e2fsck's "if" condition will evaluate to true. And in order to remove it from the environment again, we call setenv with #f. We could also call unsetenv instead, I guess. Should we? --Sig_/3Yh7JNp9k6sM3jD76VzIC4l Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlz1UJUACgkQ5xo1VCww uqVXawf9GUr0L0M0cw4o6OJBLQ0T2FywsF8lAoFBBeEMjYlUliYfFA+hzi0RUVyd AMoTBAClxFMvVkFZgCk9SxOSqSPiRJX7i1hpmx56fbJqSAjthPM0gjFQrth9WzDN Y3h/2Hb/Sy53+l+Ae0aLJzKTJG5th3shOLv0qsHqGXUxxQDXi1/5CbltrkhO7VOm 1JxuTls0TSFDHShlsCWmGaJOCYrR+ddfbgm7MinQikeoMMrGW3AF79eRoMU28JC7 QJri+VvkvBVqCNAXWyVM4CbadbCFZoSn96CY01GkR8cSn0SRhraL2WmSwtcIncB1 lNMR/SvHccoRWj1vrTj6kM5UfeLzoQ== =BAkb -----END PGP SIGNATURE----- --Sig_/3Yh7JNp9k6sM3jD76VzIC4l--