From mboxrd@z Thu Jan  1 00:00:00 1970
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Subject: bug#35996: User account password got locked when booting old
	generation
Date: Mon, 3 Jun 2019 09:18:30 +0200
Message-ID: <20190603071830.q4bf76ioaszjdoo6@pelzflorian.localdomain>
References: <20190529204517.mqn5xrw23xib4i3u@pelzflorian.localdomain>
	<877ea6l1on.fsf@gnu.org>
	<20190601055238.jkhefpupavz7aipi@pelzflorian.localdomain>
	<20190601145834.f4wgm4oqmdyej7n5@pelzflorian.localdomain>
	<87r28dc7gw.fsf@gnu.org>
	<20190602070545.xp2pqlnzsthpjtbw@pelzflorian.localdomain>
	<87sgss9vj7.fsf@gnu.org>
	<20190602102122.bzapwt36vg32nmwq@pelzflorian.localdomain>
	<87o93g9dv5.fsf@gnu.org>
	<20190603060301.2nu2zqi5j3v3j5ki@pelzflorian.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:55313)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hXhFH-0004h7-J1
	for bug-guix@gnu.org; Mon, 03 Jun 2019 03:19:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hXhFG-0003dK-LO
	for bug-guix@gnu.org; Mon, 03 Jun 2019 03:19:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:56179)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hXhFG-0003cW-HH
	for bug-guix@gnu.org; Mon, 03 Jun 2019 03:19:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hXhFG-0007yS-9i
	for bug-guix@gnu.org; Mon, 03 Jun 2019 03:19:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.35996.B35996.155954631430607@debbugs.gnu.org>
Content-Disposition: inline
In-Reply-To: <20190603060301.2nu2zqi5j3v3j5ki@pelzflorian.localdomain>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 35996@debbugs.gnu.org

Please add more logging and/or locking.  Note that the elogind has the
following comment in its locking implementation in
/gnu/store/dm2ri0qvjirl0iq2ndfk5z9lq9dyk4jf-elogind-241.3-checkout/src/basic/user-util.c:

        /* This is roughly the same as lckpwdf(), but not as awful. We
         * don't want to use alarm() and signals, hence we implement
         * our own trivial version of this.
         *
         * Note that shadow-utils also takes per-database locks in
         * addition to lckpwdf(). However, we don't given that they
         * are redundant as they invoke lckpwdf() first and keep
         * it during everything they do. The per-database locks are
         * awfully racy, and thus we just won't do them. */

Regards,
Florian