[bug#35878] [PATCH] gnu: Add chafa.

[bug#35878] [PATCH] gnu: Add chafa.

[guy fleury iteriteka]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1787 bytes --]

* gnu/packages/image-viewers.scm(chaffa): New variable.
---
 gnu/packages/image-viewers.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 82b44a4..fc94242 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2017 nee <nee-git@hidamari.blue>
 ;;; Copyright © 2018, 2019 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2018, 2019 Ricardo Wurmus <rekado@elephly.net>
+;;; Copyright © 2019 Guy Fleury Iteriteka <hoonandon@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -429,3 +430,28 @@ imaging.  It supports several HDR and LDR image formats, and it can:
 a comic and manga reader.  It supports a variety of container formats
 including CBZ, CB7, CBT, LHA.")
     (license license:gpl2+)))
+
+(define-public chafa
+  (package
+    (name "chafa")
+    (version "1.0.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://hpjansson.org/chafa/releases/chafa-"
+                                  version ".tar.xz"))
+              (sha256
+               (base32
+                "00cf2z52az0z6bzc3hfm4l8infipy5ck410wqmbaybd2csjr3m29"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("glib"        ,glib)
+       ("imagemagick" ,imagemagick)))
+    (synopsis "Terminal Graphics for the 21st Century")
+    (description
+     "Chafa is a command-line utility that converts all kinds of images, 
+including animated GIFs, into ANSI/Unicode character output that can be 
+displayed in a terminal.")
+    (home-page "https://hpjansson.org/chafa/")
+    (license license:lgpl3+)))
-- 
2.21.0

[bug#35878] [PATCH] gnu: Add chafa.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hi,

guy fleury iteriteka <hoonandon@gmail.com> skribis:

> * gnu/packages/image-viewers.scm(chaffa): New variable.

I’d suggest the changes below.

Additionally, this code detects SSE4.1 and related instruction set
extensions at configuration time.  As a result, I think the resulting
code may not run on all x86_64 machines.

Could you investigate this and see how we can get a generic binary?

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 942 bytes --]

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index fc94242ac6..d947f2d7eb 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -446,12 +446,12 @@ including CBZ, CB7, CBT, LHA.")
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (inputs
-     `(("glib"        ,glib)
+     `(("glib" ,glib)
        ("imagemagick" ,imagemagick)))
-    (synopsis "Terminal Graphics for the 21st Century")
+    (synopsis "Convert images to ANSI/Unicode characters")
     (description
-     "Chafa is a command-line utility that converts all kinds of images, 
-including animated GIFs, into ANSI/Unicode character output that can be 
+     "Chafa is a command-line utility that converts all kinds of images,
+including animated GIFs, into ANSI/Unicode character output that can be
 displayed in a terminal.")
     (home-page "https://hpjansson.org/chafa/")
     (license license:lgpl3+)))

[bug#35878] [PATCH] gnu: Add chafa.

[guy fleury iteriteka]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

Hi,

I will try!
Le 27 mai 2019 16:52, "Ludovic Courtès" <ludo@gnu.org> a écrit :

> Hi,
>
> guy fleury iteriteka <hoonandon@gmail.com> skribis:
>
> > * gnu/packages/image-viewers.scm(chaffa): New variable.
>
> I’d suggest the changes below.
>
> Additionally, this code detects SSE4.1 and related instruction set
> extensions at configuration time.  As a result, I think the resulting
> code may not run on all x86_64 machines.
>
> Could you investigate this and see how we can get a generic binary?
>
> Thanks,
> Ludo’.
>
>

[-- Attachment #2: Type: text/html, Size: 898 bytes --]

[bug#35878] [PATCH] gnu: Add chafa.

[guy fleury iteriteka]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

Hello Ludovic,

Sorry for taking so long time.
I discus with the developper upstream. Here is what he tells me:
---------------------------------
Even if it builds SSE support, it will only be used at runtime if the
platform supports it. It uses CPUID internally to detect the CPU
capabilities when run.
-------------------------------

He will also add a note to clarify things in the next release!

Thanks.
Le 29 mai 2019 09:44, "guy fleury iteriteka" <hoonandon@gmail.com> a écrit :

> Hi,
>
> I will try!
> Le 27 mai 2019 16:52, "Ludovic Courtès" <ludo@gnu.org> a écrit :
>
>> Hi,
>>
>> guy fleury iteriteka <hoonandon@gmail.com> skribis:
>>
>> > * gnu/packages/image-viewers.scm(chaffa): New variable.
>>
>> I’d suggest the changes below.
>>
>> Additionally, this code detects SSE4.1 and related instruction set
>> extensions at configuration time.  As a result, I think the resulting
>> code may not run on all x86_64 machines.
>>
>> Could you investigate this and see how we can get a generic binary?
>>
>> Thanks,
>> Ludo’.
>>
>>

[-- Attachment #2: Type: text/html, Size: 1744 bytes --]

bug#35878: [PATCH] gnu: Add chafa.

[Ludovic Courtès]

Hi guy,

guy fleury iteriteka <hoonandon@gmail.com> skribis:

> Sorry for taking so long time.
> I discus with the developper upstream. Here is what he tells me:
> ---------------------------------
> Even if it builds SSE support, it will only be used at runtime if the
> platform supports it. It uses CPUID internally to detect the CPU
> capabilities when run.
> -------------------------------

Oh indeed, I see that ‘chafa-features.h’ does the right thing.

Applied, thanks for checking!

Ludo’.