From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [BLOG] custom kernel config Date: Mon, 20 May 2019 20:38:22 +0300 Message-ID: <20190520173822.GA1832@macbook41> References: <20190401180434.GF21029@macbook41> <20190515180945.GA7636@macbook41> <87h89uo4kb.fsf@devup.no> <87d0kiaqc0.fsf@netris.org> <20190517075045.GC9163@macbook41> <87zhnhrx5z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Return-path: Received: from eggs.gnu.org ([209.51.188.92]:34850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSmF3-0004eS-JV for guix-devel@gnu.org; Mon, 20 May 2019 13:38:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSmF1-0004FT-R1 for guix-devel@gnu.org; Mon, 20 May 2019 13:38:29 -0400 Content-Disposition: inline In-Reply-To: <87zhnhrx5z.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 20, 2019 at 04:57:28PM +0200, Ludovic Court=C3=A8s wrote: > Hello Efraim, >=20 > Like I wrote before, I like the tone and how the post addresses the > topic. So I just have minor cosmetic suggestions, and then I guess you > can push to guix-artwork.git and we can put it on-line maybe tomorrow? >=20 > Efraim Flashner skribis: >=20 > > Guix is, at its core, a source based distribution with substitutes, and > ^~ > Perhaps link to > > here. >=20 Done > > as such building packages from their source code is an expected part of > > regular package installations and upgrades. Given this starting point, > > it makes sense that efforts are made to reduce the amount of time spent > > compiling packages, and recent changes and upgrades to the building and > > distribution of substitutes continues to be a topic of discussion within > > Guix. One of the packages which I prefer to not build myself is the > ^ > Start a new paragraph here? >=20 Ok > > The linux-libre kernel package definition is actually a procedure which > ^ > Please make sure to write `linux-libre` (with backquotes) for all the > identifiers, file names, and commands that appears in the post, notably > all the CONFIG_* identifiers. >=20 > Perhaps you can also link to > ? >=20 I also added one when I got to the snippet referencing line 379. > > (define-public linux-libre-macbook41 > > ;; XXX: Access the internal 'make-linux-libre' procedure, which is > > ;; private and unexported, and is liable to change in the future. > > ((@@ (gnu packages linux) make-linux-libre) (@@ (gnu packages linux) = %linux-libre-version) >=20 > Can this one be rewritten using the =E2=80=98inherit=E2=80=99 idiom that = was discussed? > If not, that=E2=80=99s probably OK since you explicitly write that this i= s not > the recommended approach. Unfortunately I don't think it's possible. We're modifying the output =66rom the `make-linux-libre` procedure, not the package and its inputs it's wrapped in. I don't think it's possible without calling the procedure, at which point we may as well call it directly. I also didn't parameterize the %linux-libre-5.1-patches reference, but buyer beware on that kernel definition :) >=20 > Thanks for your work! >=20 > Ludo=E2=80=99. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlzi5gYACgkQQarn3Mo9 g1Hc9xAAl6oXpHEnvtr/NTPh9+FVqXHnWuDVAGZQLH6beWYUxsYUr/AJ2t4Iw/G0 3F2vZ+I/iIKpC3EzpN4nxeAm+dcwKK9xTWUQIP/WCiIbiB9soV7k7cmes6T8Cb6+ UiFv003NEhL8eBofoI9X1UrAVoT1DeKCFMXFdGuxtCULDGE3Fesng9SeSP5VYRMq FwJZaRaOxtLJhmfAtV1KZPzkgtOFQ5KRnV4qaSefeHexmhh9C3niBIbonyBCi5W3 yVsq84zW0doDXqolpQIrMSQPPWtvjgLNu13e9je5YeOkPFdfL70NPbBOiKBFuKfG qrd/kGZeSZWwPJmzPIdXMzf0OovedjkaQCs/0ritcmueiH0MIDhkdVtCVM7Yanhh sYdLisZBVQu4ufMof5spPPmz/pZimwodIKxAcER0IskuMKg21gOh0sAMqgmG3xI0 dwFzIzT2pNJNvxzh0nFOfCslhE6otof8HuUEIr5XV1i+FYJ59t/cqcAyH57vJkRz l4oPQD25zEc6tCu9fY/DU7medEV5VVTx8cZgmkQEVGiEEgJag+vSaz0FaOuWR2MP wZGJ2iUs9d6mS6gySqkeiByt/Vmo2tLBwBpsCbJ7jaew0yXF3ocKs8RC71KnOmiC wfJd208x96nu2A/1VzqqHUpQizhOuL+W68j6avmPdd/O3JTb+jE= =uX7B -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--