From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:60515)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNPIi-00012Z-Dc
	for guix-patches@gnu.org; Sun, 05 May 2019 18:08:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNPIh-0004l5-M9
	for guix-patches@gnu.org; Sun, 05 May 2019 18:08:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41564)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hNPIh-0004ki-Ik
	for guix-patches@gnu.org; Sun, 05 May 2019 18:08:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNPIh-0007ez-Cx
	for guix-patches@gnu.org; Sun, 05 May 2019 18:08:03 -0400
Subject: [bug#35545] [PATCH 14/17] gnu: Add java-commons-pool2.
Resent-Message-ID: <handler.35545.B35545.155709405229376@debbugs.gnu.org>
Date: Mon, 6 May 2019 00:07:29 +0200
From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?=
	<bjoern.hoefling@bjoernhoefling.de>
Message-ID: <20190506000729.223f82a5@alma-ubu>
In-Reply-To: <20190503130134.24788-14-julien@lepiller.eu>
References: <20190503145820.606f37db@sybil.lepiller.eu>
	<20190503130134.24788-1-julien@lepiller.eu>
	<20190503130134.24788-14-julien@lepiller.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	boundary="Sig_/VjKUlQBnk50h=MZPvXpjFIA";
	protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 35545@debbugs.gnu.org

--Sig_/VjKUlQBnk50h=MZPvXpjFIA
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri,  3 May 2019 15:01:31 +0200
Julien Lepiller <julien@lepiller.eu> wrote:

> * gnu/packages/java.scm (java-commons-pool2): New variable.

> +(define-public java-commons-pool2
> +  (package
> +    (name "java-commons-pool2")

There is only version 2 in Guix and the Package Name on the homepage
is "Apache Commons Pool". Thus, I would suggest to remove the "2"
from package-name and variable-name.

The same comment can be said about java-commons-dbcp.

Otherwise, LGTM.

Bj=C3=B6rn

--Sig_/VjKUlQBnk50h=MZPvXpjFIA
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCXM9eoQAKCRC/KGy2WT5f
/fchAJ9f4113BulWgYdgWYq14CXscSLpegCguhwBfKepmwwOpcR/njo+i5Xf8mk=
=UKAa
-----END PGP SIGNATURE-----

--Sig_/VjKUlQBnk50h=MZPvXpjFIA--