From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:60512)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNPIi-00012Y-7U
	for guix-patches@gnu.org; Sun, 05 May 2019 18:08:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNPIh-0004jz-6K
	for guix-patches@gnu.org; Sun, 05 May 2019 18:08:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:41563)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1hNPIh-0004jk-20
	for guix-patches@gnu.org; Sun, 05 May 2019 18:08:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hNPIg-0007es-TF
	for guix-patches@gnu.org; Sun, 05 May 2019 18:08:02 -0400
Subject: [bug#35545] [PATCH 13/17] gnu: Add java-jboss-transaction-api-spec.
Resent-Message-ID: <handler.35545.B35545.155709404129348@debbugs.gnu.org>
Date: Mon, 6 May 2019 00:07:19 +0200
From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?=
	<bjoern.hoefling@bjoernhoefling.de>
Message-ID: <20190506000719.516f6421@alma-ubu>
In-Reply-To: <20190503130134.24788-13-julien@lepiller.eu>
References: <20190503145820.606f37db@sybil.lepiller.eu>
	<20190503130134.24788-1-julien@lepiller.eu>
	<20190503130134.24788-13-julien@lepiller.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	boundary="Sig_/DkgK0CBe_EpbOSaRlmUiSO1";
	protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 35545@debbugs.gnu.org

--Sig_/DkgK0CBe_EpbOSaRlmUiSO1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri,  3 May 2019 15:01:30 +0200
Julien Lepiller <julien@lepiller.eu> wrote:

> * gnu/packages/java.scm (java-jboss-transaction-api-spec): New
> variable. ---

> +(define-public java-jboss-transaction-api-spec
> +  (package
> +    (name "java-jboss-transaction-api-spec")
> +    (version "1.2")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                     (url
> "https://github.com/jboss/jboss-transaction-api_spec")
> +                     (commit
> "c20742e0a8f1e0447d72d42be981050f3857b3f1")))
> +              (file-name (git-file-name name version))

I think it would be better to reference this commit via the tag:

jboss-transaction-api_1.2_spec-1.1.1.Final

Concerning the version, the pom.xml has:

   <groupId>org.jboss.spec.javax.transaction</groupId>
   <artifactId>jboss-transaction-api_1.2_spec</artifactId>
   <version>1.1.1.Final</version>

Wouldn't it be better to use the full version (API-version+package-version)=
 as in the pom?=20


> +    (license (list license:gpl2 license:cddl1.0)))); either gpl2
> only or cddl.

gpl2+classpath

Bj=C3=B6rn


--Sig_/DkgK0CBe_EpbOSaRlmUiSO1
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCXM9elwAKCRC/KGy2WT5f
/XwHAKCII+iCDGdmQ91bAhn6SzRPgacjkwCdGlhaBPwb9nUnoU+Rm7vmECJjxM0=
=0TtX
-----END PGP SIGNATURE-----

--Sig_/DkgK0CBe_EpbOSaRlmUiSO1--