[bug#35545] [PATCH 07/17] gnu: Add java-openjfx-build.

["Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>]

[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]

On Fri,  3 May 2019 15:01:24 +0200
Julien Lepiller <julien@lepiller.eu> wrote:


> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> "http://hg.openjdk.java.net/openjfx/8u-dev/rt"
> +                                  "/archive/85d09981ae0d.tar.gz"))

[.. ]
> +    (home-page "https://openjfx.io")

This is nit-picking:

As you are using an old version of OpenJFX, would it make more sense to
have the old homepage here:

https://wiki.openjdk.java.net/display/OpenJFX/Main

> +    (license license:gpl2)));with classpath exception

There are some files with BSD-2 and BSD-3 licenses, for example:

./apps/experiments/PtyConsole/src/ptyconsole/App.java: BSD 3-clause "New" or "Revised" License
./modules/web/src/main/native/Tools/DumpRenderTree/AccessibilityController.cpp: BSD 2-clause "Simplified" License


There is a gradle.jar in the sources:

./gradle/wrapper/gradle-wrapper.jar

Would you use a snipped to remove it?

Otherwise, LGTM.

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]