From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEc1d-0003Qz-Lq for guix-patches@gnu.org; Thu, 11 Apr 2019 11:54:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEc1b-00018y-P9 for guix-patches@gnu.org; Thu, 11 Apr 2019 11:54:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41513) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hEc1a-00017V-Nh for guix-patches@gnu.org; Thu, 11 Apr 2019 11:54:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hEc1a-0006A2-Fm for guix-patches@gnu.org; Thu, 11 Apr 2019 11:54:02 -0400 Subject: bug#35110: [PATCH v2 1/2] Add (guix build-system linux-module). Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Thu, 11 Apr 2019 17:53:47 +0200 From: Danny Milosavljevic Message-ID: <20190411175347.3820b0d9@scratchpost.org> In-Reply-To: <87ftqo3jel.fsf@gnu.org> References: <20190402192729.5262-1-dannym@scratchpost.org> <20190405110550.24168-1-dannym@scratchpost.org> <20190405110550.24168-2-dannym@scratchpost.org> <87ftqo3jel.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/P541oWL3WWplzR/cjY0q5JP"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35110-done@debbugs.gnu.org --Sig_/P541oWL3WWplzR/cjY0q5JP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Thu, 11 Apr 2019 12:50:42 +0200 Ludovic Court=C3=A8s wrote: > > +(define* (configure #:key inputs #:allow-other-keys) > I think you should either remove this comment or add an explanation > and/or a TODO. Added TODO. > Could you also add a note in doc/guix.texi under =E2=80=9CBuild Systems= =E2=80=9D? Did so. Pushed! --Sig_/P541oWL3WWplzR/cjY0q5JP Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlyvYwsACgkQ5xo1VCww uqUv/gf+NkXYIKRvSg6YVRAw7IoEL9Ab+H28wQ2hkC1NkTED8R6oBNFpME497sMe ZRA5Vu2xZVMPf0U0wlt2EXaQ+nz1o6aAPRkruFqsOteTtrclRGt5LmIR2EjYDaQs xLOEPqcOJ9Pozzh6a2NqANYmnRD4cLB+Q5rE0RhOk2cK4G/dKooZVDfopwSSXz6L kkLMs6OV7hDGj6BfBzpqrIW6LQuF3dIr6HNg2GZiBY59mlG2npbQqf4tgpw1r662 FPmimjIswZ+AJOFCqBqB0l/qE+U1Bou36CNAMkTodIZxvOe9H8M6953Plwu9hD4m 0v1rtNDwPCYUKpfbmF+uWy3HZrfmJQ== =E1Jd -----END PGP SIGNATURE----- --Sig_/P541oWL3WWplzR/cjY0q5JP--