From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3TFF-0007x2-Ux for guix-patches@gnu.org; Mon, 11 Mar 2019 18:18:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3TFF-0000Zk-2o for guix-patches@gnu.org; Mon, 11 Mar 2019 18:18:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54269) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3TFC-0000Z5-H6 for guix-patches@gnu.org; Mon, 11 Mar 2019 18:18:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h3TFC-0006mC-9D for guix-patches@gnu.org; Mon, 11 Mar 2019 18:18:02 -0400 Subject: [bug#34729] [PATCH v2] gnu: libgit2: Avoid Python. Resent-Message-ID: Date: Mon, 11 Mar 2019 23:17:02 +0100 From: Danny Milosavljevic Message-ID: <20190311230424.4eea1499@scratchpost.org> In-Reply-To: <875zspt7ls.fsf@gnu.org> References: <20190304110442.5876-1-dannym@scratchpost.org> <20190304114120.6987-1-dannym@scratchpost.org> <875zspt7ls.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/7=bHu9yEleSlliECi78U1qQ"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 34729@debbugs.gnu.org --Sig_/7=bHu9yEleSlliECi78U1qQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Mon, 11 Mar 2019 22:38:07 +0100 Ludovic Court=C3=A8s wrote: > Danny Milosavljevic skribis: >=20 > > * gnu/packages/patches/libgit2-avoid-python.patch: New file. > > * gnu/local.mk (dist_patch_DATA): Add it. > > * gnu/packages/version-control.scm (libgit2)[source]: Use it. > > [inputs]: Remove python. > > [native-inputs]: Add guile-2.2. =20 >=20 > So the goal is to remove Python from libgit2=E2=80=99s *build-time* > dependencies, right? (Python is not a run-time dependency for libgit2 > according to =E2=80=98guix size libgit2=E2=80=99.) Can you explain a bit= more? :-) It's listed as regular input, though (for no reason). We use git for quite basic things in Guix (especially since we usually use git to fetch packages from github) and we had some problems with Python 2 (since fixed). So Andreas, Ricardo and me looked at what on Earth libgit2 needs Python for and found that it's just one smallish file used at build time. Hence the replacement :) > This is really cool, but at the same time I feel like we=E2=80=99d rather= have a > compelling reason to start maintaining a parallel implementation of > their test suite machinery. Sure, it makes sense to think about who's going to maintain it. In this case it's just a test case collector which basically does $ grep -r "void.*test_" . so I think the risk of it diverging is low. If it after all does diverge (and we notice it), we can always replace it by the Python version again. It's pretty much a 1:1 port of the original (it's so long because I made both the structure and the output the same), so it should be easy to track future changes. libgit2 bundled it from an upstream project, "clar". That also usually means that the bundled copy gets updated less often. =20 We could also try upstreaming it. btw: I also saw that Andy once had a Python frontend for Guile, but it appears unfinished. Obviously that would be even nicer. --Sig_/7=bHu9yEleSlliECi78U1qQ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlyG3l4ACgkQ5xo1VCww uqUGtAf/ZN9J1T7TSRxlPwsv/DOZMrFvudP33xjm2paYIdjZc78gHmwwRzQiAhvp bnYXdPkkOmiV3MewZ2sU5EgOQom5TZwz50M9g3o4bJJaJ57TsBNuXwkaeAdt9fIK HCvXQyxtiEQKmytlWonBDLLoLTLIDUaOeh7gEyAfA2Y9VtQ2Pn1ZRA3xMnp7+gKE QuqZHqT5jFiDu+C2E2CCwKkvirV+VEcK41n3oAiq2++Z4iiv2+0j1GfXbQ9ZKaCP nTMgDMi4eq2ywkgQ+NRTCy0vKZovCeCYBT6g5zS2F8o0ITq1qWkI9sG7HGksSI68 yNODQtng+A7DsyJXxtsw/urOrV+FPg== =EbiU -----END PGP SIGNATURE----- --Sig_/7=bHu9yEleSlliECi78U1qQ--