From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:41151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxoYz-0001jL-9t for guix-patches@gnu.org; Sun, 24 Feb 2019 02:51:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxoYy-00019v-71 for guix-patches@gnu.org; Sun, 24 Feb 2019 02:51:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36253) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gxoYw-000178-AL for guix-patches@gnu.org; Sun, 24 Feb 2019 02:51:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gxoYw-00064N-7w for guix-patches@gnu.org; Sun, 24 Feb 2019 02:51:02 -0500 Subject: [bug#34615] [PATCH] gnu: Add libtommath. Resent-Message-ID: Date: Sun, 24 Feb 2019 09:50:28 +0200 From: Efraim Flashner Message-ID: <20190224075028.GF18280@macbook41> References: <20190222122014.21600-1-efraim@flashner.co.il> <87sgwfvega.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dCSxeJc5W8HZXZrD" Content-Disposition: inline In-Reply-To: <87sgwfvega.fsf@nckx> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 34615@debbugs.gnu.org --dCSxeJc5W8HZXZrD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 22, 2019 at 07:57:25PM +0100, Tobias Geerinckx-Rice wrote: > Efraim, >=20 > Thanks! >=20 > Efraim Flashner wrote: > > * gnu/packages/algebra.scm (libtommath): New variable. >=20 > > + (add-after 'unpack 'prepare-build > > + (lambda _ > > + ;; Don't pull in coreutils. > > + (substitute* "makefile_include.mk" > > + (("arch") "uname -m")) >=20 > I'd add an empty line here or separate this into two fases just to be very > clear, since=E2=80=A6 >=20 Sounds good. I didn't want to toss in a couple of one-liner phases, so I'll make it clearer. > > + (delete-file "makefile") > > + (symlink "makefile.shared" "makefile") > > + #t)) >=20 > =E2=80=A6I got a bit lost between all these makefiles. Could you explain= exactly > what's going on? >=20 > Is this to avoid repeating =E2=80=98-f makefile.shared=E2=80=99 elsewhere? Yeah, basically. Pkgsrc has a keyword to use makefile.shared and Debian passes '-f makefile.shared' in all its phases, this seemed much eaiser. >=20 > > + (add-after 'check 'make-static >=20 > More accurate: 'install-static-library. Sounds good >=20 > While libtommath.a is =E2=80=98only=E2=80=99 332K, that's almost half of = the entire output > size. Is it worth moving to a separate :static output? >=20 As far as size goes I decided against it since it is so small, but by putting libtommath.a in a separate output it does prevent other packages =66rom picking up the wrong one. Sounds good. > > + (synopsis "portable number theoretic multiple-precision integer > > library") >=20 > s/p/P/ >=20 > multiprecision.scm is a better fit and already has sister package > tomsfastmath to keep this one company. I didn't see that one. I'll stick it next to that one. >=20 > > +integer library written entirely in C. The library is designed to > > provide a >=20 > s/The library is/It's/ IMO. >=20 > > +simple to work with API >=20 > =E2=80=98simple-to-work-with API=E2=80=99, unfortunately. >=20 > Kind regards, >=20 > T G-R Thanks --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --dCSxeJc5W8HZXZrD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlxyTMQACgkQQarn3Mo9 g1HMYg/9HfBl6xLhRXU+Xvi8Hvg4uJz7Smti7bfDNv+z32UuM/PGZ8NC1HShfVm9 xts0OCXvNXo1qo1xrXaKdwiKgwkKEgNYRVrhzshyZZSU0tf6I7DxSA6RPWbmsnK9 zieF0QGSXL3R09P8N2fcs/d6zpLuxaC/tST0wC3jwm36cpgzi7Nn4YYhk6XtqosN 1e1k/hDjKy23BqprLQykSS1HMnDUMuj9EuCR4BxEraBYcZZPFhhE3FU5QjRvHiDW u3EdS7bsKIzg6p8tppsxg4szroFQAtPSBiQdWTYO5RRWvrj4ZHFeIvKreQQz4rWm dMAJNlahioQk8G8ZjMDuNiCsG4a+fAVZgcGxCetZ/XJgcLCh50VqbicSNMQHqGVM qCDZnHVNagu/lUbSMZ9DPjMKzCem4PCvYGKrrI0AlNi/9c7sT1iJDjKr9YrwHnJi waBG7GxQkEVrCrXgzrJNto4KdIP5ExBiQJrdl0lnAOLlM238816Z7bA0UDa1oR20 vlD7hlaMWF88NtDtAsXQ3jTCKL/qRfKDgUt1OI9MVJiecdYtgcua/YijKZee43Vy /m3RM5SQTm19j16FIVU+eyB4KT535maHZMUw993/Cf57WWFZN855kaUUJQoNG1LN mzcZXibcRi983AC0vxSxKLYjXWUm8YOMO4s6KINZ0JHKMsssizc= =teVv -----END PGP SIGNATURE----- --dCSxeJc5W8HZXZrD--