* [bug#34371] [PATCH] gnu: emacs: Add modules support.
@ 2019-02-07 16:43 Pierre-Antoine Rouby
2019-02-15 21:16 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Pierre-Antoine Rouby @ 2019-02-07 16:43 UTC (permalink / raw)
To: 34371; +Cc: Pierre-Antoine Rouby
* gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
---
gnu/packages/emacs.scm | 1 +
1 file changed, 1 insertion(+)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 7e8dcadf9..40d280f3e 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -115,6 +115,7 @@
(build-system glib-or-gtk-build-system)
(arguments
`(#:tests? #f ; no check target
+ #:configure-flags (list "--with-modules")
#:phases
(modify-phases %standard-phases
(add-before 'configure 'fix-/bin/pwd
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#34371] [PATCH] gnu: emacs: Add modules support.
2019-02-07 16:43 [bug#34371] [PATCH] gnu: emacs: Add modules support Pierre-Antoine Rouby
@ 2019-02-15 21:16 ` Ludovic Courtès
2019-02-18 22:58 ` Ricardo Wurmus
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2019-02-15 21:16 UTC (permalink / raw)
To: Pierre-Antoine Rouby; +Cc: 34371
Hello Pierre-Antoine,
Pierre-Antoine Rouby <contact@parouby.fr> skribis:
> * gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
> ---
> gnu/packages/emacs.scm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 7e8dcadf9..40d280f3e 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -115,6 +115,7 @@
> (build-system glib-or-gtk-build-system)
> (arguments
> `(#:tests? #f ; no check target
> + #:configure-flags (list "--with-modules")
What effect does it have? (I guess I’m a noob!)
If the Emacsfolks among us are fine with it, then so be it!
Thank you,
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#34371] [PATCH] gnu: emacs: Add modules support.
2019-02-15 21:16 ` Ludovic Courtès
@ 2019-02-18 22:58 ` Ricardo Wurmus
2019-02-18 23:05 ` Brett Gilio
2019-03-04 13:40 ` bug#34371: " Ludovic Courtès
0 siblings, 2 replies; 5+ messages in thread
From: Ricardo Wurmus @ 2019-02-18 22:58 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: Pierre-Antoine Rouby, 34371
Ludovic Courtès <ludo@gnu.org> writes:
> Hello Pierre-Antoine,
>
> Pierre-Antoine Rouby <contact@parouby.fr> skribis:
>
>> * gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
>> ---
>> gnu/packages/emacs.scm | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 7e8dcadf9..40d280f3e 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -115,6 +115,7 @@
>> (build-system glib-or-gtk-build-system)
>> (arguments
>> `(#:tests? #f ; no check target
>> + #:configure-flags (list "--with-modules")
>
> What effect does it have? (I guess I’m a noob!)
>
> If the Emacsfolks among us are fine with it, then so be it!
This allows one to build and load native C modules. It’s a heavy-weight
extension mechanism (that one could use to extend Emacs with Guile
support, for example).
I don’t object to this change.
--
Ricardo
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#34371] [PATCH] gnu: emacs: Add modules support.
2019-02-18 22:58 ` Ricardo Wurmus
@ 2019-02-18 23:05 ` Brett Gilio
2019-03-04 13:40 ` bug#34371: " Ludovic Courtès
1 sibling, 0 replies; 5+ messages in thread
From: Brett Gilio @ 2019-02-18 23:05 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: Pierre-Antoine Rouby, 34371
Ricardo Wurmus writes:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hello Pierre-Antoine,
>>
>> Pierre-Antoine Rouby <contact@parouby.fr> skribis:
>>
>>> * gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
>>> ---
>>> gnu/packages/emacs.scm | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index 7e8dcadf9..40d280f3e 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -115,6 +115,7 @@
>>> (build-system glib-or-gtk-build-system)
>>> (arguments
>>> `(#:tests? #f ; no check target
>>> + #:configure-flags (list "--with-modules")
>>
>> What effect does it have? (I guess I’m a noob!)
>>
>> If the Emacsfolks among us are fine with it, then so be it!
>
> This allows one to build and load native C modules. It’s a heavy-weight
> extension mechanism (that one could use to extend Emacs with Guile
> support, for example).
>
> I don’t object to this change.
Agreed with Ricardo,
I think this change is great, it is something I have been doing in my
own recipe for Emacs. Move it upstream, for sure.
Brett Gilio
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#34371: [PATCH] gnu: emacs: Add modules support.
2019-02-18 22:58 ` Ricardo Wurmus
2019-02-18 23:05 ` Brett Gilio
@ 2019-03-04 13:40 ` Ludovic Courtès
1 sibling, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2019-03-04 13:40 UTC (permalink / raw)
To: Ricardo Wurmus; +Cc: 34371-done, Pierre-Antoine Rouby
Hi,
Ricardo Wurmus <rekado@elephly.net> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hello Pierre-Antoine,
>>
>> Pierre-Antoine Rouby <contact@parouby.fr> skribis:
>>
>>> * gnu/packages/emacs.scm (emacs): Add modules support in configure-flags.
>>> ---
>>> gnu/packages/emacs.scm | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index 7e8dcadf9..40d280f3e 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -115,6 +115,7 @@
>>> (build-system glib-or-gtk-build-system)
>>> (arguments
>>> `(#:tests? #f ; no check target
>>> + #:configure-flags (list "--with-modules")
>>
>> What effect does it have? (I guess I’m a noob!)
>>
>> If the Emacsfolks among us are fine with it, then so be it!
>
> This allows one to build and load native C modules. It’s a heavy-weight
> extension mechanism (that one could use to extend Emacs with Guile
> support, for example).
>
> I don’t object to this change.
Alright, applied.
Thanks Ricardo and Brett for chiming in!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-04 13:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-07 16:43 [bug#34371] [PATCH] gnu: emacs: Add modules support Pierre-Antoine Rouby
2019-02-15 21:16 ` Ludovic Courtès
2019-02-18 22:58 ` Ricardo Wurmus
2019-02-18 23:05 ` Brett Gilio
2019-03-04 13:40 ` bug#34371: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.