From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:48222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqQ6Q-0008T9-TG for guix-patches@gnu.org; Sun, 03 Feb 2019 17:19:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqQ6Q-0003cr-3P for guix-patches@gnu.org; Sun, 03 Feb 2019 17:19:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqQ6P-0003cn-W8 for guix-patches@gnu.org; Sun, 03 Feb 2019 17:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gqQ6P-0006SY-QR for guix-patches@gnu.org; Sun, 03 Feb 2019 17:19:01 -0500 Subject: [bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba. Resent-Message-ID: Date: Sun, 3 Feb 2019 23:18:22 +0100 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20190203231817.0a722915@alma-ubu> In-Reply-To: <20190127114956.26570-11-mail@cbaines.net> References: <87zhrmgy0x.fsf@cbaines.net> <20190127114956.26570-1-mail@cbaines.net> <20190127114956.26570-11-mail@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 34217@debbugs.gnu.org On Sun, 27 Jan 2019 11:49:56 +0000 Christopher Baines wrote: > These packages are mutually dependant, so I've put them in one commit. >=20 > * gnu/packages/ruby.scm (ruby-aruba, ruby-cucumber): New variables. You missed to add the "...-without-tests" variables here. [...] > +(define-public ruby-aruba > + (package > + (name "ruby-aruba") > + (version "0.14.7") There is another update since yesterday: 0.14.8 - February 02, 2019 (169 KB)=20 [..] > +;; A version of ruby-aruba without tests run so that circular > dependencies can +;; be avoided. > +(define ruby-aruba-without-tests > + (package > + (inherit ruby-aruba) > + (arguments '(#:tests? #f)) > + (propagated-inputs > + (map (lambda (input) > + (if (string=3D? (car input) "ruby-cucumber") > + `("ruby-cucumber" ,ruby-cucumber-without-tests) > + input)) > + (package-propagated-inputs ruby-aruba))) This is really nit-picking, I haven't tried it out myself and I haven't used it much myself, but I think this could be written more elegant with match-lambda [syntax errors might be included]: (map (match-lambda (("ruby-cucumber" . pkg) `("ruby-cucumber" ,ruby-cucumber-without-tests)) (input input) ...) Bj=C3=B6rn