From: Yoshinori Arai <kumagusu08@gmail.com>
To: Eric Bavier <ericbavier@centurylink.net>
Cc: 34262@debbugs.gnu.org
Subject: [bug#34262] [PATCH]Add: nkf
Date: Fri, 1 Feb 2019 13:03:05 +0900 [thread overview]
Message-ID: <20190201040305.luu56jkwndye2zrv@WaraToNora> (raw)
In-Reply-To: <20190131085519.23d47ee2@centurylink.net>
On Thu, Jan 31, 2019 at 08:55:19AM -0600, Eric Bavier wrote:
> Thanks for the patch! Just a few nitpicks below:
>
> On Thu, 31 Jan 2019 15:43:26 +0900
> Yoshinori Arai <kumagusu08@gmail.com> wrote:
>
> > 1 file changed, 38 insertions(+)
> > gnu/packages/textutils.scm | 38 ++++++++++++++++++++++++++++++++++++++
> >
> > modified gnu/packages/textutils.scm
> > @@ -794,3 +794,41 @@ Chinese and Simplified Chinese, supporting character-level conversion,
> > phrase-level conversion, variant conversion, and regional idioms among
> > Mainland China, Taiwan, and Hong-Kong.")
> > (license license:asl2.0)))
> > +
> > +(define-public nkf
> > + (let ((commit "08043eadf4abdddcf277842217e3c77a24740dc2")
>
> Could you add a comment about how this commit relates to the 2.1.5
> release? I see the github page doesn't seem to make actual releases,
> or even tag. Would it make any sense to download the tarballs
> available at https://ja.asdn.net/projects/nkf instead?
>
> > + (revision "1"))
> > + (package
> > + (name "nkf")
> > + (version "2.1.5")
> > + (source (origin
> > + (method git-fetch)
> > + (uri (git-reference
> > + (url "https://github.com/nurse/nkf.git")
> > + (commit commit)))
> > + (file-name (string-append name version))
>
> Rather than string-append use the 'git-file-name' procedure.
>
> > + (sha256
> > + (base32
> > + "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly"))))
> > + (build-system gnu-build-system)
> > + (arguments
> > + `(#:tests? #f ; test for perl module
> > + #:make-flags (list "CC=gcc" "CFLAGS=-O2 -Wall -pedantic"
> > + (string-append "prefix=" %output))
> > + #:phases
> > + (modify-phases %standard-phases
> > + (delete 'configure)
> > + (replace 'install
>
> The Makefile's 'install' target seems like it might do what we want.
> Is that not the case?
>
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (let* ((out (assoc-ref outputs "out"))
> > + (bin (string-append out "/bin"))
> > + (man1 (string-append out "/share/man/man1"))
> > + (man1j (string-append out "/share/man/ja/man1")))
> > + (install-file "nkf" bin)
> > + (install-file "nkf.1" man1)
> > + (install-file "nkf.1j" man1j)
> > + #t))))))
> > + (home-page "https://ja.osdn.net/projects/nkf/")
> > + (synopsis "Network Kanji Filter")
> > + (description "Nkf is a yet another kanji code converter among networks, hosts and terminals. It converts input kanji code to designated kanji code such as ISO-2022-JP, Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.")
> > + (license license:zlib))))
>
> 'is a yet' -> 'is yet'
>
> Use double-space after end-of-sentence period.
>
> Also, make sure to run 'guix lint knf'
>
> Could you send an updated patch?
>
> Thanks,
> `~Eric
Hello, I updated and made format patch.
From aab08237d2ece4a1f190522d1357b5b9e872ce57 Mon Sep 17 00:00:00 2001
From: Yoshinori Arai <kumagusu08@gmail.com>
Date: Fri, 1 Feb 2019 12:55:46 +0900
Subject: [PATCH] Add nkf
---
gnu/packages/textutils.scm | 42 ++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index d2f84420c..34aae6361 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -794,3 +794,45 @@ Chinese and Simplified Chinese, supporting character-level conversion,
phrase-level conversion, variant conversion, and regional idioms among
Mainland China, Taiwan, and Hong-Kong.")
(license license:asl2.0)))
+
+(define-public nkf
+ (let ((commit "08043eadf4abdddcf277842217e3c77a24740dc2")
+ (revision "1"))
+ (package
+ (name "nkf")
+ ;;look at https://ja.osdn.net/projects/nkf/scm/git/nkf/
+ (version "2.1.5")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/nurse/nkf.git")
+ (commit commit)))
+ (file-name (string-append name version))
+ (sha256
+ (base32
+ "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:tests? #f ; test for perl module
+ #:make-flags (list "CC=gcc" "CFLAGS=-O2 -Wall -pedantic"
+ (string-append "prefix=" %output))
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure)
+ ;; mkdir can't create directory
+ (replace 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin"))
+ (man1 (string-append out "/share/man/man1"))
+ (man1j (string-append out "/share/man/ja/man1")))
+ (install-file "nkf" bin)
+ (install-file "nkf.1" man1)
+ (install-file "nkf.1j" man1j)
+ #t))))))
+ (home-page "https://ja.osdn.net/projects/nkf/")
+ (synopsis "Network Kanji Filter")
+ (description "Nkf is yet another kanji code converter among networks,
+hosts and terminals. It converts input kanji code to designated kanji code
+such as ISO-2022-JP, Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.")
+ (license license:zlib))))
--
2.20.1
next prev parent reply other threads:[~2019-02-01 4:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 6:43 [bug#34262] [PATCH]Add: nkf Yoshinori Arai
2019-01-31 14:55 ` Eric Bavier
2019-02-01 4:03 ` Yoshinori Arai [this message]
2019-02-26 4:17 ` bug#34262: " Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201040305.luu56jkwndye2zrv@WaraToNora \
--to=kumagusu08@gmail.com \
--cc=34262@debbugs.gnu.org \
--cc=ericbavier@centurylink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.