From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:43661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpDl6-0004B3-3p for guix-patches@gnu.org; Thu, 31 Jan 2019 09:56:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpDl4-0007Lk-PE for guix-patches@gnu.org; Thu, 31 Jan 2019 09:56:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53848) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gpDl4-0007La-HU for guix-patches@gnu.org; Thu, 31 Jan 2019 09:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gpDl4-0007WE-Fz for guix-patches@gnu.org; Thu, 31 Jan 2019 09:56:02 -0500 Subject: [bug#34262] [PATCH]Add: nkf Resent-Message-ID: Date: Thu, 31 Jan 2019 08:55:19 -0600 From: Eric Bavier Message-ID: <20190131085519.23d47ee2@centurylink.net> In-Reply-To: <20190131064326.ndndwqf23yirdoup@WaraToNora> References: <20190131064326.ndndwqf23yirdoup@WaraToNora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/eWvpAQXWijAF2_YSIUGLHTL"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Yoshinori Arai Cc: 34262@debbugs.gnu.org --Sig_/eWvpAQXWijAF2_YSIUGLHTL Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Thanks for the patch! Just a few nitpicks below: On Thu, 31 Jan 2019 15:43:26 +0900 Yoshinori Arai wrote: > 1 file changed, 38 insertions(+) > gnu/packages/textutils.scm | 38 ++++++++++++++++++++++++++++++++++++++ >=20 > modified gnu/packages/textutils.scm > @@ -794,3 +794,41 @@ Chinese and Simplified Chinese, supporting character= -level conversion, > phrase-level conversion, variant conversion, and regional idioms among > Mainland China, Taiwan, and Hong-Kong.") > (license license:asl2.0))) > + > +(define-public nkf > + (let ((commit "08043eadf4abdddcf277842217e3c77a24740dc2") Could you add a comment about how this commit relates to the 2.1.5 release? I see the github page doesn't seem to make actual releases, or even tag. Would it make any sense to download the tarballs available at https://ja.asdn.net/projects/nkf instead? > + (revision "1")) > + (package > + (name "nkf") > + (version "2.1.5") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/nurse/nkf.git") > + (commit commit))) > + (file-name (string-append name version)) Rather than string-append use the 'git-file-name' procedure. > + (sha256 > + (base32 > + "0anw0knr1iy4p9w3d3b3pbwzh1c43p1i2q4c28kw9zviw8kx2rly"= )))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; test for perl module > + #:make-flags (list "CC=3Dgcc" "CFLAGS=3D-O2 -Wall -pedantic" > + (string-append "prefix=3D" %output)) > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (replace 'install The Makefile's 'install' target seems like it might do what we want. Is that not the case? > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (man1 (string-append out "/share/man/man1")) > + (man1j (string-append out "/share/man/ja/man1"))) > + (install-file "nkf" bin) > + (install-file "nkf.1" man1) > + (install-file "nkf.1j" man1j) > + #t)))))) > + (home-page "https://ja.osdn.net/projects/nkf/") > + (synopsis "Network Kanji Filter") > + (description "Nkf is a yet another kanji code converter among netw= orks, hosts and terminals. It converts input kanji code to designated kanji= code such as ISO-2022-JP, Shift_JIS, EUC-JP, UTF-8, UTF-16 or UTF-32.") > + (license license:zlib)))) 'is a yet' -> 'is yet' Use double-space after end-of-sentence period. Also, make sure to run 'guix lint knf' Could you send an updated patch? Thanks, `~Eric --Sig_/eWvpAQXWijAF2_YSIUGLHTL Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlxTDFcACgkQ/XPKxxnT JWb2UA//THmkVEJ2Z1b9UeBjVrGtpUqFMNM5c5sDR9+a4dBXGvX2Awxop+lNnuVy Z1Iv6QEF1n/uygXYszA1wAuLTqW+eO4eYSAUDjy1PrHr3IEaKvk7poK1+g8TjMgX KkGGWBNiDI9VLvgcxenzMIquHFeOQp4t48EnDbBBayKqVgFpAfiSILrAp7aJ5/da EhawzKsZij9OqKmA+QDAP8+oSGfKvcpxBOvW6mU8yT49lcjf6rLBWayVZ89pMKur SSRvp5KGTXR5X+Ptrdpio24VqgWd6kHAOFf5qzxmWSZrzahwmqwr7vgCwIMPbZve fB7HYRMD2byUAbevZ4LiqkxnCVlo9Y41AWJwhlZL719sju2G0ieMezW9CWfkjbkH tlZkbLCAv7D9MLLNN4lFrhRfw4zgbSgteLLPMXAmXYtbmW2x/ddjaWB5MGRyWkaZ dsiLW7iOw7ZIY/hqEVYmUexLyodhW9ahTxgniTETtFyK3aYT47syXjXuMjKQGXpM JKMg9dWIuzlvFkgX+xsXFmW6LtmcpYAKCTzGjPJcvOaQeIeOuEyAdlz3g+ti9m3w QfF5qR0RVoVEeY7VE8wtSbwHMDoZimpwylASiH/ltjAYgqsQsLLUjcMwuNrAbAmY MrgA9AWEjY7VdB8SBsf7E9HCDKVgyktU/IpA7WPEMzh3bKQNmMs= =EavR -----END PGP SIGNATURE----- --Sig_/eWvpAQXWijAF2_YSIUGLHTL--