From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:60689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goAuA-0003Hg-It for guix-patches@gnu.org; Mon, 28 Jan 2019 12:41:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goAu8-0004fG-NS for guix-patches@gnu.org; Mon, 28 Jan 2019 12:41:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50194) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1goAu7-0004eR-JH for guix-patches@gnu.org; Mon, 28 Jan 2019 12:41:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1goAu7-0001c6-Gb for guix-patches@gnu.org; Mon, 28 Jan 2019 12:41:03 -0500 Subject: [bug#30689] [PATCH 04/39] gnu: ruby-public-suffix: Enable tests. Resent-Message-ID: From: Christopher Baines Date: Mon, 28 Jan 2019 17:35:45 +0000 Message-Id: <20190128173620.27999-4-mail@cbaines.net> In-Reply-To: <20190128173620.27999-1-mail@cbaines.net> References: <87h8dshesk.fsf@cbaines.net> <20190128173620.27999-1-mail@cbaines.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 30689@debbugs.gnu.org * gnu/packages/ruby.scm (ruby-public-suffix)[arguments]: Enable the tests, add a phase to remove the Rubocop dependency. [native-inputs]: Add bundler, ruby-yard, ruby-mocha and ruby-minitest-reporters. --- gnu/packages/ruby.scm | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index ebd36df9b3..57f7108b66 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -6126,8 +6126,21 @@ programs running in the background, in Ruby.") "08q64b5br692dd3v0a9wq9q5dvycc6kmiqmjbdxkxbfizggsvx6l")))) (build-system ruby-build-system) (arguments - ;; Tests require network - `(#:tests? #f)) + '(#:phases + (modify-phases %standard-phases + ;; Remove the requirement on Rubocop, as it isn't useful to run, and + ;; including it as an input can lead to circular dependencies. + (add-after 'unpack 'remove-rubocop-from-Rakefile + (lambda _ + (substitute* "Rakefile" + (("require \"rubocop/rake\\_task\"") "") + (("RuboCop::RakeTask\\.new") "")) + #t))))) + (native-inputs + `(("bundler" ,bundler) + ("ruby-yard" ,ruby-yard) + ("ruby-mocha" ,ruby-mocha) + ("ruby-minitest-reporters" ,ruby-minitest-reporters))) (home-page "https://simonecarletti.com/code/publicsuffix-ruby/") (synopsis "Domain name parser") (description "The gem @code{public_suffix} is a domain name parser, -- 2.20.1