From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1go4lo-0004Ug-2C for guix-patches@gnu.org; Mon, 28 Jan 2019 06:08:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1go4ln-00050I-5i for guix-patches@gnu.org; Mon, 28 Jan 2019 06:08:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48975) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1go4lm-0004yu-IX for guix-patches@gnu.org; Mon, 28 Jan 2019 06:08:03 -0500 Subject: [bug#34165] [PATCH] gnu: bitcoin-core: Make bitcoin-qt deterministic. Resent-Message-ID: Date: Mon, 28 Jan 2019 12:07:20 +0100 From: Danny Milosavljevic Message-ID: <20190128120720.094dd8be@scratchpost.org> In-Reply-To: <8736pj77x4.fsf@elephly.net> References: <87munrivyd.fsf@gnu.org> <8736pj77x4.fsf@elephly.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/gXPp97u.GetvZm8jEiMOwzU"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 34165@debbugs.gnu.org, Carl Dong --Sig_/gXPp97u.GetvZm8jEiMOwzU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, > > https://github.com/qt/qtbase/commit/38271e9298dcf48652a6e2e08414a940a97= 867fa =20 >=20 > This is a bit unfortunate. It seems to me that the original intent of > the patch was to support SOURCE_DATE_EPOCH as the commit message > mentions that variable=E2=80=99s specification. Pity that it is now a cu= stom Qt > variable. I asked them and they said [1]: >There was a policy to prefix variables with QT_ and I did not want to disc= uss more with the reviewer. >But later, this was merged: >https://codereview.qt-project.org/#/c/243636/4/src/tools/rcc/rcc.cpp,unifi= ed [1] https://github.com/qt/qtbase/commit/38271e9298dcf48652a6e2e08414a940a97= 867fa#commitcomment-32085478 https://codereview.qt-project.org/#/c/243636/4/src/tools/rcc/rcc.cpp,unifie= d contains the following patch: ... 228 228 const QDateTime lastModified =3D m_fileInfo.lastModified(); 229 229 quint64 lastmod =3D quint64(lastModified.isValid() ? last= Modified.toMSecsSinceEpoch() : 0); 230 230 static const quint64 sourceDate =3D 1000 * qgetenv("QT_RC= C_SOURCE_DATE_OVERRIDE").toULongLong( ); 231 231 if (sourceDate !=3D 0) 232 232 lastmod =3D sourceDate; 233 + static const quint64 sourceDate2 =3D 1000 * qgetenv("SOURCE_= DATE_EPOCH").toULongLong(); 234 + if (sourceDate2 !=3D 0) 235 + lastmod =3D sourceDate2; --Sig_/gXPp97u.GetvZm8jEiMOwzU Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlxO4mgACgkQ5xo1VCww uqURMgf/UsWZLXzWEKd/GfOzOdt/g+5qpVFuZ4yDgWNxxgcsMoZi/BEko2neA14w 3xTsAxyabf1PhobKqsTReiVTZ3MYXuDSS5RWzPliU8yhmj6zqSTKaM7/L9XEs0J6 mZgQBUpFZL+53WJIL43movwKZFdsWjbshrzzxe/mXivRp6h+Vxlfj0WUI0ILiRxN TmfIJqB9oobdRtpE4N7CT0uYffxmuU2+qPy2Ok1oJtu3iTnmJUPLadeXQGUWJpdN HwPEjovc46r3fqg0U2MXjXpuz+LxKR3Zzb9k9t8GXAhwmJ+SYN4YfyWfTP8a3M7d XP8EyE0PDel6QI/i7fVYwsbQyk4reg== =Wqi1 -----END PGP SIGNATURE----- --Sig_/gXPp97u.GetvZm8jEiMOwzU--