all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#34198] [PATCH 0/2] Add diffpdf.
@ 2019-01-25 16:43 Danny Milosavljevic
  2019-01-25 16:48 ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Danny Milosavljevic
  2020-09-05 20:47 ` bug#34198: Closing Andreas Enge
  0 siblings, 2 replies; 9+ messages in thread
From: Danny Milosavljevic @ 2019-01-25 16:43 UTC (permalink / raw)
  To: 34198

Danny Milosavljevic (2):
  gnu: poppler-qt4: Enable qt4 frontend.
  gnu: Add diffpdf.

 gnu/packages/pdf.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend.
  2019-01-25 16:43 [bug#34198] [PATCH 0/2] Add diffpdf Danny Milosavljevic
@ 2019-01-25 16:48 ` Danny Milosavljevic
  2019-01-25 16:48   ` [bug#34198] [PATCH 2/2] gnu: Add diffpdf Danny Milosavljevic
                     ` (2 more replies)
  2020-09-05 20:47 ` bug#34198: Closing Andreas Enge
  1 sibling, 3 replies; 9+ messages in thread
From: Danny Milosavljevic @ 2019-01-25 16:48 UTC (permalink / raw)
  To: 34198

* gnu/packages/pdf.scm (poppler-qt4)[version]: Downgrade to 0.61.1.
[source]: Apply CVE patch.
---
 gnu/packages/pdf.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 96c0f9e3a..956e25c6d 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -174,6 +174,16 @@ When present, Poppler is able to correctly render CJK and Cyrillic text.")
 (define-public poppler-qt4
   (package/inherit poppler
    (name "poppler-qt4")
+   (version "0.61.1")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "https://poppler.freedesktop.org/poppler-"
+                                version ".tar.xz"))
+            (sha256
+             (base32
+              "1afdrxxkaivvviazxkg5blsf2x24sjkfj92ib0d3q5pm8dihjrhj"))
+            (patches
+             (append (search-patches "poppler-CVE-2018-19149.patch")))))
    (inputs `(("qt-4" ,qt-4)
              ,@(package-inputs poppler)))
    (synopsis "Qt4 frontend for the Poppler PDF rendering library")))

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [bug#34198] [PATCH 2/2] gnu: Add diffpdf.
  2019-01-25 16:48 ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Danny Milosavljevic
@ 2019-01-25 16:48   ` Danny Milosavljevic
  2019-01-29 17:08     ` Ricardo Wurmus
  2019-01-29 17:05   ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Ricardo Wurmus
  2019-01-31 21:59   ` Marius Bakke
  2 siblings, 1 reply; 9+ messages in thread
From: Danny Milosavljevic @ 2019-01-25 16:48 UTC (permalink / raw)
  To: 34198

* gnu/packages/pdf.scm (diffpdf): New variable.
---
 gnu/packages/pdf.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 956e25c6d..3b695f3a6 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -1130,3 +1130,46 @@ presentation.  The input files processed by pdfpc are PDF documents.")
 rendering of the file.  The rendering is done by creating outline curves
 through the Pango @code{ft2} backend.")
       (license license:lgpl2.0+))))
+
+(define-public diffpdf
+  (package
+    (name "diffpdf")
+    (version "2.1.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://www.qtrac.eu/diffpdf-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0cr468fi0d512jjj23r5flfzx957vibc9c25gwwhi0d773h2w566"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-paths
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* "diffpdf.pro"
+              (("-lpoppler-qt4")
+               (string-append "-L" (assoc-ref inputs "poppler-qt4")
+                              "/lib -lpoppler-qt4"))
+              (("/usr/local/include/poppler")
+               (string-append (assoc-ref inputs "poppler-qt4")
+                              "/include/poppler")))
+             #t))
+         (replace 'configure
+           (lambda _
+             (invoke "lrelease" "diffpdf.pro")
+             (invoke "qmake")))
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (out-bin (string-append out "/bin")))
+               (install-file "diffpdf" out-bin)
+               #t))))))
+    (inputs
+     `(("poppler-qt4" ,poppler-qt4) ; at least 0.20.1
+       ("qt-4" ,qt-4)))
+    (home-page "http://www.qtrac.eu/diffpdf-foss.html")
+    (synopsis "Compare two PDF files")
+    (description "This package provides a GUI tool to compare two PDF files.")
+    (license license:gpl2)))

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend.
  2019-01-25 16:48 ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Danny Milosavljevic
  2019-01-25 16:48   ` [bug#34198] [PATCH 2/2] gnu: Add diffpdf Danny Milosavljevic
@ 2019-01-29 17:05   ` Ricardo Wurmus
  2019-01-29 20:09     ` Danny Milosavljevic
  2019-01-31 21:59   ` Marius Bakke
  2 siblings, 1 reply; 9+ messages in thread
From: Ricardo Wurmus @ 2019-01-29 17:05 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 34198


Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/pdf.scm (poppler-qt4)[version]: Downgrade to 0.61.1.
> [source]: Apply CVE patch.
> ---
>  gnu/packages/pdf.scm | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
> index 96c0f9e3a..956e25c6d 100644
> --- a/gnu/packages/pdf.scm
> +++ b/gnu/packages/pdf.scm
> @@ -174,6 +174,16 @@ When present, Poppler is able to correctly render CJK and Cyrillic text.")
>  (define-public poppler-qt4
>    (package/inherit poppler
>     (name "poppler-qt4")
> +   (version "0.61.1")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append "https://poppler.freedesktop.org/poppler-"
> +                                version ".tar.xz"))
> +            (sha256
> +             (base32
> +              "1afdrxxkaivvviazxkg5blsf2x24sjkfj92ib0d3q5pm8dihjrhj"))
> +            (patches
> +             (append (search-patches "poppler-CVE-2018-19149.patch")))))
>     (inputs `(("qt-4" ,qt-4)
>               ,@(package-inputs poppler)))
>     (synopsis "Qt4 frontend for the Poppler PDF rendering library")))

Could the previous higher version of the package not be built?
Otherwise we’d have to deal with the downgrade somehow to make sure that
installed packages get downgraded to this version as well.

-- 
Ricardo

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#34198] [PATCH 2/2] gnu: Add diffpdf.
  2019-01-25 16:48   ` [bug#34198] [PATCH 2/2] gnu: Add diffpdf Danny Milosavljevic
@ 2019-01-29 17:08     ` Ricardo Wurmus
  2019-01-29 20:12       ` Danny Milosavljevic
  0 siblings, 1 reply; 9+ messages in thread
From: Ricardo Wurmus @ 2019-01-29 17:08 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 34198


Hi Danny,

> * gnu/packages/pdf.scm (diffpdf): New variable.
[…]
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-paths
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (substitute* "diffpdf.pro"
> +              (("-lpoppler-qt4")
> +               (string-append "-L" (assoc-ref inputs "poppler-qt4")
> +                              "/lib -lpoppler-qt4"))

Is this really necessary?  Shouldn’t it be enough to have this directory
on LIBRARY_PATH at build time?

> +    (inputs
> +     `(("poppler-qt4" ,poppler-qt4) ; at least 0.20.1
> +       ("qt-4" ,qt-4)))

I was hoping we could get rid of Qt 4 in the near future, because it
doesn’t get security fixes.  Is there no Qt 5 variant?

> +    (home-page "http://www.qtrac.eu/diffpdf-foss.html")
> +    (synopsis "Compare two PDF files")
> +    (description "This package provides a GUI tool to compare two PDF files.")
> +    (license license:gpl2)))

Looks like GPLv2 or later.

--
Ricardo

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend.
  2019-01-29 17:05   ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Ricardo Wurmus
@ 2019-01-29 20:09     ` Danny Milosavljevic
  0 siblings, 0 replies; 9+ messages in thread
From: Danny Milosavljevic @ 2019-01-29 20:09 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: 34198

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Hi Ricardo,

On Tue, 29 Jan 2019 18:05:22 +0100
Ricardo Wurmus <rekado@elephly.net> wrote:

> Could the previous higher version of the package not be built?
> Otherwise we’d have to deal with the downgrade somehow to make sure that
> installed packages get downgraded to this version as well.

It could technically be built, but it was missing the qt4 frontend because
newer poppler versions had removed it from its source entirely.

Nobody else uses poppler-qt4 in Guix - otherwise the client would have noticed
that it did not work at all.

I just needed a PDF differ which requires poppler-qt4, so I fixed poppler-qt4.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#34198] [PATCH 2/2] gnu: Add diffpdf.
  2019-01-29 17:08     ` Ricardo Wurmus
@ 2019-01-29 20:12       ` Danny Milosavljevic
  0 siblings, 0 replies; 9+ messages in thread
From: Danny Milosavljevic @ 2019-01-29 20:12 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: 34198

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

Hi Ricardo,

On Tue, 29 Jan 2019 18:08:45 +0100
Ricardo Wurmus <rekado@elephly.net> wrote:

> I was hoping we could get rid of Qt 4 in the near future, because it
> doesn’t get security fixes.  Is there no Qt 5 variant?

No.  The company seems to write proprietary Windows solutions now.

Kudos to them for keeping the FOSS version on their homepage anyway.

> Looks like GPLv2 or later.

Thanks for the review!

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend.
  2019-01-25 16:48 ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Danny Milosavljevic
  2019-01-25 16:48   ` [bug#34198] [PATCH 2/2] gnu: Add diffpdf Danny Milosavljevic
  2019-01-29 17:05   ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Ricardo Wurmus
@ 2019-01-31 21:59   ` Marius Bakke
  2 siblings, 0 replies; 9+ messages in thread
From: Marius Bakke @ 2019-01-31 21:59 UTC (permalink / raw)
  To: Danny Milosavljevic, 34198

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

> * gnu/packages/pdf.scm (poppler-qt4)[version]: Downgrade to 0.61.1.
> [source]: Apply CVE patch.
> ---
>  gnu/packages/pdf.scm | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
> index 96c0f9e3a..956e25c6d 100644
> --- a/gnu/packages/pdf.scm
> +++ b/gnu/packages/pdf.scm
> @@ -174,6 +174,16 @@ When present, Poppler is able to correctly render CJK and Cyrillic text.")
>  (define-public poppler-qt4
>    (package/inherit poppler
>     (name "poppler-qt4")
> +   (version "0.61.1")
> +   (source (origin

Since this adds a completely different source I think package/inherit is
inappropriate, because we no longer want Poppler grafts applying here.

That said, I would rather we abandoned this package, since Qt4 is
unmaintained for a really long time now.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#34198: Closing
  2019-01-25 16:43 [bug#34198] [PATCH 0/2] Add diffpdf Danny Milosavljevic
  2019-01-25 16:48 ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Danny Milosavljevic
@ 2020-09-05 20:47 ` Andreas Enge
  1 sibling, 0 replies; 9+ messages in thread
From: Andreas Enge @ 2020-09-05 20:47 UTC (permalink / raw)
  To: 34198-done

There seems to be consensus to not add this package, since Qt4 is being
phased out. Closing.

Andreas





^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-09-05 20:48 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-25 16:43 [bug#34198] [PATCH 0/2] Add diffpdf Danny Milosavljevic
2019-01-25 16:48 ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Danny Milosavljevic
2019-01-25 16:48   ` [bug#34198] [PATCH 2/2] gnu: Add diffpdf Danny Milosavljevic
2019-01-29 17:08     ` Ricardo Wurmus
2019-01-29 20:12       ` Danny Milosavljevic
2019-01-29 17:05   ` [bug#34198] [PATCH 1/2] gnu: poppler-qt4: Enable qt4 frontend Ricardo Wurmus
2019-01-29 20:09     ` Danny Milosavljevic
2019-01-31 21:59   ` Marius Bakke
2020-09-05 20:47 ` bug#34198: Closing Andreas Enge

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.