all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#34190] [PATCH] gnu: clojure: Update to 1.10.0.
@ 2019-01-24 12:48 Mathieu Lirzin
  2019-01-24 20:10 ` Ricardo Wurmus
  0 siblings, 1 reply; 4+ messages in thread
From: Mathieu Lirzin @ 2019-01-24 12:48 UTC (permalink / raw)
  To: 34190; +Cc: Mathieu Lirzin

* gnu/packages/clojure.scm (clojure): Update to 1.10.0.
[source]: Use 'git-fetch'.
---
 gnu/packages/clojure.scm | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
index 1dba4cef87..8112b65278 100644
--- a/gnu/packages/clojure.scm
+++ b/gnu/packages/clojure.scm
@@ -65,15 +65,16 @@
 
     (package
       (name "clojure")
-      (version "1.9.0")
-      (source
-       (origin
-         (method url-fetch)
-         (uri
-          (string-append "https://github.com/clojure/clojure/archive/clojure-"
-                         version ".tar.gz"))
-         (sha256
-          (base32 "0xjbzcw45z32vsn9pifp7ndysjzqswp5ig0jkjpivigh2ckkdzha"))))
+      (version "1.10.0")
+      (source (let ((name+version (string-append name "-" version)))
+                (origin
+                  (method git-fetch)
+                  (uri (git-reference
+                        (url "https://github.com/clojure/clojure")
+                        (commit name+version)))
+                  (file-name (string-append name+version "-checkout"))
+                  (sha256
+                   (base32 "1kcyv2836acs27vi75hvf3r773ahv2nlh9b3j9xa9m9sdanz1h83")))))
       (build-system ant-build-system)
       (arguments
        `(#:imported-modules ((guix build clojure-utils)
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#34190] [PATCH] gnu: clojure: Update to 1.10.0.
  2019-01-24 12:48 [bug#34190] [PATCH] gnu: clojure: Update to 1.10.0 Mathieu Lirzin
@ 2019-01-24 20:10 ` Ricardo Wurmus
  2019-01-24 20:35   ` Mathieu Lirzin
  2019-01-29  9:59   ` bug#34190: " Ricardo Wurmus
  0 siblings, 2 replies; 4+ messages in thread
From: Ricardo Wurmus @ 2019-01-24 20:10 UTC (permalink / raw)
  To: Mathieu Lirzin; +Cc: 34190


Hi Mathieu,

> * gnu/packages/clojure.scm (clojure): Update to 1.10.0.
> [source]: Use 'git-fetch'.
> ---
>  gnu/packages/clojure.scm | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
> index 1dba4cef87..8112b65278 100644
> --- a/gnu/packages/clojure.scm
> +++ b/gnu/packages/clojure.scm
> @@ -65,15 +65,16 @@
>  
>      (package
>        (name "clojure")
> -      (version "1.9.0")
> -      (source
> -       (origin
> -         (method url-fetch)
> -         (uri
> -          (string-append "https://github.com/clojure/clojure/archive/clojure-"
> -                         version ".tar.gz"))
> -         (sha256
> -          (base32 "0xjbzcw45z32vsn9pifp7ndysjzqswp5ig0jkjpivigh2ckkdzha"))))
> +      (version "1.10.0")
> +      (source (let ((name+version (string-append name "-" version)))
> +                (origin
> +                  (method git-fetch)
> +                  (uri (git-reference
> +                        (url "https://github.com/clojure/clojure")
> +                        (commit name+version)))
> +                  (file-name (string-append name+version "-checkout"))
> +                  (sha256
> +                   (base32 "1kcyv2836acs27vi75hvf3r773ahv2nlh9b3j9xa9m9sdanz1h83")))))
>        (build-system ant-build-system)
>        (arguments
>         `(#:imported-modules ((guix build clojure-utils)

This looks good to me.  Thanks!

-- 
Ricardo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#34190] [PATCH] gnu: clojure: Update to 1.10.0.
  2019-01-24 20:10 ` Ricardo Wurmus
@ 2019-01-24 20:35   ` Mathieu Lirzin
  2019-01-29  9:59   ` bug#34190: " Ricardo Wurmus
  1 sibling, 0 replies; 4+ messages in thread
From: Mathieu Lirzin @ 2019-01-24 20:35 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: 34190

Hello Ricardo,

Ricardo Wurmus <rekado@elephly.net> writes:

>> * gnu/packages/clojure.scm (clojure): Update to 1.10.0.
>> [source]: Use 'git-fetch'.
>> ---
>>  gnu/packages/clojure.scm | 19 ++++++++++---------
>>  1 file changed, 10 insertions(+), 9 deletions(-)
>>
>> diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
>> index 1dba4cef87..8112b65278 100644
>> --- a/gnu/packages/clojure.scm
>> +++ b/gnu/packages/clojure.scm
>> @@ -65,15 +65,16 @@
[...]
>
> This looks good to me.  Thanks!

Thanks for your impressively reliable stewardship!

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#34190: [PATCH] gnu: clojure: Update to 1.10.0.
  2019-01-24 20:10 ` Ricardo Wurmus
  2019-01-24 20:35   ` Mathieu Lirzin
@ 2019-01-29  9:59   ` Ricardo Wurmus
  1 sibling, 0 replies; 4+ messages in thread
From: Ricardo Wurmus @ 2019-01-29  9:59 UTC (permalink / raw)
  To: Mathieu Lirzin; +Cc: 34190-done


Ricardo Wurmus <rekado@elephly.net> writes:

> Hi Mathieu,
>
>> * gnu/packages/clojure.scm (clojure): Update to 1.10.0.
>> [source]: Use 'git-fetch'.
[…]
> This looks good to me.  Thanks!

Pushed to “master” with commit 9e532ae22.

--
Ricardo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-29 10:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-24 12:48 [bug#34190] [PATCH] gnu: clojure: Update to 1.10.0 Mathieu Lirzin
2019-01-24 20:10 ` Ricardo Wurmus
2019-01-24 20:35   ` Mathieu Lirzin
2019-01-29  9:59   ` bug#34190: " Ricardo Wurmus

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.