From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:36722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glkgZ-0000CH-He for guix-patches@gnu.org; Mon, 21 Jan 2019 20:17:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glkgY-0006W9-LI for guix-patches@gnu.org; Mon, 21 Jan 2019 20:17:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:41398) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1glkgY-0006Ve-C3 for guix-patches@gnu.org; Mon, 21 Jan 2019 20:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1glkgX-0001EI-Vv for guix-patches@gnu.org; Mon, 21 Jan 2019 20:17:02 -0500 Subject: [bug#34056] [PATCH] core-updates -- gnu: python2: Fix test flags. Resent-Message-ID: Date: Mon, 21 Jan 2019 19:16:22 -0600 From: Eric Bavier Message-ID: <20190121191622.428b0932@centurylink.net> In-Reply-To: <87imyhj08h.fsf@cbaines.net> References: <20190113071850.14337-1-ericbavier@centurylink.net> <8736pwjhes.fsf@cbaines.net> <20190113204242.55461ef2@centurylink.net> <87imyhj08h.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/vnk7X9LatTJtztm5qbhzB.u"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 34056@debbugs.gnu.org --Sig_/vnk7X9LatTJtztm5qbhzB.u Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 21 Jan 2019 19:10:06 +0000 Christopher Baines wrote: > Eric Bavier writes: >=20 > > On Sun, 13 Jan 2019 22:56:27 +0000 > > Christopher Baines wrote: > > =20 > >> ericbavier@centurylink.net writes: > >> =20 > >> > From: Eric Bavier > >> > > >> > * gnu/packages/python.scm (python-2.7)[arguments]: 'EXTRATESTOPTS' -> > >> > 'TESTOPTS'. This overrides the default '-l' argument for memory lea= k checks > >> > which is not compatible with the -j for parallelism. > >> > --- > >> > gnu/packages/python.scm | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > >> > index 9b43f465cc..dffded738d 100644 > >> > --- a/gnu/packages/python.scm > >> > +++ b/gnu/packages/python.scm > >> > @@ -194,7 +194,7 @@ > >> > (assoc-ref %outputs "out") "/lib")) > >> > ;; With no -j argument tests use all available cpus, so prov= ide one. > >> > #:make-flags > >> > - (list (format #f "EXTRATESTOPTS=3D-j~d" (parallel-job-count)= )) > >> > + (list (format #f "TESTOPTS=3D-j~d" (parallel-job-count))) > >> > > >> > #:modules ((ice-9 ftw) (ice-9 match) > >> > (guix build utils) (guix build gnu-build-system)= ) =20 > >> > >> Hey Eric, > >> > >> I've also been looking at some Python 2 things on core-updates today, > >> trying to get the linkchecker package building again. > >> > >> I've just pushed a slightly different patch, but to this effect to > >> core-updates, and only just seen this message, sorry about that. =20 > > > > Not a problem. > > =20 > >> Thanks for looking at it though, this approach is probably neater, as I > >> used substitute* instead. =20 > > > > Would you like to keep your patch, or apply this one instead? =20 >=20 > I'm quite happy to switch to this approach. I don't know whether the > best way to do that is to switch out the patches by force-pushing to > core-updates, or to just apply your patch on top though... I can just adjust my patch. I think we don't want to force-push since there are people working on it. Thanks for your attention to core-updates :) `~Eric --Sig_/vnk7X9LatTJtztm5qbhzB.u Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlxGbuYACgkQ/XPKxxnT JWY8pA/+KQ+z3Ny5UglwQvS5+Wel8cT0nacDyFDlXuDq4FaxnpkJLGvqRIG7mKJz xhQnEbM+nbHTSvp2cFP1qMAvnM9RFBAr50t1CGeIebHNLy8V8yudPhhf2OTqxUnD 6MHMh2rtBquNJbdPAYmRgPtFMEJTeQyWf5JoJGQ/61jRs2V4pb6IXc2b1MEdZnkd 2eR6PgL9CILRGkdH2eqf8Lcrz7V1EgqkpjX+wm74dAqi/w6MugziYPQTnlpjo6y5 Lg/rVNlrTfPEfiiD0YL+jQo9vQljuLAbH3InXH6I6XqyUcxlq8KS4ny/NNKMfq1Y g2PTjoAdyVEfs+C5eGMl7Xc0IlrYkdVVw7Dmdybt7tOyZXJJwLWHkdQnfNqyEcoa 6j+CY1cOCx2ffopMFYqOwD2rwK93a8aYO8dCKAtWsCVowxzY9B80PnFpahQTsJaP xNM7yRfA+OeuEuAIaPsiG/4n7cw1GFG1j+eOcbykC0kBqoSRRi+v8LgTYqKXZ40l uW13IyUt8o5+0UcYq0nG6kfp6JsNbMGSs9/OzA7mZntsoEm3jiP6BNHG4kE6VPgS C6V1KEja29rkzOuVkT+Qj5bmvIe3PaxlMd1bgnDDZPVuVYSL/OXp9KSpUOeEBmXy X6Mgb5s/DvpV9gn1N7d2AYAzZarPVINHr1HMO7+Kxe9MtYsHFLc= =8cc/ -----END PGP SIGNATURE----- --Sig_/vnk7X9LatTJtztm5qbhzB.u--