From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:34852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjmFc-0006Xl-S1 for guix-patches@gnu.org; Wed, 16 Jan 2019 09:33:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjmFc-0004GQ-1n for guix-patches@gnu.org; Wed, 16 Jan 2019 09:33:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33608) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gjmFa-0004By-Sq for guix-patches@gnu.org; Wed, 16 Jan 2019 09:33:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gjmFa-00042J-Ec for guix-patches@gnu.org; Wed, 16 Jan 2019 09:33:02 -0500 Subject: [bug#34097] [PATCH] import: github: Do not update URI for packages using git-fetch. Resent-Message-ID: Date: Wed, 16 Jan 2019 08:32:05 -0600 From: Eric Bavier Message-ID: <20190116083205.2da5045e@centurylink.net> In-Reply-To: <878szkx4in.fsf@gnu.org> References: <878szkx4in.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/30/NAt9n1q7w4hao.PXHi0v"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 34097@debbugs.gnu.org --Sig_/30/NAt9n1q7w4hao.PXHi0v Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 16 Jan 2019 11:48:00 +0100 Ludovic Court=C3=A8s wrote: > Hi, >=20 > Arun Isaac skribis: >=20 > > During `guix refresh PACKAGE`, the source URI for packages using > > git-fetch need not be updated. It can be returned unchanged, as it > > is. The attached patch does that. > > > > As a side issue, without this patch, git-fetch packages that do not have > > a source URI ending in ".git" are not updated correctly using `guix > > refresh PACKAGE`. See the package emacs-evil for an example. > > > > From f63bf518395a06dd0c947222e177a66e59c59e96 Mon Sep 17 00:00:00 2001 > > From: Arun Isaac > > Date: Wed, 16 Jan 2019 15:21:06 +0530 > > Subject: [PATCH] import: github: Do not update URI for packages using > > git-fetch. > > > > * guix/import/github.scm (updated-github-url): Return the unchanged sou= rce URI > > for packages using git-fetch. > > [updated-url]: Do not handle URIs which end with ".git". =20 >=20 > LGTM, thanks! LGTM too. I had considered something similar when I first patched the updater for git-fetch, but hadn't found an example where it was needed (e.g. "emacs-evil"). Thanks! `~Eric --Sig_/30/NAt9n1q7w4hao.PXHi0v Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlw/QGUACgkQ/XPKxxnT JWaRaw/+JxRMwR6Gv37lRRM3wgRtymYb2mB08QQ+XaOPB0hIce8nn5T8S+M91jMO Ilnma9c2QdpgKKtfUYqhfx1QVNMGHzy/fl/01n9zyXbI42WQFYUBfpErik5AE3cd IZfyeJoYnb9LJ4wEYVBcQdExhEbRREcwPBUSblqp1O8e4UvQyXOXE4fPqu+eSgm+ CUBk841Vz7TA0m1ru9rHT3Es5cBnqQWpBfNbkfhjLzrpSsOAHRTWrO4dxSIVOsa/ EiLDl1srNzyjLJGcJKbx6o/1s5zWzT09Z1k5rJYDdeuI/8rHaogLrNGUP+FVJX7A QSGN696Thbr9Xe3h0y77Jigspih6+6xperT1MvlQBdmjnK6rprJTYdXj7zcu76Ra +RNvL7kfQKqtgqbRPX+Y77KPrEsJmnRdB/HIGCeGckVKQEVXIR7PhGUQsOVoVpJE KSbAanoTs0E8m+s5Ll1IHVJyVZ/Yai0+dfgqRvurecHJh+UNeKbFwJXahI7ne+yT UVz5pxLjgjb1Nw5FEss9unVddao7pAt+lDEvT2VAbc20B3x04MqOsEsjS++ZwdEb w54Cs5Tc15X+snbi+AM67VKgZKPXjOsVmGf/DFnMDOQkA47Fwi1zgCwz90/3gOxK boTA4xhtIdKN7AxUukoqdWDXoGAsa2KqD0v1+mlz07QXJVGBYJg= =t9kf -----END PGP SIGNATURE----- --Sig_/30/NAt9n1q7w4hao.PXHi0v--