From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:42204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gijNg-0006dG-TO for guix-patches@gnu.org; Sun, 13 Jan 2019 12:17:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gijNf-0007yB-11 for guix-patches@gnu.org; Sun, 13 Jan 2019 12:17:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58773) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gijNe-0007xb-EY for guix-patches@gnu.org; Sun, 13 Jan 2019 12:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gijNe-0001yP-2Z for guix-patches@gnu.org; Sun, 13 Jan 2019 12:17:02 -0500 Subject: [bug#34056] [PATCH] core-updates -- gnu: python2: Fix test flags. Resent-Message-ID: Date: Sun, 13 Jan 2019 19:16:10 +0200 From: Efraim Flashner Message-ID: <20190113171610.GB25281@macbook41> References: <20190113071850.14337-1-ericbavier@centurylink.net> <20190113074859.GB2050@macbook41> <20190113102320.543cba28@centurylink.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zCKi3GIZzVBPywwA" Content-Disposition: inline In-Reply-To: <20190113102320.543cba28@centurylink.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Eric Bavier Cc: 34056@debbugs.gnu.org, Eric Bavier --zCKi3GIZzVBPywwA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 13, 2019 at 10:23:20AM -0600, Eric Bavier wrote: > On Sun, 13 Jan 2019 09:48:59 +0200 > Efraim Flashner wrote: >=20 > > On Sun, Jan 13, 2019 at 01:18:49AM -0600, ericbavier@centurylink.net wr= ote: > > > From: Eric Bavier > > >=20 > > > * gnu/packages/python.scm (python-2.7)[arguments]: 'EXTRATESTOPTS' -> > > > 'TESTOPTS'. This overrides the default '-l' argument for memory leak= checks > > > which is not compatible with the -j for parallelism. > > > --- > > > gnu/packages/python.scm | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > > > index 9b43f465cc..dffded738d 100644 > > > --- a/gnu/packages/python.scm > > > +++ b/gnu/packages/python.scm > > > @@ -194,7 +194,7 @@ > > > (assoc-ref %outputs "out") "/lib")) > > > ;; With no -j argument tests use all available cpus, so provi= de one. > > > #:make-flags > > > - (list (format #f "EXTRATESTOPTS=3D-j~d" (parallel-job-count))) > > > + (list (format #f "TESTOPTS=3D-j~d" (parallel-job-count))) > > > =20 > > > #:modules ((ice-9 ftw) (ice-9 match) > > > (guix build utils) (guix build gnu-build-system)) > > > --=20 > > > 2.20.1 > > > =20 > >=20 > > I'm building out python2 now on my aarch64 board but I assume it'll > > work. While I do prefer the parallelism in the test suite, between the > > two I'd consider the memory leak checks the more important of the two. > >=20 >=20 > Are the memory-leak checks something that we need to worry about in our > packaging of python2? Can memory leaks be introduced in the way we > configure and build our python? Otherwise I assume that's something > more interesting to someone developing python itself and not as > interesting in system CI. IMHO. No idea. > I see I should probably move the comment about this overriding -l from > the commit message to the code comment. >=20 Sounds like a good idea :) --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --zCKi3GIZzVBPywwA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlw7clcACgkQQarn3Mo9 g1H5Aw/+PfP68e0wfLIeMp27gv+zelSFdSadj0ipcM5ZaVRDF4F/VfQ7l33MWezr jfhqLRxG8RGuHr1PWia7QtT417SnhOsD0IgWjLFUq6k34dSEXCUxV4OhSw6sArCs zoG4RuBr2MfaCkTxZD/9+g5qGk2e//eBDk3AoephMPh9D9WcHHDJgUlYHp0XNOMy ItAsafitKaSXdL8yT1WsE1DB3R8ls+pHZt1zgo4j8NS6FbqpIqvqPr5oLhYJ7qPw t9tzgZl/FGO7KxkCRDorNhQn4W7OaSDs/l+psdT2ixue+/2vIJoDJqFG/lh4Ja6d WuzA++jm1Cj+fd1vRwUllaUZ8cm8GEbz6nvHC1MDBUSONduu2aTArfi/rzr4Xnbj hDBydzhH7VcAcKMl73sXc9G6mrU4sHASFqDj461EW0FmQkqh3YvrpBN3yDG+BiCa 0JTP+wzgowFXLkXfTCSfn0d2ND9vgkDDGFsP5eNing+s097lQJ4yqKE3CwTpQ7Yl N/AnWw4qOgE9DqYY3yDauCKrmVV5rqozZ1GheV9qpkPHP6KzkezNvwdWbWi6jXf5 hFqLZheqdAI6o6aGoJ9zSF03nC6md2r/BL8d/Gfho10JzC1r8el50jsTROVpvniM tJsVwGQc52+7ApcgdVanWkzAkI+XLZmWSg8YO4bAzCULjg6Jilg= =acPX -----END PGP SIGNATURE----- --zCKi3GIZzVBPywwA--