bug#33962: guix pull fails on latest master

bug#33962: guix pull fails on latest master

[Brendan Tildesley]

95bf2fb637ba4abb27efe94e0b671c1e93204e4f , which adds wl-clipboard fails
to build because it references meson-build-system without importing the
required module. I'm guessing adding  #:use-module (guix build-system
meson)   ; would fix it.

I'm curious to know how this error was made.

bug#33962: Acknowledgement (guix pull fails on latest master)

[Brendan Tildesley]

Efraim fixed it:

bug#33962: guix pull fails on latest master

[Rutger Helling]

[-- Attachment #1: Type: text/plain, Size: 721 bytes --]

Sorry, that was sloppiness on my part. I built the package on my own
Guix that already had staging merged where apparently the
meson-build-system was already added to the modules.

I was about to revert but I just noticed it's already been fixed. I'll
double check if it builds on a clean master next time.

On Fri, 4 Jan 2019 01:24:22 +1100
Brendan Tildesley <brendan.tildesley@gmail.com> wrote:

> 95bf2fb637ba4abb27efe94e0b671c1e93204e4f , which adds wl-clipboard
> fails to build because it references meson-build-system without
> importing the required module. I'm guessing adding  #:use-module
> (guix build-system meson)   ; would fix it.
> 
> I'm curious to know how this error was made.
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

bug#33962: guix pull fails on latest master

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

On Fri, Jan 04, 2019 at 01:24:22AM +1100, Brendan Tildesley wrote:
> 95bf2fb637ba4abb27efe94e0b671c1e93204e4f , which adds wl-clipboard fails
> to build because it references meson-build-system without importing the
> required module. I'm guessing adding  #:use-module (guix build-system
> meson)   ; would fix it.
> 
> I'm curious to know how this error was made.

My guess is that the code contribution was tested with the
meson-build-system module imported correctly. However, the actual commit
or patch was created without the module import line.

When reviewing patches just by reading them, it's easy to miss mistakes
like this one.

This should be fixed in commit 4382cef28cb6de4b2b505788b759b0fe4f8ea603

Thanks for the reports!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]