From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcVFj-00037X-NT for guix-patches@gnu.org; Thu, 27 Dec 2018 07:59:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcVFe-0006Rg-LE for guix-patches@gnu.org; Thu, 27 Dec 2018 07:59:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:33111) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gcVFe-0006RN-GR for guix-patches@gnu.org; Thu, 27 Dec 2018 07:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gcVFe-0007X1-BC for guix-patches@gnu.org; Thu, 27 Dec 2018 07:59:02 -0500 Subject: bug#33875: [PATCH] `guix lint' warn of GitHub autogenerated source tarballs Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Thu, 27 Dec 2018 14:58:22 +0200 From: Efraim Flashner Message-ID: <20181227125822.GT2581@macbook41> References: <20181226084712.GQ2581@macbook41> <87zhssb309.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XLTQE3HqOi3RIrZG" Content-Disposition: inline In-Reply-To: <87zhssb309.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33875-done@debbugs.gnu.org --XLTQE3HqOi3RIrZG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 26, 2018 at 06:40:22PM +0100, Ludovic Court=C3=A8s wrote: > Hello! >=20 > Efraim Flashner skribis: >=20 > > From dcd8b207f932289cb3b35720af45f49f849b7c27 Mon Sep 17 00:00:00 2001 > > From: Efraim Flashner > > Date: Tue, 25 Dec 2018 16:29:12 +0200 > > Subject: [PATCH] lint: Add checker for unstable tarballs. > > > > * guix/scripts/lint.scm (check-source-unstable-tarball): New procedure. > > (%checkers): Add it. > > * tests/lint.scm ("source-unstable-tarball", "source-unstable-tarball: > > source #f", "source-unstable-tarball: valid", "source-unstable-tarball: > > package named archive", "source-unstable-tarball: not-github", > > "source-unstable-tarball: git-fetch"): New tests. >=20 > Could you mention =E2=80=98source-unstable-tarball=E2=80=99 in doc/guix.t= exi? Added >=20 > Otherwise LGTM! >=20 > Please double-check that =E2=80=9Cmake check TESTS=3Dtests/lint.scm=E2=80= =9D passes and > that =E2=80=98./pre-inst-env guix lint -c source-unstable-tarball=E2=80= =99 works. =E2=80=98./pre-inst-env guix lint -c source-unstable-tarball=E2=80=99 shows= many many autogenerated tarballs, and I made the checks pass. >=20 > Thanks! >=20 > Ludo=E2=80=99. Pushed as c180017b6f7e9b6d23238c1fbaac986c435cd35e --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --XLTQE3HqOi3RIrZG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlwkzG4ACgkQQarn3Mo9 g1GZmRAAosmRARqJhdj6WqOPOe884R3VJgcejOlF5Xrt0BtQpY5L3/S7GNm1jxz8 Q1wnT6nhjEHU9+XpxvW4XIj68amPyRuIYQvsTwgk3Jzs8KYzJi/CBuszLgGRa1KJ +qg6oMkfPsODxTM3oQ5qmYnZXHudxDlFifOvokBbiJbrE0n8Cz4DSWB3M3NlmGQz yjXasQ1u/ehEEkqyi1+9wv092V4kKYh0cVdfKN1XTeo6ZDTe8IPI0SmS9Vq501Yq KymSpt8zC/Gb19GxfeBQMQUqkp/0CMcmOV77Pfmc61DNADhUt/+VOqbENzjtekBb BiUIMBdhhmGfaB3JBeTcKj8XNq6wVvxp0XiyCaQdZApUz3KIdSUl9vo3t2HIXQYI QyEWYflg1SHzBSwlF12Jaln9aIdktgYG5qecMMSapEuoX4wGVrVDKa8EECd1FOFL ECUGMmES0kg3rhv64Rzd9vJtm040JaPgy8/S7LaZIZUfaiX6RdqOyGIJbVl/Twzo 1lMF7SSkB7BiWFKUegLmfjBJH33sQYi4cGbQf0mSV2yTJCH5Z4Nn3uP3T560yngI H2GWM8Y+pLYagFgfixbY3bB0mHj2YJuF/oVKrDaM7NValVaIgVOr6X4oeRMmIIHU Rj9/V3x4WHM558Y0hbwpTngn6mTNs6C1eew/C9BLEE+0JABtV90= =/7LL -----END PGP SIGNATURE----- --XLTQE3HqOi3RIrZG--