From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: 01/01: python: Honor '--cores=...' in tests. Date: Fri, 14 Dec 2018 11:57:56 -0600 Message-ID: <20181214115756.0f22bc72@centurylink.net> References: <20181117064344.29159.44615@vcs0.savannah.gnu.org> <20181117064345.133A42043C@vcs0.savannah.gnu.org> <87y38sw2ey.fsf@cbaines.net> <87va3ww1iq.fsf@cbaines.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/9udjoPwIEXZ=0bVZOZ/ADUi"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXrj1-0007RG-UM for guix-devel@gnu.org; Fri, 14 Dec 2018 12:58:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXrix-0002iV-0X for guix-devel@gnu.org; Fri, 14 Dec 2018 12:58:11 -0500 Received: from mail.onyx.syn-alias.com ([206.152.134.66]:50467 helo=smtp.centurylink.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXriw-0002hD-Nb for guix-devel@gnu.org; Fri, 14 Dec 2018 12:58:06 -0500 In-Reply-To: <87va3ww1iq.fsf@cbaines.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Christopher Baines Cc: guix-devel@gnu.org, Eric Bavier --Sig_/9udjoPwIEXZ=0bVZOZ/ADUi Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 14 Dec 2018 15:50:37 +0000 Christopher Baines wrote: > Christopher Baines writes: >=20 > > Eric Bavier writes: > > =20 > >> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > >> index 2b6a064..46ce0dd 100644 > >> --- a/gnu/packages/python.scm > >> +++ b/gnu/packages/python.scm > >> @@ -190,6 +190,9 @@ > >> "--enable-unicode=3Ducs4" > >> (string-append "LDFLAGS=3D-Wl,-rpath=3D" > >> (assoc-ref %outputs "out") "/lib")) > >> + ;; With no -j argument tests use all available cpus, so provid= e one. > >> + #:make-flags > >> + (list (format #f "EXTRATESTOPTS=3D-j~d" (parallel-job-count))) > >> =20 > >> #:modules ((ice-9 ftw) (ice-9 match) > >> (guix build utils) (guix build gnu-build-system)) = =20 > > > > Hi Eric, > > > > I'm having trouble building the python2 package on core-updates (which > > was renamed from core-updates-next), and I think it relates to this > > change. > > > > This is roughly the issue I'm seeing: > > > > LD_LIBRARY_PATH=3D/tmp/guix-build-python2-2.7.15.drv-0/Python-2.7.15 = ./python -Wd -3 -E -tt ./Lib/test/regrtest.py -l -j12 > > > > -l and -j don't go together! > > > > > > Since all the python packages look to inherit from python-2.7 that's > > being changed here, perhaps this worked for some of them (I know you > > mentioned python-minimal in one message), but not all of them, or at > > least python2? =20 >=20 > Just got around to testing this, moving this change to python-3.7, from > python-2.7 fixes the python-2.7 build for me, but I haven't checked > how that affects how many cores are actually used when running the tests. Strange. I recall testing this patch on both python2 and python. Not sure what has changed since then. `~Eric --Sig_/9udjoPwIEXZ=0bVZOZ/ADUi Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlwT7yQACgkQ/XPKxxnT JWZbzg/+Nc6t+oIv1Bi5qx0qhtljg24kohtU76RDKPS1gAJX+Pd4nYQyMd9+UOoN XYHUKqtPvZYTdjKC4DJj8Zbs4xPGgtjA4SzyASpWGTkipcxcQgAgZYE9CGUHxvpd RV74TdBhdHFNrBqz2BewpS/N/jADdwa2e8AQziKhZ9vJ9beDicfNXczoxady8r2q jEZunmSaqutDTz9LZ2/1T7MBhn7+bousTTvifm2p0sT11JubqQl2wFxZIqfDIGOx +a83WJ08/fnJwgHBCvFePiRpduG75dsNGjsOZHFttrJUI0ngST7Sofo6hHBBy/VM C/vipRQ4s087hAGYorw8K4OBzlVte6XAvKzqiaIhkwYPIroJWW3cQ3EFu3It/PQ7 8JKgH7DUQVkE+g/AgInd+Vv1qZlnw0JzWkFfnma/JS5ukouijhSLkHhJxSDM2+Z6 WHn/CXKY5kREEd4cXjiqakhx08MfY/hiNjBFwdG32d6r5ie2sUgoVyf5k9pjUEgG GNuPN0KqzCfnhd6SWxrduvX9DSBQg3674WGiOECrYSmB+IojuOt/IXvE6nniYk1k sKCkOzhXlyoUSjMPJ6/8xnTCJJ92gojT5nTf+RNDpf2/dMQUgSB/9gqJ3PPX4Dpo lr1eq8W8aQ0aLb4aMpxmXgRK4/ZUYJFcBy5+6U2z1I2PPpmL5mg= =ZwjT -----END PGP SIGNATURE----- --Sig_/9udjoPwIEXZ=0bVZOZ/ADUi--