bug#33605: ncmpcpp fails to build with Boost 1.68.0

bug#33605: ncmpcpp fails to build with Boost 1.68.0

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 2960 bytes --]

Since the core-updates merge, ncmpcpp is failing to build during its
configure phase:

------
starting phase `configure'
source directory: "/tmp/guix-build-ncmpcpp-0.8.2.drv-0/ncmpcpp-0.8.2" (relative from build: ".")
build directory: "/tmp/guix-build-ncmpcpp-0.8.2.drv-0/ncmpcpp-0.8.2"
configure flags: ("CONFIG_SHELL=/gnu/store/q19l04vd2za80mk1845pz7r8cz29qk43-bash-minimal-4.4.23/bin/bash" "SHELL=/gnu/store/q19l04vd2za80mk1845pz7r8cz29qk43-bash-minimal-4.4.23/bin/bash" "--prefix=/gnu/store/anhg2l53c15ipiwnvbcg7rjfdg1ml68q-ncmpcpp-0.8.2" "--enable-fast-install" "--build=x86_64-unknown-linux-gnu" "LIBS=-L/gnu/store/k8djbb701a48k310kpkf3vpic4d1jyz5-boost-1.68.0/lib -lboost" "CFLAGS=-I/gnu/store/k8djbb701a48k310kpkf3vpic4d1jyz5-boost-1.68.0/include")
checking for a BSD-compatible install... /gnu/store/5s2nib1lrd2101bbrivcl17kjx1mspw6-coreutils-8.30/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /gnu/store/5s2nib1lrd2101bbrivcl17kjx1mspw6-coreutils-8.30/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... no
checking whether make supports nested variables... yes
checking for g++... g++
checking whether the C++ compiler works... no
configure: error: in `/tmp/guix-build-ncmpcpp-0.8.2.drv-0/ncmpcpp-0.8.2':
configure: error: C++ compiler cannot create executables
See `config.log' for more details
Backtrace:
           4 (primitive-load "/gnu/store/yrxl18dp9j89iz0013f7x9jva02…")
In ice-9/eval.scm:
   191:35  3 (_ _)
In srfi/srfi-1.scm:
   863:16  2 (every1 #<procedure 73a8a0 at /gnu/store/gfprsx2m62cvq…> …)
In /gnu/store/gfprsx2m62cvqbh7ysc9ay9slhijvmal-module-import/guix/build/gnu-build-system.scm:
   799:28  1 (_ _)
In /gnu/store/gfprsx2m62cvqbh7ysc9ay9slhijvmal-module-import/guix/build/utils.scm:
    616:6  0 (invoke _ . _)

/gnu/store/gfprsx2m62cvqbh7ysc9ay9slhijvmal-module-import/guix/build/utils.scm:616:6: In procedure invoke:
Throw to key `srfi-34' with args `(#<condition &invoke-error [program: "/gnu/store/q19l04vd2za80mk1845pz7r8cz29qk43-bash-minimal-4.4.23/bin/bash" arguments: ("./configure" "CONFIG_SHELL=/gnu/store/q19l04vd2za80mk1845pz7r8cz29qk43-bash-minimal-4.4.23/bin/bash" "SHELL=/gnu/store/q19l04vd2za80mk1845pz7r8cz29qk43-bash-minimal-4.4.23/bin/bash" "--prefix=/gnu/store/anhg2l53c15ipiwnvbcg7rjfdg1ml68q-ncmpcpp-0.8.2" "--enable-fast-install" "--build=x86_64-unknown-linux-gnu" "LIBS=-L/gnu/store/k8djbb701a48k310kpkf3vpic4d1jyz5-boost-1.68.0/lib -lboost" "CFLAGS=-I/gnu/store/k8djbb701a48k310kpkf3vpic4d1jyz5-boost-1.68.0/include") exit-status: 77 term-signal: #f stop-signal: #f] 491fc0>)'.
builder for `/gnu/store/xnypbkav5wnqnjh8dxslcw6a2f8m6pmf-ncmpcpp-0.8.2.drv' failed with exit code 1
build of /gnu/store/xnypbkav5wnqnjh8dxslcw6a2f8m6pmf-ncmpcpp-0.8.2.drv failed
------

I assume the failure is related to the Boost upgrade from 1.66.0 to
1.68.0, but I haven't confirmed that yet.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#33605: ncmpcpp and innoextract build when Boost is built with C++14

[Leo Famulari]

[-- Attachment #1.1: Type: text/plain, Size: 115 bytes --]

Building Boost with C++14 fixes the build failures of ncmpcpp and
innoextract. Patch attached.

What should we do?

[-- Attachment #1.2: 0001-gnu-Boost-Build-with-C-14.patch --]
[-- Type: text/plain, Size: 816 bytes --]

From 90f990416040d240a68d672fc8ac05b1adc50b8a Mon Sep 17 00:00:00 2001
From: Leo Famulari <leo@famulari.name>
Date: Tue, 4 Dec 2018 16:39:28 -0500
Subject: [PATCH] gnu: Boost: Build with C++14.

* gnu/packages/boost.scm (boost)[arguments]: Pass 'cxxflags=-std=c++14'
to #:make-flags.
---
 gnu/packages/boost.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/boost.scm b/gnu/packages/boost.scm
index b772781f5..f5c2c5830 100644
--- a/gnu/packages/boost.scm
+++ b/gnu/packages/boost.scm
@@ -67,6 +67,7 @@
      `(#:tests? #f
        #:make-flags
        (list "threading=multi" "link=shared"
+             "cxxflags=-std=c++14"
 
              ;; Set the RUNPATH to $libdir so that the libs find each other.
              (string-append "linkflags=-Wl,-rpath="
-- 
2.19.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#33605: Boost 1.68.0 seems to require C++14 for libboost_system

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

I didn't figure out exactly what is missing from Boost when it is built
without C++14 support, but there is some related discussion on the Boost
mailing list:

https://lists.boost.org/Archives/boost/2016/03/228703.php

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#33605: ncmpcpp and innoextract build when Boost is built with C++14

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 361 bytes --]

Leo Famulari <leo@famulari.name> writes:

> Building Boost with C++14 fixes the build failures of ncmpcpp and
> innoextract. Patch attached.
>
> What should we do?

Thanks for finding the issue.  I suggest pushing the fix to the
'staging' branch.  We can take the ~1900 rebuilds there.

On a side note, it would be good to enable Python 3 support in Boost
too.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#33605: ncmpcpp and innoextract build when Boost is built with C++14

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

On Wed, Dec 05, 2018 at 04:14:19PM +0100, Marius Bakke wrote:
> Thanks for finding the issue.  I suggest pushing the fix to the
> 'staging' branch.  We can take the ~1900 rebuilds there.

Done with commit a7ff66998f6e0eeb5da485bab7f6e0b55a46651e.

I'm a little concerned that it may be too disruptive for the staging
branch (things might break), but if that happens we can use a special
boost-cxx14 package for ncmpcpp and innoextract instead. I'll do that on
master now.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Boost support for Python 3

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

On Wed, Dec 05, 2018 at 04:14:19PM +0100, Marius Bakke wrote:
> On a side note, it would be good to enable Python 3 support in Boost
> too.

Do you know what is required? Just adding python-3 to Boost's inputs? Is
it low-risk or should we do it in core-updates or its own branch?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]