From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Subject: bug#33509: core-updates: arc-theme fails with "Invalid GNOME version: 3.24" Date: Tue, 27 Nov 2018 16:07:45 +0100 Message-ID: <20181127160745.2f994639@alma-ubu> References: <20181126125515.5dee070e@alma-ubu> <20181126210033.GI28778@macbook41> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/vrcVbQqepTOlpPUB.JEn+_R"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRfBd-0004Lo-By for bug-guix@gnu.org; Tue, 27 Nov 2018 10:22:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRey2-0003KD-LE for bug-guix@gnu.org; Tue, 27 Nov 2018 10:08:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:48137) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRey2-0003K3-HO for bug-guix@gnu.org; Tue, 27 Nov 2018 10:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gRey2-0005W1-BF for bug-guix@gnu.org; Tue, 27 Nov 2018 10:08:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20181126210033.GI28778@macbook41> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Efraim Flashner Cc: 33509@debbugs.gnu.org --Sig_/vrcVbQqepTOlpPUB.JEn+_R Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 26 Nov 2018 23:00:33 +0200 Efraim Flashner wrote: > On Mon, Nov 26, 2018 at 12:55:15PM +0100, Bj=C3=B6rn H=C3=B6fling wrote: > > On core-updates the package arc-theme fails: > >=20 > > starting phase `configure' > > source directory: > > "/tmp/guix-build-arc-theme-20170302.drv-0/arc-theme-20170302" build > > directory: > > "/tmp/guix-build-arc-theme-20170302.drv-0/arc-theme-20170302" > > configure flags: > > ("CONFIG_SHELL=3D/gnu/store/q19l04vd2za80mk1845pz7r8cz29qk43-bash > > configure: WARNING: unrecognized options: --enable-fast-install > > checking for a BSD-compatible > > install... /gnu/store/5s2nib1lrd2101bbrivcl17kjx1m checking whether > > build environment is sane... yes checking for a thread-safe mkdir > > -p... /gnu/store/5s2nib1lrd2101bbrivcl17kjx1msp checking for > > gawk... gawk checking whether make sets $(MAKE)... no checking > > whether make supports nested variables... yes checking for > > pkg-config... /gnu/store/xyiyf12w4i7zf5g5b4ah0bi1mmd6i8xa-pkg-confi > > checking pkg-config is at least version 0.9.0... yes configure: > > error: Invalid GNOME version: 3.24 > >=20 > > It seams that only GNOME versions until 3.22 are valid. > >=20 > > Nix has a workaround that sets the version down: > >=20 > > https://github.com/NixOS/nixpkgs/commit/165fa89762d7156bb3f2774cd3ff0d4= 0cd0a9606 > >=20 > > If I set the version hard to 3.22 the package builds again > > successfully: > >=20 > > - '(#:phases > > + '(#:configure-flags > > + '("--with-gnome=3D3.22") > > + #:phases > >=20 > > Is it legitimate to patch it like that or do we need more tests? > >=20 > > Bj=C3=B6rn > > =20 >=20 > I'd look into if you can use (version-major+minor (package-version > gnome)) so it doesn't have to be updated. >=20 >=20 Hi Efraim, I don't know what you mean with "so it doesn't have to be updated"? I mean changing the package definition is an update? Also, I don't know what your intention with "version-major+minor" is? On core-updates the current version of gnome is "3.24.3". Then (version-major+minor gnome-version) would still evaluate to 3.24, which IS too big, 3.22 is the maximum accepted version.=20 Let me explain a bit more: With adding "--with-gnome=3D3.22" we are pretending the configure-script that we will use gnome-3.22, although we still use the latest version (To be precise, we use gtk+, but that seams to report the gnome-version with pkg-config).=20 This version number is then used to search in the directory /tmp/guix-build-arc-theme-20170302.drv-0/arc-theme-20170302/common/gtk-3.0 the matching "major.minor" version, choosing the right theme. 3.22 is already symlinking to 3.20, and that is the highest available real directory. So we might get wrong look&feel here, because it is not adapted to GNOME 3.24. But there is no further development upstream anyway. If it doesn't look totally malformed, we can use it like that. My disk is a bit full, I can't do a vm-image with it currently. Bj=C3=B6rn --Sig_/vrcVbQqepTOlpPUB.JEn+_R Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlv9XcIACgkQvyhstlk+X/1aogCeJ3h4Z1De2ILQKQDT1SdAkA9U FGoAnjfewSOjhRZh08wuFoVK/gW8iy+1 =mXKq -----END PGP SIGNATURE----- --Sig_/vrcVbQqepTOlpPUB.JEn+_R--