From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: bug#33300: hplip 3.18.9 contains non-free binary blobs Date: Wed, 7 Nov 2018 14:48:58 +0200 Message-ID: <20181107124858.GE1206@macbook41> References: <87sh0dur48.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xaMk4Io5JJdpkLEb" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKNHb-00048X-Lm for bug-guix@gnu.org; Wed, 07 Nov 2018 07:50:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKNHW-0000EQ-Pk for bug-guix@gnu.org; Wed, 07 Nov 2018 07:50:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:33958) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKNHW-0000EI-Ln for bug-guix@gnu.org; Wed, 07 Nov 2018 07:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKNHW-0002VY-Dv for bug-guix@gnu.org; Wed, 07 Nov 2018 07:50:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKNGd-0003VU-GY for bug-guix@gnu.org; Wed, 07 Nov 2018 07:49:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKNGY-0008Bg-Q4 for bug-guix@gnu.org; Wed, 07 Nov 2018 07:49:07 -0500 Content-Disposition: inline In-Reply-To: <87sh0dur48.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33300@debbugs.gnu.org --xaMk4Io5JJdpkLEb Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 07, 2018 at 11:19:35AM +0100, Ludovic Court=C3=A8s wrote: > Hello, >=20 > The tarball of hplip 3.18.9 contains several .so files that it installs > as-is: >=20 > --8<---------------cut here---------------start------------->8--- > ludo@ribbon ~/src/guix$ (cd /tmp; tar xf $(guix build -S hplip)) > ludo@ribbon ~/src/guix$ find /tmp/hplip-3.18.9 -name \*.so > /tmp/hplip-3.18.9/prnt/plugins/hbpl1-arm32.so > /tmp/hplip-3.18.9/prnt/plugins/hbpl1-x86_64.so > /tmp/hplip-3.18.9/prnt/plugins/lj-x86_32.so > /tmp/hplip-3.18.9/prnt/plugins/hbpl1-arm64.so > /tmp/hplip-3.18.9/prnt/plugins/hbpl1-x86_32.so > /tmp/hplip-3.18.9/prnt/plugins/lj-arm64.so > /tmp/hplip-3.18.9/prnt/plugins/lj-x86_64.so > /tmp/hplip-3.18.9/prnt/plugins/lj-arm32.so > /tmp/hplip-3.18.9/prnt/hpcups/libImageProcessor-x86_32.so > /tmp/hplip-3.18.9/prnt/hpcups/libImageProcessor-x86_64.so > --8<---------------cut here---------------end--------------->8--- >=20 > I tried removing them with a snippet (patch attached), but installation > eventually fails while trying to link against libImageProcessor, which > is now missing. >=20 > In people suggest that > 3.18.6 is the last known-good version. Indeed that version does not > have the obnoxious libImageProcessor, so that should be fine. It does > come with the non-free binary plug-ins, though these are just plugins so > removing them will be easier: >=20 > --8<---------------cut here---------------start------------->8--- > ludo@ribbon ~/src/guix$ find /tmp/hplip-3.18.6/ -name \*.so > /tmp/hplip-3.18.6/prnt/plugins/hbpl1-arm32.so > /tmp/hplip-3.18.6/prnt/plugins/hbpl1-x86_64.so > /tmp/hplip-3.18.6/prnt/plugins/lj-x86_32.so > /tmp/hplip-3.18.6/prnt/plugins/hbpl1-arm64.so > /tmp/hplip-3.18.6/prnt/plugins/hbpl1-x86_32.so > /tmp/hplip-3.18.6/prnt/plugins/lj-arm64.so > /tmp/hplip-3.18.6/prnt/plugins/lj-x86_64.so > /tmp/hplip-3.18.6/prnt/plugins/lj-arm32.so > --8<---------------cut here---------------end--------------->8--- >=20 > Thus, I propose to: >=20 > 1. Revert to 3.18.6 (we=E2=80=99ll upgrade if and when hplip becomes fr= ee > again.) Not bad for an interm solution. Debian already has 3.18.10 packaged, and based on their versioning scheme it still contains non-free artifacts. >=20 > 2. Add a snippet to remove the non-free plugins. >=20 > Thoughts? Here's what I have right now: ;; Delete non-free blobs$ (delete-file "prnt/hpcups/libImageProcessor-x86_64.so")$ (delete-file "prnt/hpcups/libImageProcessor-x86_32.so")$ (delete-file-recursively "prnt/plugins")$ (substitute* "Makefile.am"$ (("dist_printplugins_DATA") "# dist_printplugins_DATA")) and a patch from debian to address imageprocessor: https://salsa.debian.org/printing-team/hplip/raw/debian/3.18.10+dfsg0-1/d= ebian/patches/0025-Remove-all-ImageProcessor-functionality-which-is-clo.pat= ch >=20 > Thanks, > Ludo=E2=80=99. >=20 > diff --git a/gnu/packages/cups.scm b/gnu/packages/cups.scm > index 4259648c69..c0ac365691 100644 > --- a/gnu/packages/cups.scm > +++ b/gnu/packages/cups.scm > @@ -410,6 +410,19 @@ device-specific programs to convert and print many t= ypes of files.") > '(begin > (substitute* "prnt/hpcups/genPCLm.cpp" > (("boolean") "bool")) > + > + ;; Starting from version 3.18.9, hplip comes with bina= ry > + ;; blobs under prnt/hpcups and prnt/plugins. Remove t= hem. > + (for-each delete-file (find-files "." "\\.so$")) > + > + ;; This trick changes the behavior of the > + ;; 'install-data-hook' target so that it doesn't insta= ll the > + ;; binary blobs. > + (substitute* "Makefile.in" > + (("^UNAME =3D.*") > + "UNAME =3D free-software-only-thanks\n") > + (("prnt/hpcups/libImageProcessor-([[:graph:]]+)\\.so= ") > + "")) > #t)))) > (build-system gnu-build-system) > (home-page "https://developers.hp.com/hp-linux-imaging-and-printing") --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --xaMk4Io5JJdpkLEb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlvi3zcACgkQQarn3Mo9 g1GC2w//eEUPcbbb4+g25mvI/ZtZZrZbFiKFyXztcuE57pipsjcGTH8iACvsOidy W8iwFqwutEPzALaKIpWW3TKJ0oS5yzqnxP4Hykec2tN7zZlUsr0yqObAwhDTpoxR 9vy0L42/4WKQayKi3aKlLLKiGoT26irYPN2miXDTijF4e3wtuy7BE6Kq60hYeKyX PgTZLsye2CeaMXydbJ+Y9dtWiT51FUdVfLKwtJoB2chl/9h7xk8KLFevYWiBvA2x yfsQ3+a3ToshIGh8RU/y3XDWECwa3o8odlOfjIumCyfFABSL7h5Zdmzw3ogHsBWr MqVaHQ1pQCFTqufKaDAEewc8nonYUDEVqvHN1fxd9EvrZGI9QvbtLgB8MDit7yn/ 31Id13FrE2oDr+SjeykA3G/dWXB9fDsl+UUbeXds6JrFRwOHwglG3hFcU9d9/giu QGJOpFkm0cyVZVYr7h32ysEdgsr13yZChgTXitg6xvwZpK8eqRK/Aaglr6AqdFSs 09S6VMdmIGdxyitRL89EjCRSB2D0fwnXRWzOsmbPfj76oRqv4ftL4b/wMsTXUVA5 Jw3Uwxx8VRAXBpraQiO/t/umLeOExVUlAaSRD1Y1Ub5z2+R9qNN9mZHW/1KgT1Up rVCM8TEBXIpS0zkng3ENLUvV27m7wisbxFpCdfjcPGpWnAItHlM= =CtNY -----END PGP SIGNATURE----- --xaMk4Io5JJdpkLEb--