From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJzbW-0000U6-AU for guix-patches@gnu.org; Tue, 06 Nov 2018 06:33:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJzbT-0007R1-1T for guix-patches@gnu.org; Tue, 06 Nov 2018 06:33:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60063) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gJzbS-0007Qv-Ui for guix-patches@gnu.org; Tue, 06 Nov 2018 06:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gJzbS-0001EA-Q5 for guix-patches@gnu.org; Tue, 06 Nov 2018 06:33:02 -0500 Subject: [bug#33134] [PATCH 1/5] guix-install.sh: Update welcome. Resent-Message-ID: Date: Tue, 6 Nov 2018 12:32:32 +0100 From: Danny Milosavljevic Message-ID: <20181106123232.22408e9b@scratchpost.org> In-Reply-To: <20181103011034.70086-1-s@ricketyspace.net> References: <20181024115443.GA1297@macbook41> <20181103011034.70086-1-s@ricketyspace.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/oUVX8aZjqUTWkpSTXnXMX9q"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: rsiddharth Cc: 33134@debbugs.gnu.org --Sig_/oUVX8aZjqUTWkpSTXnXMX9q Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 2 Nov 2018 21:10:34 -0400 rsiddharth wrote: > * etc/guix-install.sh (welcome): Read exactly one character from input. > --- > etc/guix-install.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/etc/guix-install.sh b/etc/guix-install.sh > index ca6874ba0..cf839c20e 100755 > --- a/etc/guix-install.sh > +++ b/etc/guix-install.sh > @@ -398,7 +398,7 @@ This script installs GNU Guix on your system > https://www.gnu.org/software/guix/ > EOF > echo -n "Press return to continue..." > - read -r ANSWER > + read -N 1 -r ANSWER While it's nice for the interactive user, doesn't this break yes | ./guix-install.sh because now it doesn't wait for the newline? --Sig_/oUVX8aZjqUTWkpSTXnXMX9q Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlvhe9AACgkQ5xo1VCww uqUlEwf7Bh3xH8CCksNYsisj/RijvmYVfm6WprbIuBUWctJzOYyW4cvHg+QBjKWQ 6a3NDhv9lanxVFnSmfOWF+mRfT0FQzNl1LaEhMSyu5aeQuLs6Ikl7uPvk5Mgr890 Q/5SSA7Io+4zZNt4KWs8Vdg69bkJAqt/mXRiW7oK+u3UefVeTHHvEZ8aOKh+UFh9 C0JDhQl+JbrwHCWujccM75gRl3NEH9FDqlCVlnmxDCJLf+utvga/K4DXLIsl2UE2 wvTco8Z0g2vRjKx/Eb5WioUIZTJsEEy/n53AOC8XXG3zUOb6VXzhctK6WEc27CAv lb1jOYVpDLi9rWy4X60q+8BsA5UpsA== =doGH -----END PGP SIGNATURE----- --Sig_/oUVX8aZjqUTWkpSTXnXMX9q--