[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Laura Lazzati]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 17 00:00:00 2001
From: laura <laura.lazzati.15@gmail.com>
Date: Fri, 19 Oct 2018 19:15:37 -0300
Subject: [PATCH] I add r-aspi package appended to cran.scm file

---
 gnu/packages/cran.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index efcc2dccb..0d8ee6a97 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -6256,3 +6256,22 @@ a header row or not.  The dataset should contain
only one independent variable
 (x) and one dependent variable (y) and can contain a weight for each
 observation.")
     (license license:gpl2)))
+
+(define-public r-aspi
+  (package
+    (name "r-aspi")
+    (version "0.2.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "aspi" version))
+       (sha256
+        (base32
+         "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
+    (build-system r-build-system)
+    (home-page "https://cran.r-project.org/web/packages/aspi/")
+    (synopsis "Analysis of Symmetry of Parasitic Infections")
+    (description
+     "Tools for the analysis and visualization of bilateral asymmetry in
+ parasitic infections.")
+    (license license:gpl3)))
-- 
2.17.1

[-- Attachment #2: Type: text/html, Size: 1690 bytes --]

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Ricardo Wurmus]

Hi Laura,

congratulations on your first patch to Guix!

What follows are a few comments on minor changes that I would like to
see before applying the patch to Guix.

> From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 17 00:00:00 2001
> From: laura <laura.lazzati.15@gmail.com>
> Date: Fri, 19 Oct 2018 19:15:37 -0300
> Subject: [PATCH] I add r-aspi package appended to cran.scm file
>
> ---
>  gnu/packages/cran.scm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

For commits to Guix, we use a somewhat strict commit message format.
You can take a look at the commit log to get a feel for it.  In the case
of adding r-aspi to cran.scm this would be the expected commit message:

--8<---------------cut here---------------start------------->8---
gnu: Add r-aspi.

* gnu/packages/cran.scm (r-aspi): New variable.
--8<---------------cut here---------------end--------------->8---

The first line is always a concise summary.  This is followed by a
change log listing modified files and how they were modified.

> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index efcc2dccb..0d8ee6a97 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -6256,3 +6256,22 @@ a header row or not.  The dataset should contain
> only one independent variable
>  (x) and one dependent variable (y) and can contain a weight for each
>  observation.")
>      (license license:gpl2)))
> +
> +(define-public r-aspi
> +  (package
> +    (name "r-aspi")
> +    (version "0.2.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "aspi" version))
> +       (sha256
> +        (base32
> +         "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> +    (build-system r-build-system)
> +    (home-page "https://cran.r-project.org/web/packages/aspi/")
> +    (synopsis "Analysis of Symmetry of Parasitic Infections")

Please use lowercase for all words except for the first.  CRAN synopses
are usually in titlecase and the importer can’t automatically figure out
which words should be converted, so this needs to be done manually.

> +    (description
> +     "Tools for the analysis and visualization of bilateral asymmetry in
> + parasitic infections.")

Please use a complete sentence for the description.  The easiest way is
probably to just prepend “This package provides”.

> +    (license license:gpl3)))

I checked the source files and noticed that it’s actually GPL 3 or
later.  Here’s an except from the header of aspi.R:

--8<---------------cut here---------------start------------->8---
#  Analysis of Symmetry of Parasitic Infections is free software: you can        #
#  redistribute it and/or modify it under the terms of the GNU General Public    #
#  License as published by the Free Software Foundation, either version 3 of     #
#  the License, or (at your option) any later version.                           #
--8<---------------cut here---------------end--------------->8---

So this really should be “license:gpl3+”.

(I haven’t tried building the package yet.)

I think it’s fine to apply the patch with these minor changes.

--
Ricardo

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Gábor Boskovits]

Hello Laura,

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> ezt írta (időpont: 2018.
okt. 20., Szo, 10:17):
>
>
> Hi Laura,
>
> congratulations on your first patch to Guix!
>
> What follows are a few comments on minor changes that I would like to
> see before applying the patch to Guix.
>
> > From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 17 00:00:00 2001
> > From: laura <laura.lazzati.15@gmail.com>
> > Date: Fri, 19 Oct 2018 19:15:37 -0300
> > Subject: [PATCH] I add r-aspi package appended to cran.scm file
> >
> > ---
> >  gnu/packages/cran.scm | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
>
> For commits to Guix, we use a somewhat strict commit message format.
> You can take a look at the commit log to get a feel for it.  In the case
> of adding r-aspi to cran.scm this would be the expected commit message:
>
> --8<---------------cut here---------------start------------->8---
> gnu: Add r-aspi.
>
> * gnu/packages/cran.scm (r-aspi): New variable.
> --8<---------------cut here---------------end--------------->8---
>
> The first line is always a concise summary.  This is followed by a
> change log listing modified files and how they were modified.
>

You can also see git log for examples.

> > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> > index efcc2dccb..0d8ee6a97 100644
> > --- a/gnu/packages/cran.scm
> > +++ b/gnu/packages/cran.scm
> > @@ -6256,3 +6256,22 @@ a header row or not.  The dataset should contain
> > only one independent variable
> >  (x) and one dependent variable (y) and can contain a weight for each
> >  observation.")
> >      (license license:gpl2)))
> > +
> > +(define-public r-aspi
> > +  (package
> > +    (name "r-aspi")
> > +    (version "0.2.0")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (cran-uri "aspi" version))
> > +       (sha256
> > +        (base32
> > +         "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> > +    (build-system r-build-system)
> > +    (home-page "https://cran.r-project.org/web/packages/aspi/")
> > +    (synopsis "Analysis of Symmetry of Parasitic Infections")
>
> Please use lowercase for all words except for the first.  CRAN synopses
> are usually in titlecase and the importer can’t automatically figure out
> which words should be converted, so this needs to be done manually.
>
> > +    (description
> > +     "Tools for the analysis and visualization of bilateral asymmetry in
> > + parasitic infections.")
>
> Please use a complete sentence for the description.  The easiest way is
> probably to just prepend “This package provides”.
>
> > +    (license license:gpl3)))
>
> I checked the source files and noticed that it’s actually GPL 3 or
> later.  Here’s an except from the header of aspi.R:
>
> --8<---------------cut here---------------start------------->8---
> #  Analysis of Symmetry of Parasitic Infections is free software: you can        #
> #  redistribute it and/or modify it under the terms of the GNU General Public    #
> #  License as published by the Free Software Foundation, either version 3 of     #
> #  the License, or (at your option) any later version.                           #
> --8<---------------cut here---------------end--------------->8---
>
> So this really should be “license:gpl3+”.
>
> (I haven’t tried building the package yet.)
>

I will try this and report back.

> I think it’s fine to apply the patch with these minor changes.
>
> --
> Ricardo

Thanks Ricardo for the fast review!

Best regards,
g_bor

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Gábor Boskovits]

Hello Laura,

Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. okt.
20., Szo, 10:43):
>
> Hello Laura,
>
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> ezt írta (időpont: 2018.
> okt. 20., Szo, 10:17):
> >
> >
> > Hi Laura,
> >
> > congratulations on your first patch to Guix!
> >
> > What follows are a few comments on minor changes that I would like to
> > see before applying the patch to Guix.
> >
> > > From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 17 00:00:00 2001
> > > From: laura <laura.lazzati.15@gmail.com>
> > > Date: Fri, 19 Oct 2018 19:15:37 -0300
> > > Subject: [PATCH] I add r-aspi package appended to cran.scm file
> > >
> > > ---
> > >  gnu/packages/cran.scm | 19 +++++++++++++++++++
> > >  1 file changed, 19 insertions(+)
> >
> > For commits to Guix, we use a somewhat strict commit message format.
> > You can take a look at the commit log to get a feel for it.  In the case
> > of adding r-aspi to cran.scm this would be the expected commit message:
> >
> > --8<---------------cut here---------------start------------->8---
> > gnu: Add r-aspi.
> >
> > * gnu/packages/cran.scm (r-aspi): New variable.
> > --8<---------------cut here---------------end--------------->8---
> >
> > The first line is always a concise summary.  This is followed by a
> > change log listing modified files and how they were modified.
> >
>
> You can also see git log for examples.
>
> > > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> > > index efcc2dccb..0d8ee6a97 100644
> > > --- a/gnu/packages/cran.scm
> > > +++ b/gnu/packages/cran.scm
> > > @@ -6256,3 +6256,22 @@ a header row or not.  The dataset should contain
> > > only one independent variable
> > >  (x) and one dependent variable (y) and can contain a weight for each
> > >  observation.")
> > >      (license license:gpl2)))
> > > +
> > > +(define-public r-aspi
> > > +  (package
> > > +    (name "r-aspi")
> > > +    (version "0.2.0")
> > > +    (source
> > > +     (origin
> > > +       (method url-fetch)
> > > +       (uri (cran-uri "aspi" version))
> > > +       (sha256
> > > +        (base32
> > > +         "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> > > +    (build-system r-build-system)
> > > +    (home-page "https://cran.r-project.org/web/packages/aspi/")
> > > +    (synopsis "Analysis of Symmetry of Parasitic Infections")
> >
> > Please use lowercase for all words except for the first.  CRAN synopses
> > are usually in titlecase and the importer can’t automatically figure out
> > which words should be converted, so this needs to be done manually.
> >
> > > +    (description
> > > +     "Tools for the analysis and visualization of bilateral asymmetry in
> > > + parasitic infections.")
> >
> > Please use a complete sentence for the description.  The easiest way is
> > probably to just prepend “This package provides”.
> >
> > > +    (license license:gpl3)))
> >
> > I checked the source files and noticed that it’s actually GPL 3 or
> > later.  Here’s an except from the header of aspi.R:
> >
> > --8<---------------cut here---------------start------------->8---
> > #  Analysis of Symmetry of Parasitic Infections is free software: you can        #
> > #  redistribute it and/or modify it under the terms of the GNU General Public    #
> > #  License as published by the Free Software Foundation, either version 3 of     #
> > #  the License, or (at your option) any later version.                           #
> > --8<---------------cut here---------------end--------------->8---
> >
> > So this really should be “license:gpl3+”.
> >
> > (I haven’t tried building the package yet.)
> >
>
> I will try this and report back.
>

It builds for me fine, so with the suggestions Ricardo mentioned I think
it is good to go.

> > I think it’s fine to apply the patch with these minor changes.
> >
> > --
> > Ricardo

I had problem with applying this directly with git am, it
kept telling me the patch is corrupt on line 10.
Can someone have a look?

>
> Thanks Ricardo for the fast review!
>
> Best regards,
> g_bor

Best regards,
g_bor

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Gábor Boskovits]

Hello guix,

Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. okt.
20., Szo, 13:05):
>
> Hello Laura,
>
> Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. okt.
> 20., Szo, 10:43):
> >
> > Hello Laura,
> >
> > Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> ezt írta (időpont: 2018.
> > okt. 20., Szo, 10:17):
> > >
> > >
> > > Hi Laura,
> > >
> > > congratulations on your first patch to Guix!
> > >
> > > What follows are a few comments on minor changes that I would like to
> > > see before applying the patch to Guix.
> > >
> > > > From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 17 00:00:00 2001
> > > > From: laura <laura.lazzati.15@gmail.com>
> > > > Date: Fri, 19 Oct 2018 19:15:37 -0300
> > > > Subject: [PATCH] I add r-aspi package appended to cran.scm file
> > > >
> > > > ---
> > > >  gnu/packages/cran.scm | 19 +++++++++++++++++++
> > > >  1 file changed, 19 insertions(+)
> > >
> > > For commits to Guix, we use a somewhat strict commit message format.
> > > You can take a look at the commit log to get a feel for it.  In the case
> > > of adding r-aspi to cran.scm this would be the expected commit message:
> > >
> > > --8<---------------cut here---------------start------------->8---
> > > gnu: Add r-aspi.
> > >
> > > * gnu/packages/cran.scm (r-aspi): New variable.
> > > --8<---------------cut here---------------end--------------->8---
> > >
> > > The first line is always a concise summary.  This is followed by a
> > > change log listing modified files and how they were modified.
> > >
> >
> > You can also see git log for examples.
> >
> > > > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> > > > index efcc2dccb..0d8ee6a97 100644
> > > > --- a/gnu/packages/cran.scm
> > > > +++ b/gnu/packages/cran.scm
> > > > @@ -6256,3 +6256,22 @@ a header row or not.  The dataset should contain
> > > > only one independent variable
> > > >  (x) and one dependent variable (y) and can contain a weight for each
> > > >  observation.")
> > > >      (license license:gpl2)))
> > > > +
> > > > +(define-public r-aspi
> > > > +  (package
> > > > +    (name "r-aspi")
> > > > +    (version "0.2.0")
> > > > +    (source
> > > > +     (origin
> > > > +       (method url-fetch)
> > > > +       (uri (cran-uri "aspi" version))
> > > > +       (sha256
> > > > +        (base32
> > > > +         "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> > > > +    (build-system r-build-system)
> > > > +    (home-page "https://cran.r-project.org/web/packages/aspi/")
> > > > +    (synopsis "Analysis of Symmetry of Parasitic Infections")
> > >
> > > Please use lowercase for all words except for the first.  CRAN synopses
> > > are usually in titlecase and the importer can’t automatically figure out
> > > which words should be converted, so this needs to be done manually.
> > >
> > > > +    (description
> > > > +     "Tools for the analysis and visualization of bilateral asymmetry in
> > > > + parasitic infections.")
> > >
> > > Please use a complete sentence for the description.  The easiest way is
> > > probably to just prepend “This package provides”.
> > >
> > > > +    (license license:gpl3)))
> > >
> > > I checked the source files and noticed that it’s actually GPL 3 or
> > > later.  Here’s an except from the header of aspi.R:
> > >
> > > --8<---------------cut here---------------start------------->8---
> > > #  Analysis of Symmetry of Parasitic Infections is free software: you can        #
> > > #  redistribute it and/or modify it under the terms of the GNU General Public    #
> > > #  License as published by the Free Software Foundation, either version 3 of     #
> > > #  the License, or (at your option) any later version.                           #
> > > --8<---------------cut here---------------end--------------->8---
> > >
> > > So this really should be “license:gpl3+”.
> > >
> > > (I haven’t tried building the package yet.)
> > >
> >
> > I will try this and report back.
> >
>
> It builds for me fine, so with the suggestions Ricardo mentioned I think
> it is good to go.
>
> > > I think it’s fine to apply the patch with these minor changes.
> > >
> > > --
> > > Ricardo
>
> I had problem with applying this directly with git am, it
> kept telling me the patch is corrupt on line 10.
> Can someone have a look?
>

My bad, but it seems that at least partially debbugs is responsible for this,
It broke the long line in the patch, and it simply wrapped it around. I
downloaded the message from there using mbox. As there was no space
before the start of the line, the patch became corrupted.
Do you think this is bug?
I believe debbugs should not alter line endings.

> >
> > Thanks Ricardo for the fast review!
> >
> > Best regards,
> > g_bor
>
> Best regards,
> g_bor
Best regards,
g_bor

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Laura Lazzati]

[-- Attachment #1: Type: text/plain, Size: 5778 bytes --]

Thank you all for the feedback :)
I will apply all the changes and send the new version.
Shall I send the modified patch to the debbugs mail that is in the CC of
this mail?

On Sat, Oct 20, 2018 at 8:48 AM Gábor Boskovits <boskovits@gmail.com> wrote:

> Hello guix,
>
> Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. okt.
> 20., Szo, 13:05):
> >
> > Hello Laura,
> >
> > Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. okt.
> > 20., Szo, 10:43):
> > >
> > > Hello Laura,
> > >
> > > Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> ezt írta (időpont: 2018.
> > > okt. 20., Szo, 10:17):
> > > >
> > > >
> > > > Hi Laura,
> > > >
> > > > congratulations on your first patch to Guix!
> > > >
> > > > What follows are a few comments on minor changes that I would like to
> > > > see before applying the patch to Guix.
> > > >
> > > > > From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 17 00:00:00
> 2001
> > > > > From: laura <laura.lazzati.15@gmail.com>
> > > > > Date: Fri, 19 Oct 2018 19:15:37 -0300
> > > > > Subject: [PATCH] I add r-aspi package appended to cran.scm file
> > > > >
> > > > > ---
> > > > >  gnu/packages/cran.scm | 19 +++++++++++++++++++
> > > > >  1 file changed, 19 insertions(+)
> > > >
> > > > For commits to Guix, we use a somewhat strict commit message format.
> > > > You can take a look at the commit log to get a feel for it.  In the
> case
> > > > of adding r-aspi to cran.scm this would be the expected commit
> message:
> > > >
> > > > --8<---------------cut here---------------start------------->8---
> > > > gnu: Add r-aspi.
> > > >
> > > > * gnu/packages/cran.scm (r-aspi): New variable.
> > > > --8<---------------cut here---------------end--------------->8---
> > > >
> > > > The first line is always a concise summary.  This is followed by a
> > > > change log listing modified files and how they were modified.
> > > >
> > >
> > > You can also see git log for examples.
> > >
> > > > > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> > > > > index efcc2dccb..0d8ee6a97 100644
> > > > > --- a/gnu/packages/cran.scm
> > > > > +++ b/gnu/packages/cran.scm
> > > > > @@ -6256,3 +6256,22 @@ a header row or not.  The dataset should
> contain
> > > > > only one independent variable
> > > > >  (x) and one dependent variable (y) and can contain a weight for
> each
> > > > >  observation.")
> > > > >      (license license:gpl2)))
> > > > > +
> > > > > +(define-public r-aspi
> > > > > +  (package
> > > > > +    (name "r-aspi")
> > > > > +    (version "0.2.0")
> > > > > +    (source
> > > > > +     (origin
> > > > > +       (method url-fetch)
> > > > > +       (uri (cran-uri "aspi" version))
> > > > > +       (sha256
> > > > > +        (base32
> > > > > +
>  "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> > > > > +    (build-system r-build-system)
> > > > > +    (home-page "https://cran.r-project.org/web/packages/aspi/")
> > > > > +    (synopsis "Analysis of Symmetry of Parasitic Infections")
> > > >
> > > > Please use lowercase for all words except for the first.  CRAN
> synopses
> > > > are usually in titlecase and the importer can’t automatically figure
> out
> > > > which words should be converted, so this needs to be done manually.
>
Sorry for this, I just copied the comments in cran's website, I'll change
that.

> > > >
> > > > > +    (description
> > > > > +     "Tools for the analysis and visualization of bilateral
> asymmetry in
> > > > > + parasitic infections.")
> > > >
> > > > Please use a complete sentence for the description.  The easiest way
> is
> > > > probably to just prepend “This package provides”.
> > > >
> > > > > +    (license license:gpl3)))
> > > >
> > > > I checked the source files and noticed that it’s actually GPL 3 or
> > > > later.  Here’s an except from the header of aspi.R:
>
I guess this mistake was because in one of the several times of running
./pre-inst-env guix build r-aspi I was getting an error about the gpl
licence. I will change this too.

> > > >
> > > > --8<---------------cut here---------------start------------->8---
> > > > #  Analysis of Symmetry of Parasitic Infections is free software:
> you can        #
> > > > #  redistribute it and/or modify it under the terms of the GNU
> General Public    #
> > > > #  License as published by the Free Software Foundation, either
> version 3 of     #
> > > > #  the License, or (at your option) any later version.
>              #
> > > > --8<---------------cut here---------------end--------------->8---
> > > >
> > > > So this really should be “license:gpl3+”.
> > > >
> > > > (I haven’t tried building the package yet.)
> > > >
> > >
> > > I will try this and report back.
> > >
> >
> > It builds for me fine, so with the suggestions Ricardo mentioned I think
> > it is good to go.
> >
> > > > I think it’s fine to apply the patch with these minor changes.
> > > >
> > > > --
> > > > Ricardo
> >
> > I had problem with applying this directly with git am, it
> > kept telling me the patch is corrupt on line 10.
> > Can someone have a look?
> >
>
> My bad, but it seems that at least partially debbugs is responsible for
> this,
> It broke the long line in the patch, and it simply wrapped it around. I
> downloaded the message from there using mbox. As there was no space
> before the start of the line, the patch became corrupted.
> Do you think this is bug?
> I believe debbugs should not alter line endings.
>
> > >
> > > Thanks Ricardo for the fast review!
> > >
> > > Best regards,
> > > g_bor
> >
> > Best regards,
> > g_bor
> Best regards,
> g_bor
>
Regards!
Laura

[-- Attachment #2: Type: text/html, Size: 8261 bytes --]

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Ricardo Wurmus]

Hi Laura,

> I will apply all the changes and send the new version.
> Shall I send the modified patch to the debbugs mail that is in the CC of
> this mail?

Yes, please.

>> > > > > +    (synopsis "Analysis of Symmetry of Parasitic Infections")
>> > > >
>> > > > Please use lowercase for all words except for the first.  CRAN
>> synopses
>> > > > are usually in titlecase and the importer can’t automatically figure
>> out
>> > > > which words should be converted, so this needs to be done manually.
>>
> Sorry for this, I just copied the comments in cran's website, I'll change
> that.

Did you not use the CRAN importer to generate this package definition?
If you did not then you’re in for a treat as “guix import cran -r” can
*recursively* generate package definitions for packages on CRAN, even if
there are dozens of dependencies.

>> > > > > +    (license license:gpl3)))
>> > > >
>> > > > I checked the source files and noticed that it’s actually GPL 3 or
>> > > > later.  Here’s an except from the header of aspi.R:
>>
> I guess this mistake was because in one of the several times of running
> ./pre-inst-env guix build r-aspi I was getting an error about the gpl
> licence. I will change this too.

If you used the importer this is not your fault.  On CRAN the license is
listed as “GPL-3” which the importer turns into “gpl3”.  Often people
declare the license as just a single version even though their own
license headers permit later versions.

PS: please try to reduce the amount of text you quote in replies.  It’s
best to only leave the relevant parts that you’re replying to :)

--
Ricardo

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Laura Lazzati]

[-- Attachment #1: Type: text/plain, Size: 2049 bytes --]

On Sat, 20 Oct 2018, 18:35 Ricardo Wurmus, <ricardo.wurmus@mdc-berlin.de>
wrote:

>
> Hi Laura,
>
> > I will apply all the changes and send the new version.
> > Shall I send the modified patch to the debbugs mail that is in the CC of
> > this mail?
>
> Yes, please.
>
> >> > > > > +    (synopsis "Analysis of Symmetry of Parasitic Infections")
> >> > > >
> >> > > > Please use lowercase for all words except for the first.  CRAN
> >> synopses
> >> > > > are usually in titlecase and the importer can’t automatically
> figure
> >> out
> >> > > > which words should be converted, so this needs to be done
> manually.
> >>
> > Sorry for this, I just copied the comments in cran's website, I'll change
> > that.
>
> Did you not use the CRAN importer to generate this package definition?
> If you did not then you’re in for a treat as “guix import cran -r” can
> *recursively* generate package definitions for packages on CRAN, even if
> there are dozens of dependencies.
>
I guess this was my mistake. I did not understand that before. I just used
guix import  cran  <rpackage> for the templates and appended my package
with guix edit :/. I will send that fixed.

>
> >> > > > > +    (license license:gpl3)))
> >> > > >
> >> > > > I checked the source files and noticed that it’s actually GPL 3 or
> >> > > > later.  Here’s an except from the header of aspi.R:
> >>
> > I guess this mistake was because in one of the several times of running
> > ./pre-inst-env guix build r-aspi I was getting an error about the gpl
> > licence. I will change this too.
>
> If you used the importer this is not your fault.  On CRAN the license is
> listed as “GPL-3” which the importer turns into “gpl3”.  Often people
> declare the license as just a single version even though their own
> license headers permit later versions.
>
> PS: please try to reduce the amount of text you quote in replies.  It’s
> best to only leave the relevant parts that you’re replying to :)
>
> --
> Ricardo
>

[-- Attachment #2: Type: text/html, Size: 2809 bytes --]

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Laura Lazzati]

[-- Attachment #1: Type: text/plain, Size: 2349 bytes --]

Hi!

On Sat, Oct 20, 2018 at 6:35 PM Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
wrote:

>
> Hi Laura,
>
> > I will apply all the changes and send the new version.
> > Shall I send the modified patch to the debbugs mail that is in the CC of
> > this mail?
>
> Yes, please.
>
> >> > > > > +    (synopsis "Analysis of Symmetry of Parasitic Infections")
> >> > > >
> >> > > > Please use lowercase for all words except for the first.  CRAN
> >> synopses
> >> > > > are usually in titlecase and the importer can’t automatically
> figure
> >> out
> >> > > > which words should be converted, so this needs to be done
> manually.
> >>
> > Sorry for this, I just copied the comments in cran's website, I'll change
> > that.
>
> Did you not use the CRAN importer to generate this package definition?
> If you did not then you’re in for a treat as “guix import cran -r” can
> *recursively* generate package definitions for packages on CRAN, even if
> there are dozens of dependencies.
>
I don't understand this part. I ran the commands but complains for few
arguments.
Ran guix import cran --help and read the doc.
I can apply guix import cran -r p<SOMEPACKAGE> but not to whole r, don't
know if that's OK to get the template.
Or if it was OK running emacs cran.scm to make changes and then I should
run guix import cran -r r-aspi to check everything is alright.
As regards the other changes, I've already applied them to the r-aspi
definiton.

> >> > > > > +    (license license:gpl3)))
> >> > > >
> >> > > > I checked the source files and noticed that it’s actually GPL 3 or
> >> > > > later.  Here’s an except from the header of aspi.R:
> >>
> > I guess this mistake was because in one of the several times of running
> > ./pre-inst-env guix build r-aspi I was getting an error about the gpl
> > licence. I will change this too.
>
> If you used the importer this is not your fault.  On CRAN the license is
> listed as “GPL-3” which the importer turns into “gpl3”.  Often people
> declare the license as just a single version even though their own
> license headers permit later versions.
>
> PS: please try to reduce the amount of text you quote in replies.  It’s
> best to only leave the relevant parts that you’re replying to :)
>
> --
> Ricardo
>
Regards :)
Laura

[-- Attachment #2: Type: text/html, Size: 3116 bytes --]

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Laura Lazzati]

From 3628e4d7d4814777bb748c3f0ebba133814b2b94 Mon Sep 17 00:00:00 2001
From: laura <laura.lazzati.15@gmail.com>
Date: Sun, 21 Oct 2018 18:38:58 -0300
Subject: [PATCH] gnu: Add r-aspi

* gnu/packages/cran.scm (r-aspi): New variable
---
 gnu/packages/cran.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index efcc2dccb..c219065e8 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -6256,3 +6256,24 @@ a header row or not.  The dataset should
contain only one independent variable
 (x) and one dependent variable (y) and can contain a weight for each
 observation.")
     (license license:gpl2)))
+
+(define-public r-aspi
+  (package
+    (name "r-aspi")
+    (version "0.2.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (cran-uri "aspi" version))
+        (sha256
+          (base32
+            "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
+    (build-system r-build-system)
+    (home-page
+      "http://cran.r-project.org/web/packages/aspi")
+    (synopsis
+      "Analysis of symmetry of parasitic infections")
+    (description
+      "This package provides tools for the analysis and visualization
of bilateral
+ asymmetry in parasitic infections.")
+    (license license:gpl3+)))
-- 
2.17.1

On Sun, Oct 21, 2018 at 1:52 PM Laura Lazzati
<laura.lazzati.15@gmail.com> wrote:
>
> Hi!
>
> On Sat, Oct 20, 2018 at 6:35 PM Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:
>>
>>
>> Hi Laura,
>>
>> > I will apply all the changes and send the new version.
>> > Shall I send the modified patch to the debbugs mail that is in the CC of
>> > this mail?
>>
>> Yes, please.
>>
>> >> > > > > +    (synopsis "Analysis of Symmetry of Parasitic Infections")
>> >> > > >
>> >> > > > Please use lowercase for all words except for the first.  CRAN
>> >> synopses
>> >> > > > are usually in titlecase and the importer can’t automatically figure
>> >> out
>> >> > > > which words should be converted, so this needs to be done manually.
>> >>
>> > Sorry for this, I just copied the comments in cran's website, I'll change
>> > that.
>>
>> Did you not use the CRAN importer to generate this package definition?
>> If you did not then you’re in for a treat as “guix import cran -r” can
>> *recursively* generate package definitions for packages on CRAN, even if
>> there are dozens of dependencies.
>
> I don't understand this part. I ran the commands but complains for few arguments.
> Ran guix import cran --help and read the doc.
> I can apply guix import cran -r p<SOMEPACKAGE> but not to whole r, don't know if that's OK to get the template.
> Or if it was OK running emacs cran.scm to make changes and then I should run guix import cran -r r-aspi to check everything is alright.
> As regards the other changes, I've already applied them to the r-aspi definiton.
>>
>> >> > > > > +    (license license:gpl3)))
>> >> > > >
>> >> > > > I checked the source files and noticed that it’s actually GPL 3 or
>> >> > > > later.  Here’s an except from the header of aspi.R:
>> >>
>> > I guess this mistake was because in one of the several times of running
>> > ./pre-inst-env guix build r-aspi I was getting an error about the gpl
>> > licence. I will change this too.
>>
>> If you used the importer this is not your fault.  On CRAN the license is
>> listed as “GPL-3” which the importer turns into “gpl3”.  Often people
>> declare the license as just a single version even though their own
>> license headers permit later versions.
>>
>> PS: please try to reduce the amount of text you quote in replies.  It’s
>> best to only leave the relevant parts that you’re replying to :)
>>
>> --
>> Ricardo
>
> Regards :)
> Laura

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Gábor Boskovits]

Hello Laura,

Almost there!

Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont: 2018.
okt. 21., V, 23:54):
>
> From 3628e4d7d4814777bb748c3f0ebba133814b2b94 Mon Sep 17 00:00:00 2001
> From: laura <laura.lazzati.15@gmail.com>
> Date: Sun, 21 Oct 2018 18:38:58 -0300
> Subject: [PATCH] gnu: Add r-aspi
>
> * gnu/packages/cran.scm (r-aspi): New variable
> ---
>  gnu/packages/cran.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>

Just a bit knitpicking, could you add the periods to the commit message, like:

gnu: Add r-aspi.

* gnu/packages/patches/cran.scm (r-aspi): New variable.


> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index efcc2dccb..c219065e8 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -6256,3 +6256,24 @@ a header row or not.  The dataset should
> contain only one independent variable
>  (x) and one dependent variable (y) and can contain a weight for each
>  observation.")
>      (license license:gpl2)))
> +
> +(define-public r-aspi
> +  (package
> +    (name "r-aspi")
> +    (version "0.2.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (cran-uri "aspi" version))
> +        (sha256
> +          (base32
> +            "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> +    (build-system r-build-system)
> +    (home-page
> +      "http://cran.r-project.org/web/packages/aspi")
> +    (synopsis
> +      "Analysis of symmetry of parasitic infections")
> +    (description
> +      "This package provides tools for the analysis and visualization
> of bilateral
> + asymmetry in parasitic infections.")
> +    (license license:gpl3+)))
> --
> 2.17.1
>

This is fine now.

I still see these strange line breaks in the patch, how does that look on
you side?

Can you apply you own patches using git am?

You can send an updated patch with the corrected commit message,
or I can apply these minor changes and push it.
WDYT?

Best regards,
g_bor

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Laura Lazzati]

On Mon, 22 Oct 2018, 05:47 Gábor Boskovits, <boskovits@gmail.com> wrote:
>
> Hello Laura,
>
> Almost there!

Yes, after trying lots of things I figured out why it took me so long
to package it. The short story is that I did not understand that guix
import cran -r aspi was creating the template for me, I thought it
worked only for packages that were already packeged.I applied it to
another r package already available in guix, and modified it with
information about aspi from its website. The good side is that I
learned tons of guix commands.
>
>
> Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont: 2018.
> okt. 21., V, 23:54):
> >
> > From 3628e4d7d4814777bb748c3f0ebba133814b2b94 Mon Sep 17 00:00:00 2001
> > From: laura <laura.lazzati.15@gmail.com>
> > Date: Sun, 21 Oct 2018 18:38:58 -0300
> > Subject: [PATCH] gnu: Add r-aspi
> >
> > * gnu/packages/cran.scm (r-aspi): New variable
> > ---
> >  gnu/packages/cran.scm | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> >
>
> Just a bit knitpicking, could you add the periods to the commit message, like:
>
> gnu: Add r-aspi.
>
> * gnu/packages/patches/cran.scm (r-aspi): New variable.
>
>
> > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> > index efcc2dccb..c219065e8 100644
> > --- a/gnu/packages/cran.scm
> > +++ b/gnu/packages/cran.scm
> > @@ -6256,3 +6256,24 @@ a header row or not.  The dataset should
> > contain only one independent variable
> >  (x) and one dependent variable (y) and can contain a weight for each
> >  observation.")
> >      (license license:gpl2)))
> > +
> > +(define-public r-aspi
> > +  (package
> > +    (name "r-aspi")
> > +    (version "0.2.0")
> > +    (source
> > +      (origin
> > +        (method url-fetch)
> > +        (uri (cran-uri "aspi" version))
> > +        (sha256
> > +          (base32
> > +            "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> > +    (build-system r-build-system)
> > +    (home-page
> > +      "http://cran.r-project.org/web/packages/aspi")
> > +    (synopsis
> > +      "Analysis of symmetry of parasitic infections")
> > +    (description
> > +      "This package provides tools for the analysis and visualization
> > of bilateral
> > + asymmetry in parasitic infections.")
> > +    (license license:gpl3+)))
> > --
> > 2.17.1
> >
>
> This is fine now.
>
> I still see these strange line breaks in the patch, how does that look on
> you side?

I guess the problem was that I was adding a line break because in the
previous patch when building I had a complain that that line was too
long. I have just told emacs to truncate long lines and buld the
package without problems. My fault. It was one of the two changes that
I made from the original definiton. Adding that break line and adding
licence: before gpl3+ because otherwhise  I got the error: Unbound
variable: gpl3+.
>
>
> Can you apply you own patches using git am?
In my local repo?
>
> You can send an updated patch with the corrected commit message,
> or I can apply these minor changes and push it.
> WDYT?
If it is not a problem for you, let me try :)
Do you mean by changing the subject of this chain of messages? Is that
OK for sending the patch with the corrections, but keeping the
debugs.gnu.org mail with the number as it is in the To field?
>
> Best regards,
> g_bor

Regards :)
Laura

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Gábor Boskovits]

Hi Laura,

Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont: 2018.
okt. 22., H, 14:59):
>
> On Mon, 22 Oct 2018, 05:47 Gábor Boskovits, <boskovits@gmail.com> wrote:
> >
> > Hello Laura,
> >
> > Almost there!
>
> Yes, after trying lots of things I figured out why it took me so long
> to package it. The short story is that I did not understand that guix
> import cran -r aspi was creating the template for me, I thought it
> worked only for packages that were already packeged.I applied it to
> another r package already available in guix, and modified it with
> information about aspi from its website. The good side is that I
> learned tons of guix commands.
> >
> >
> > Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont: 2018.
> > okt. 21., V, 23:54):
> > >
> > > From 3628e4d7d4814777bb748c3f0ebba133814b2b94 Mon Sep 17 00:00:00 2001
> > > From: laura <laura.lazzati.15@gmail.com>
> > > Date: Sun, 21 Oct 2018 18:38:58 -0300
> > > Subject: [PATCH] gnu: Add r-aspi
> > >
> > > * gnu/packages/cran.scm (r-aspi): New variable
> > > ---
> > >  gnu/packages/cran.scm | 21 +++++++++++++++++++++
> > >  1 file changed, 21 insertions(+)
> > >
> >
> > Just a bit knitpicking, could you add the periods to the commit message, like:
> >
> > gnu: Add r-aspi.
> >
> > * gnu/packages/patches/cran.scm (r-aspi): New variable.
> >
> >
> > > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> > > index efcc2dccb..c219065e8 100644
> > > --- a/gnu/packages/cran.scm
> > > +++ b/gnu/packages/cran.scm
> > > @@ -6256,3 +6256,24 @@ a header row or not.  The dataset should
> > > contain only one independent variable
> > >  (x) and one dependent variable (y) and can contain a weight for each
> > >  observation.")
> > >      (license license:gpl2)))
> > > +
> > > +(define-public r-aspi
> > > +  (package
> > > +    (name "r-aspi")
> > > +    (version "0.2.0")
> > > +    (source
> > > +      (origin
> > > +        (method url-fetch)
> > > +        (uri (cran-uri "aspi" version))
> > > +        (sha256
> > > +          (base32
> > > +            "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> > > +    (build-system r-build-system)
> > > +    (home-page
> > > +      "http://cran.r-project.org/web/packages/aspi")
> > > +    (synopsis
> > > +      "Analysis of symmetry of parasitic infections")
> > > +    (description
> > > +      "This package provides tools for the analysis and visualization
> > > of bilateral
> > > + asymmetry in parasitic infections.")
> > > +    (license license:gpl3+)))
> > > --
> > > 2.17.1
> > >
> >
> > This is fine now.
> >
> > I still see these strange line breaks in the patch, how does that look on
> > you side?
>
> I guess the problem was that I was adding a line break because in the
> previous patch when building I had a complain that that line was too
> long. I have just told emacs to truncate long lines and buld the
> package without problems. My fault. It was one of the two changes that
> I made from the original definiton. Adding that break line and adding
> licence: before gpl3+ because otherwhise  I got the error: Unbound
> variable: gpl3+.
> >
> >
> > Can you apply you own patches using git am?
> In my local repo?
> >
> > You can send an updated patch with the corrected commit message,
> > or I can apply these minor changes and push it.
> > WDYT?
> If it is not a problem for you, let me try :)
> Do you mean by changing the subject of this chain of messages?

Yes, that would do half the job.

There is also a missing period in this line:
* gnu/packages/cran.scm (r-aspi): New variable

You can either fix these up manually, or using
git commit --amend, and fix these in the commit message.
That way git format-patch will fix these up.

> Is that
> OK for sending the patch with the corrections, but keeping the
> debugs.gnu.org mail with the number as it is in the To field?

Yes that is fine.

> >
> > Best regards,
> > g_bor
>
> Regards :)
> Laura

Best regards,
g_bor

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Laura Lazzati]

On Mon, Oct 22, 2018 at 10:39 AM Gábor Boskovits <boskovits@gmail.com> wrote:
>
> Hi Laura,
>
> Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont: 2018.
> okt. 22., H, 14:59):
> >
> > On Mon, 22 Oct 2018, 05:47 Gábor Boskovits, <boskovits@gmail.com> wrote:
> > >
> > > Hello Laura,
> > >
> > > Almost there!
> >
> > Yes, after trying lots of things I figured out why it took me so long
> > to package it. The short story is that I did not understand that guix
> > import cran -r aspi was creating the template for me, I thought it
> > worked only for packages that were already packeged.I applied it to
> > another r package already available in guix, and modified it with
> > information about aspi from its website. The good side is that I
> > learned tons of guix commands.
> > >
> > >
> > > Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont: 2018.
> > > okt. 21., V, 23:54):
> > > >
> > > > From 3628e4d7d4814777bb748c3f0ebba133814b2b94 Mon Sep 17 00:00:00 2001
> > > > From: laura <laura.lazzati.15@gmail.com>
> > > > Date: Sun, 21 Oct 2018 18:38:58 -0300
> > > > Subject: [PATCH] gnu: Add r-aspi
> > > >
> > > > * gnu/packages/cran.scm (r-aspi): New variable
> > > > ---
> > > >  gnu/packages/cran.scm | 21 +++++++++++++++++++++
> > > >  1 file changed, 21 insertions(+)
> > > >
> > >
> > > Just a bit knitpicking, could you add the periods to the commit message, like:
> > >
> > > gnu: Add r-aspi.
> > >
> > > * gnu/packages/patches/cran.scm (r-aspi): New variable.
> > >
> > >
> > > > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> > > > index efcc2dccb..c219065e8 100644
> > > > --- a/gnu/packages/cran.scm
> > > > +++ b/gnu/packages/cran.scm
> > > > @@ -6256,3 +6256,24 @@ a header row or not.  The dataset should
> > > > contain only one independent variable
> > > >  (x) and one dependent variable (y) and can contain a weight for each
> > > >  observation.")
> > > >      (license license:gpl2)))
> > > > +
> > > > +(define-public r-aspi
> > > > +  (package
> > > > +    (name "r-aspi")
> > > > +    (version "0.2.0")
> > > > +    (source
> > > > +      (origin
> > > > +        (method url-fetch)
> > > > +        (uri (cran-uri "aspi" version))
> > > > +        (sha256
> > > > +          (base32
> > > > +            "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> > > > +    (build-system r-build-system)
> > > > +    (home-page
> > > > +      "http://cran.r-project.org/web/packages/aspi")
> > > > +    (synopsis
> > > > +      "Analysis of symmetry of parasitic infections")
> > > > +    (description
> > > > +      "This package provides tools for the analysis and visualization
> > > > of bilateral
> > > > + asymmetry in parasitic infections.")
> > > > +    (license license:gpl3+)))
> > > > --
> > > > 2.17.1
> > > >
> > >
> > > This is fine now.
> > >
> > > I still see these strange line breaks in the patch, how does that look on
> > > you side?
> >
> > I guess the problem was that I was adding a line break because in the
> > previous patch when building I had a complain that that line was too
> > long. I have just told emacs to truncate long lines and buld the
> > package without problems. My fault. It was one of the two changes that
> > I made from the original definiton. Adding that break line and adding
> > licence: before gpl3+ because otherwhise  I got the error: Unbound
> > variable: gpl3+.
> > >
> > >
> > > Can you apply you own patches using git am?
> > In my local repo?
> > >
> > > You can send an updated patch with the corrected commit message,
> > > or I can apply these minor changes and push it.
> > > WDYT?
I have already changed the commit messages.
I have generated several times the new patch, went back and so forth.
I can't figure out what is wrong.
I tried applying the different patches I went on generating with git
am <anyaspipatch>.patch
I tend to get this error: error: patch failed: gnu/packages/cran.scm:6256
And when I take a look at cran.scm, that line belongs to the previous
package (the one before appending mines)
I read in the coding style that lines must not exceed 80 columns, but
when I open cran.scm there are several packages that do so.
And if I don't add an eol in the description (is it there where you
see the line break?), after running lint command I get:
/home/laura/guix/gnu/packages/cran.scm:6261:2: r-aspi@0.2.0: line 6276
is way too long (119 characters)
Any ideas of how to help me fix this?
> > If it is not a problem for you, let me try :)
> > Do you mean by changing the subject of this chain of messages?
>
> Yes, that would do half the job.
>
> There is also a missing period in this line:
> * gnu/packages/cran.scm (r-aspi): New variable
>
> You can either fix these up manually, or using
> git commit --amend, and fix these in the commit message.
> That way git format-patch will fix these up.
>
> > Is that
> > OK for sending the patch with the corrections, but keeping the
> > debugs.gnu.org mail with the number as it is in the To field?
>
> Yes that is fine.
>
> > >
> > > Best regards,
> > > g_bor
> >
> > Regards :)
> > Laura
>
> Best regards,
> g_bor

Regards!
Laura

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Ricardo Wurmus]

Hi Laura,

> And if I don't add an eol in the description (is it there where you
> see the line break?), after running lint command I get:
> /home/laura/guix/gnu/packages/cran.scm:6261:2: r-aspi@0.2.0: line 6276
> is way too long (119 characters)

You should break the lines in your editor and then commit the changes
and format the patch.  The patch itself should not be modified.

Gábor’s question is about the patch itself, which appears to have a line
break in an unexpected place.  This may be a result of pasting it into
your email client.  It is probably better to attach the generated file
instead.

--
Ricardo

[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Gábor Boskovits]

Hello Laura,

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> ezt írta (időpont: 2018.
okt. 23., K, 9:06):
>
>
> Hi Laura,
>
> > And if I don't add an eol in the description (is it there where you
> > see the line break?), after running lint command I get:
> > /home/laura/guix/gnu/packages/cran.scm:6261:2: r-aspi@0.2.0: line 6276
> > is way too long (119 characters)
>
> You should break the lines in your editor and then commit the changes
> and format the patch.  The patch itself should not be modified.
>
> Gábor’s question is about the patch itself, which appears to have a line
> break in an unexpected place.  This may be a result of pasting it into
> your email client.  It is probably better to attach the generated file
> instead.
>

Yes, please, try to send the patch attached, I will be able to have a look
only tomorrow, because today is a national holiday in Hungary, and we
are expecting guests, but this contribution is in really good shape already.

> --
> Ricardo
g_bor

[bug#33099] gnu: Add r-aspi.

[Laura Lazzati]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 0001-gnu-Add-r-aspi.patch --]
[-- Type: text/x-patch, Size: 1317 bytes --]

From 1c8a74481f93b7eb22d11a77062c0c5544e05d8d Mon Sep 17 00:00:00 2001
From: laura <laura.lazzati.15@gmail.com>
Date: Tue, 23 Oct 2018 01:59:22 -0300
Subject: [PATCH] gnu: Add r-aspi.

* gnu/packages/cran.scm (r-aspi): New variable.
---
 gnu/packages/cran.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index efcc2dccb..b9b2f3baa 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -6256,3 +6256,23 @@ a header row or not.  The dataset should contain only one independent variable
 (x) and one dependent variable (y) and can contain a weight for each
 observation.")
     (license license:gpl2)))
+
+(define-public r-aspi
+  (package
+    (name "r-aspi")
+    (version "0.2.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (cran-uri "aspi" version))
+       (sha256
+        (base32 "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
+    (build-system r-build-system)
+    (home-page
+     "http://cran.r-project.org/web/packages/aspi/")
+    (synopsis
+     "Analysis of symmetry of parasitic infections")
+    (description
+     "This package provides tools for the analysis and visualization of bilateral
+      asymmetry in parasitic infections.")
+    (license license:gpl3+)))
-- 
2.17.1

[bug#33099] gnu: Add r-aspi.

[Björn Höfling]

[-- Attachment #1: Type: text/plain, Size: 824 bytes --]

On Tue, 23 Oct 2018 07:16:00 -0300
Laura Lazzati <laura.lazzati.15@gmail.com> wrote:

> 

Hi Laura,

I noted three things, sorry this wasn't mentioned before:

1) Your name in the commit is:

Author: laura <laura.lazzati.15@gmail.com>  2018-10-23 06:59:22

Is that intended or do you prefer the full name in capitals (i.e.
"Laura Lazzati", as you have set in your emails)?

If not, set the name correctly with 

git config --global user.name "Laura Lazzati"

2) Add a Copyright line for yourself, just copy any other from the file:

;;; Copyright © 2018 Name <email> ...

3) Change the Homepage to use HTTPS.

Otherwise, LGTM ("Looks good to me").

If you decide on 1) then I think a committer could add/correct these for
you instead of endlessly sending out new patches.

Thanks!

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[bug#33099] gnu: Add r-aspi.

[Laura Lazzati]

[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]

On Tue, Oct 23, 2018 at 9:53 AM Björn Höfling
<bjoern.hoefling@bjoernhoefling.de> wrote:
>
> On Tue, 23 Oct 2018 07:16:00 -0300
> Laura Lazzati <laura.lazzati.15@gmail.com> wrote:
>
> >
>
> Hi Laura,
>
> I noted three things, sorry this wasn't mentioned before:
>
> 1) Your name in the commit is:
>
> Author: laura <laura.lazzati.15@gmail.com>  2018-10-23 06:59:22
>
> Is that intended or do you prefer the full name in capitals (i.e.
> "Laura Lazzati", as you have set in your emails)?
>
> If not, set the name correctly with
>
> git config --global user.name "Laura Lazzati"
It was intentional, but I have already corrected it.
>
> 2) Add a Copyright line for yourself, just copy any other from the file:
>
> ;;; Copyright © 2018 Name <email> ...
>
> 3) Change the Homepage to use HTTPS.
>
> Otherwise, LGTM ("Looks good to me").
>
> If you decide on 1) then I think a committer could add/correct these for
> you instead of endlessly sending out new patches.
>
> Thanks!
>
> Björn
Here goes hope the last version. When approved I have some questions
to ask :), most of them to improve future patches
Regards,
Laura

[-- Attachment #2: 0001-gnu-Add-r-aspi.patch --]
[-- Type: text/x-patch, Size: 1189 bytes --]

From 0c5eba8ab24bb55f888d630eeccda604558cdefe Mon Sep 17 00:00:00 2001
From: Laura Lazzati <laura.lazzati.15@gmail.com>
Date: Tue, 23 Oct 2018 11:38:34 -0300
Subject: [PATCH] gnu: Add r-aspi.

* gnu/packages/cran.scm (r-aspi): New variable.
---
 gnu/packages/cran.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index b9b2f3baa..73680a745 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2018 Charlie Ritter <chewzeirta@posteo.net>
 ;;; Copyright © 2018 Konrad Hinsen <konrad.hinsen@fastmail.net>
 ;;; Copyright © 2018 Mădălin Ionel Patrașcu <madalinionel.patrascu@mdc-berlin.de>
+;;; Copyright © 2018 Laura Lazzati <laura.lazzati.15@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6269,7 +6270,7 @@ observation.")
         (base32 "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
     (build-system r-build-system)
     (home-page
-     "http://cran.r-project.org/web/packages/aspi/")
+     "https://cran.r-project.org/web/packages/aspi/")
     (synopsis
      "Analysis of symmetry of parasitic infections")
     (description
-- 
2.17.1

[bug#33099] gnu: Add r-aspi.

[Gábor Boskovits]

Hello Laura,

Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont: 2018.
okt. 23., K, 16:48):
>
> On Tue, Oct 23, 2018 at 9:53 AM Björn Höfling
> <bjoern.hoefling@bjoernhoefling.de> wrote:

> Here goes hope the last version. When approved I have some questions
> to ask :), most of them to improve future patches

This patch seems to be incomplete. Most probably it is meant to be appiled on
another patch. You can squash multiple commits to one, and get a
single commit and
a single patch.

The patch format is right now, so please keep sending them as attachment.

> Regards,
> Laura
Best regards,
g_bor

[bug#33099] gnu: Add r-aspi.

[Björn Höfling]

[-- Attachment #1: Type: text/plain, Size: 895 bytes --]

On Tue, 23 Oct 2018 20:29:22 +0200
Gábor Boskovits <boskovits@gmail.com> wrote:

> Hello Laura,
> 
> Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont: 2018.
> okt. 23., K, 16:48):
> >
> > On Tue, Oct 23, 2018 at 9:53 AM Björn Höfling
> > <bjoern.hoefling@bjoernhoefling.de> wrote:  
> 
> > Here goes hope the last version. When approved I have some questions
> > to ask :), most of them to improve future patches  
> 
> This patch seems to be incomplete. Most probably it is meant to be
> appiled on another patch. You can squash multiple commits to one, and
> get a single commit and
> a single patch.

I case you don't know, you can use git rebase -i in order to do that.

As you have probably two linarly consequtive commits, a

git rebase -i HEAD~2 

should do it. Read more here:

https://git-scm.com/docs/git-rebase#_interactive_mode

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[bug#33099] gnu: Add r-aspi.

[Laura Lazzati]

[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]

On Tue, Oct 23, 2018 at 4:33 PM Björn Höfling
<bjoern.hoefling@bjoernhoefling.de> wrote:
>
> On Tue, 23 Oct 2018 20:29:22 +0200
> Gábor Boskovits <boskovits@gmail.com> wrote:
>
> > Hello Laura,
> >
> > Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont: 2018.
> > okt. 23., K, 16:48):
> > >
> > > On Tue, Oct 23, 2018 at 9:53 AM Björn Höfling
> > > <bjoern.hoefling@bjoernhoefling.de> wrote:
> >
> > > Here goes hope the last version. When approved I have some questions
> > > to ask :), most of them to improve future patches
> >
> > This patch seems to be incomplete. Most probably it is meant to be
> > appiled on another patch. You can squash multiple commits to one, and
> > get a single commit and
> > a single patch.
>
> I case you don't know, you can use git rebase -i in order to do that.
>
> As you have probably two linarly consequtive commits, a
>
> git rebase -i HEAD~2
>
> should do it. Read more here:
>
> https://git-scm.com/docs/git-rebase#_interactive_mode
I was reading a tutorial mentioning that.
I managed to do so, and after that made a commit --amend to adjust my
git username - I applied the changes after the first commit.
Thanks for answering on your holiday day :)

>
> Björn

Regards,
Laura

[-- Attachment #2: 0001-gnu-Add-r-aspi.patch --]
[-- Type: application/x-patch, Size: 1670 bytes --]

[bug#33099] gnu: Add r-aspi.

[Björn Höfling]

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

On Tue, 23 Oct 2018 17:04:16 -0300
Laura Lazzati <laura.lazzati.15@gmail.com> wrote:

> On Tue, Oct 23, 2018 at 4:33 PM Björn Höfling
> <bjoern.hoefling@bjoernhoefling.de> wrote:
> >
> > On Tue, 23 Oct 2018 20:29:22 +0200
> > Gábor Boskovits <boskovits@gmail.com> wrote:
> >
> > > Hello Laura,
> > >
> > > Laura Lazzati <laura.lazzati.15@gmail.com> ezt írta (időpont:
> > > 2018. okt. 23., K, 16:48):
> > > >
> > > > On Tue, Oct 23, 2018 at 9:53 AM Björn Höfling
> > > > <bjoern.hoefling@bjoernhoefling.de> wrote:
> > >
> > > > Here goes hope the last version. When approved I have some
> > > > questions to ask :), most of them to improve future patches
> > >
> > > This patch seems to be incomplete. Most probably it is meant to be
> > > appiled on another patch. You can squash multiple commits to one,
> > > and get a single commit and
> > > a single patch.
> >
> > I case you don't know, you can use git rebase -i in order to do
> > that.
> >
> > As you have probably two linarly consequtive commits, a
> >
> > git rebase -i HEAD~2
> >
> > should do it. Read more here:
> >
> > https://git-scm.com/docs/git-rebase#_interactive_mode
> I was reading a tutorial mentioning that.
> I managed to do so, and after that made a commit --amend to adjust my
> git username - I applied the changes after the first commit.
> Thanks for answering on your holiday day :)

LGTM.

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

bug#33099: gnu: Add r-aspi.

[Gábor Boskovits]

Thank you for all!

Pushed to master as b55697fbb430ae9a973eeae91f09213d1e603a9e.

[bug#33099] gnu: Add r-aspi.

[Laura Lazzati]

On Tue, Oct 23, 2018 at 6:42 PM Gábor Boskovits <boskovits@gmail.com> wrote:
>
> Thank you for all!
>
> Pushed to master as b55697fbb430ae9a973eeae91f09213d1e603a9e.

Yeah :)
Regards!
Laura

[bug#33099] gnu: Add r-aspi.

[Björn Höfling]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

On Tue, 23 Oct 2018 22:08:04 -0300
Laura Lazzati <laura.lazzati.15@gmail.com> wrote:

> On Tue, Oct 23, 2018 at 6:42 PM Gábor Boskovits <boskovits@gmail.com>
> wrote:
> >
> > Thank you for all!
> >
> > Pushed to master as b55697fbb430ae9a973eeae91f09213d1e603a9e.  
> 
> Yeah :)
> Regards!
> Laura

Congratulations!

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]