From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gF3fi-0003dH-5O for guix-patches@gnu.org; Tue, 23 Oct 2018 16:53:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gF3SG-00089u-Pm for guix-patches@gnu.org; Tue, 23 Oct 2018 16:39:12 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34307) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gF3S9-00084d-Ut for guix-patches@gnu.org; Tue, 23 Oct 2018 16:39:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gF3S9-0002FR-Sw for guix-patches@gnu.org; Tue, 23 Oct 2018 16:39:01 -0400 Subject: [bug#33099] gnu: Add r-aspi. Resent-Message-ID: Date: Tue, 23 Oct 2018 22:38:00 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20181023223800.36a1522d@alma-ubu> In-Reply-To: References: <20181023145330.1919e5ef@alma-ubu> <20181023213313.74f2e75e@alma-ubu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/W6z.atllXlzvucqe6x9Gfpl"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Laura Lazzati Cc: =?UTF-8?Q?G=C3=A1bor?= Boskovits , Ricardo Wurmus , 33099@debbugs.gnu.org --Sig_/W6z.atllXlzvucqe6x9Gfpl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 23 Oct 2018 17:04:16 -0300 Laura Lazzati wrote: > On Tue, Oct 23, 2018 at 4:33 PM Bj=C3=B6rn H=C3=B6fling > wrote: > > > > On Tue, 23 Oct 2018 20:29:22 +0200 > > G=C3=A1bor Boskovits wrote: > > > > > Hello Laura, > > > > > > Laura Lazzati ezt =C3=ADrta (id=C5=91pon= t: > > > 2018. okt. 23., K, 16:48): > > > > > > > > On Tue, Oct 23, 2018 at 9:53 AM Bj=C3=B6rn H=C3=B6fling > > > > wrote: > > > > > > > Here goes hope the last version. When approved I have some > > > > questions to ask :), most of them to improve future patches > > > > > > This patch seems to be incomplete. Most probably it is meant to be > > > appiled on another patch. You can squash multiple commits to one, > > > and get a single commit and > > > a single patch. > > > > I case you don't know, you can use git rebase -i in order to do > > that. > > > > As you have probably two linarly consequtive commits, a > > > > git rebase -i HEAD~2 > > > > should do it. Read more here: > > > > https://git-scm.com/docs/git-rebase#_interactive_mode > I was reading a tutorial mentioning that. > I managed to do so, and after that made a commit --amend to adjust my > git username - I applied the changes after the first commit. > Thanks for answering on your holiday day :) LGTM. Bj=C3=B6rn --Sig_/W6z.atllXlzvucqe6x9Gfpl Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlvPhqkACgkQvyhstlk+X/37TACePFyMTff3ape/EosLpPb9cW7l rr4An2y5+6fdj2Hot+21G9F9Kijxsc4N =OMCe -----END PGP SIGNATURE----- --Sig_/W6z.atllXlzvucqe6x9Gfpl--